Skip to content

Commit cacdbd1

Browse files
author
Teppo Järvelin
committed
Cellular: Fixed sms unit tests.
1 parent fe2e4a3 commit cacdbd1

File tree

1 file changed

+9
-10
lines changed

1 file changed

+9
-10
lines changed

features/cellular/UNITTESTS/at/at_cellularsms/test_at_cellularsms.cpp

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -68,38 +68,37 @@ void Test_AT_CellularSMS::test_AT_CellularSMS_send_sms()
6868
ATHandler at(&fh1, que, 0, ",");
6969

7070
AT_CellularSMS sms(at);
71-
CHECK(NSAPI_ERROR_PARAMETER == sms.send_sms(NULL, "2", 1));
71+
LONGS_EQUAL(NSAPI_ERROR_PARAMETER, sms.send_sms(NULL, "2", 1));
7272

7373
sms.initialize(CellularSMS::CellularSMSMmodeText);
7474
ATHandler_stub::size_value = 1;
75-
CHECK(1 == sms.send_sms("1", "22", 2));
75+
LONGS_EQUAL(1, sms.send_sms("1", "22", 2));
7676

7777
ATHandler_stub::size_value = 2;
78-
CHECK(2 == sms.send_sms("1", "22", 2));
78+
LONGS_EQUAL(2, sms.send_sms("1", "22", 2));
7979

80+
ATHandler_stub::return_given_size = true; // PDU mode write is much longer than than msg len
8081
sms.initialize(CellularSMS::CellularSMSMmodePDU);
81-
CHECK(2 == sms.send_sms("1", "23", 2));
82+
LONGS_EQUAL(2, sms.send_sms("1", "23", 2));;
8283

8384
ATHandler_stub::nsapi_error_ok_counter = 1;
8485
ATHandler_stub::size_value = 32;
8586
ATHandler_stub::nsapi_error_value = NSAPI_ERROR_AUTH_FAILURE;
86-
CHECK(NSAPI_ERROR_AUTH_FAILURE == sms.send_sms("1", "23232323", 8));
87+
LONGS_EQUAL(NSAPI_ERROR_AUTH_FAILURE, sms.send_sms("1", "23232323", 8));
8788

8889
ATHandler_stub::nsapi_error_ok_counter = 2;
8990
ATHandler_stub::size_value = 32;
9091
ATHandler_stub::nsapi_error_value = NSAPI_ERROR_AUTH_FAILURE;
91-
CHECK(NSAPI_ERROR_AUTH_FAILURE == sms.send_sms("1", "23232323", 8));
92+
LONGS_EQUAL(NSAPI_ERROR_AUTH_FAILURE, sms.send_sms("1", "23232323", 8));
9293

9394
ATHandler_stub::nsapi_error_value = NSAPI_ERROR_OK;
9495
char table[] = "232323232323232323232323232323232323232323232323232323\
9596
232323232323232323232323232323232323232323232323232323\
9697
232323232323232323232323232323232323232323232323232323\
9798
23232323232323232323232323232323232323\0";
98-
ATHandler_stub::size_value = 0;
99-
ATHandler_stub::return_given_size = true;
100-
CHECK(218 == sms.send_sms("1", table, strlen(table)));
10199

102-
CHECK(218 == sms.send_sms("12", table, strlen(table)));
100+
LONGS_EQUAL(strlen(table), sms.send_sms("1", table, strlen(table)));
101+
LONGS_EQUAL(strlen(table), sms.send_sms("12", table, strlen(table)));
103102
}
104103

105104

0 commit comments

Comments
 (0)