TEST_APPS socket_app leaks memory when cannot initialize packetSizes

janjongboom · web-flow · commit d26dc88e9e6c · 2019-03-07T16:16:04.000+01:00
diff --git a/TEST_APPS/device/socket_app/cmd_socket.cpp b/TEST_APPS/device/socket_app/cmd_socket.cpp
@@ -673,6 +673,7 @@ static nsapi_size_or_error_t start_udp_receiver_thread(SInfo *info, int argc, ch
     int *packetSizes = new (nothrow) int[PACKET_SIZE_ARRAY_LEN];
     if (!packetSizes) {
         cmd_printf("Allocation failed\r\n");
+        free(dataIn);
         return CMDLINE_RETCODE_FAIL;
     }
     for (int i = 0; i < PACKET_SIZE_ARRAY_LEN; i++) {

Original file line number	Diff line number	Diff line change
`@@ -673,6 +673,7 @@ static nsapi_size_or_error_t start_udp_receiver_thread(SInfo *info, int argc, ch`
`673`	`673`	`int *packetSizes = new (nothrow) int[PACKET_SIZE_ARRAY_LEN];`
`674`	`674`	`if (!packetSizes) {`
`675`	`675`	`cmd_printf("Allocation failed\r\n");`
	`676`	`+ free(dataIn);`
`676`	`677`	`return CMDLINE_RETCODE_FAIL;`
`677`	`678`	`}`
`678`	`679`	`for (int i = 0; i < PACKET_SIZE_ARRAY_LEN; i++) {`