Skip to content

Commit d611d7b

Browse files
tung7970adbridge
authored andcommitted
rtl8195am - fix i2c_api.c warnings
Fix the following warnings: [Warning] i2c_api.c@94,26: comparison between signed and unsigned integer expressions [-Wsign-compare] [Warning] i2c_api.c@231,5: implicit declaration of function 'memset' [-Wimplicit-function-declaration] [Warning] i2c_api.c@460,14: unused variable 'i2c_default_addr' [-Wunused-variable] Signed-off-by: Tony Wu <[email protected]>
1 parent 87381de commit d611d7b

File tree

1 file changed

+7
-6
lines changed
  • targets/TARGET_Realtek/TARGET_AMEBA/TARGET_RTL8195A

1 file changed

+7
-6
lines changed

targets/TARGET_Realtek/TARGET_AMEBA/TARGET_RTL8195A/i2c_api.c

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@
1414
* limitations under the License.
1515
*/
1616

17+
#include <string.h>
18+
1719
#include "objects.h"
1820
#include "PinNames.h"
1921
#include "hal_i2c.h"
@@ -78,18 +80,18 @@ extern u32 ConfigDebugErr;
7880
extern u32 ConfigDebuginfo;
7981
void i2c_init(i2c_t *obj, PinName sda, PinName scl)
8082
{
81-
uint32_t i2c_sel;
82-
uint32_t i2c_idx;
83+
int i2c_sel;
84+
int i2c_idx;
8385
PSAL_I2C_MNGT_ADPT pSalI2CMngtAdpt = NULL;
8486
PSAL_I2C_USERCB_ADPT pSalI2CUserCBAdpt = NULL;
8587
PSAL_I2C_HND pSalI2CHND = NULL;
8688

8789
// Determine the I2C to use
88-
uint32_t i2c_sda = (uint32_t)pinmap_peripheral(sda, PinMap_I2C_SDA);
89-
uint32_t i2c_scl = (uint32_t)pinmap_peripheral(scl, PinMap_I2C_SCL);
90+
int i2c_sda = (uint32_t)pinmap_peripheral(sda, PinMap_I2C_SDA);
91+
int i2c_scl = (uint32_t)pinmap_peripheral(scl, PinMap_I2C_SCL);
9092
ConfigDebugErr &= (~(_DBG_I2C_|_DBG_GDMA_));
9193
ConfigDebugInfo&= (~(_DBG_I2C_|_DBG_GDMA_));
92-
i2c_sel = (uint32_t)pinmap_merge(i2c_sda, i2c_scl);
94+
i2c_sel = pinmap_merge(i2c_sda, i2c_scl);
9395
i2c_idx = RTL_GET_PERI_IDX(i2c_sel);
9496
if (unlikely(i2c_idx == NC)) {
9597
DBG_8195A("%s: Cannot find matched UART\n", __FUNCTION__);
@@ -457,7 +459,6 @@ void i2c_slave_address(i2c_t *obj, int idx, uint32_t address, uint32_t mask)
457459
pSalI2CHND = &(pSalI2CMngtAdpt->pSalHndPriv->SalI2CHndPriv);
458460
address = (address & 0xFE ) >>1;
459461

460-
uint16_t i2c_default_addr = (uint16_t) pSalI2CHND->I2CAckAddr;
461462
uint16_t i2c_user_addr = (uint16_t) address;
462463

463464
if (i2c_target_addr[pSalI2CHND->DevNum] != i2c_user_addr) {

0 commit comments

Comments
 (0)