code review from paul,don addressed:compilers fixed

Author: ConradBraam

TEST_APPS/device/nfcapp/mbed_app.json

@@ -1,19 +1,28 @@
 {
     "config": {
-        "TEST_NDEF_MSG_MAX" : 1024
+        "TEST_NDEF_MSG_MAX": {
+            "help": "NFC-Driver buffer (EEPROM and Controller) maximum MAX Size of NFC message(s) driver buffer",
+            "value": 4096
+        }
     },
     "target_overrides": {
         "DISCO_L475VG_IOT01A": {
             "target.extra_labels_add": ["M24SR"],
-	    "MBED_NFC_M24SR.nfceeprom": true
+            "MBED_NFC_M24SR.nfceeprom": true
         },
         "NUCLEO_F401RE": {
-            "target.extra_labels_add": ["PN512"]
+            "target.extra_labels_add": ["PN512"],
+	    "MBED_NFC_M24SR.nfceeprom": false
         },
         "NUCLEO_F746ZG": {
             "target.extra_labels_add": ["M24SR"],
 	    "MBED_NFC_M24SR.X_NUCLEO_NFC01A1": true,
 	    "MBED_NFC_M24SR.nfceeprom": true
+        },
+        "NUCLEO_F429ZI": {
+            "target.extra_labels_add": ["M24SR"],
+	    "MBED_NFC_M24SR.X_NUCLEO_NFC01A1": true,
+	    "MBED_NFC_M24SR.nfceeprom": true
         }
     }
 }

TEST_APPS/device/nfcapp/nfccommands.cpp

@@ -17,6 +17,7 @@
 #include <vector>
 #include <stdarg.h>
 #include <stdlib.h>
+#include <ctype.h>
 #include "mbed_events.h"
 #include "mbed-client-cli/ns_cmdline.h"
 #include "rtos\Thread.h"

TEST_APPS/device/nfcapp/nfcprocessEeprom.cpp

@@ -17,6 +17,7 @@
 #include <stdarg.h>
 #include <cstring>
 #include <string.h>
+#include <stdlib.h>
 #include "mbed_events.h"
 #include "mbed-client-cli/ns_cmdline.h"
 
@@ -98,6 +99,7 @@ void NFCProcessEEPROM::on_ndef_message_written(nfc_err_t result)
     }
     // complete the async test method here
     cmd_ready(CMDLINE_RETCODE_SUCCESS);
+    free(long_string); // free buffer allocated by the command class now
 }
 
 void NFCProcessEEPROM::on_ndef_message_read(nfc_err_t result)

TEST_APPS/device/nfcapp/nfcprocessEeprom.h

@@ -38,12 +38,12 @@
 class NFCProcessEEPROM : NFCTestShim, mbed::nfc::NFCEEPROM::Delegate {
 public:
     NFCProcessEEPROM(events::EventQueue &queue, mbed::nfc::NFCEEPROMDriver &eeprom_driver);
-    nfc_err_t init();
+    virtual nfc_err_t init();
     void queue_write_call();
     void queue_write_long_call();
     void queue_read_call();
     void queue_erase_call();
-    void cmd_get_max_ndef();
+    virtual void cmd_get_max_ndef();
 
 
 private:

TEST_APPS/device/nfcapp/nfctestshim.cpp

@@ -17,6 +17,7 @@
 #include <stdarg.h>
 #include <cstring>
 #include <string.h>
+#include <stdlib.h>
 #include "mbed-client-cli/ns_cmdline.h"
 #include "nfc/ndef/common/Text.h"
 #include "nfc/ndef/common/URI.h"
@@ -41,7 +42,7 @@ using mbed::nfc::nfc_rf_protocols_bitmask_t;
 
 // statics
 namespace {
-char long_string[MBED_CONF_APP_TEST_NDEF_MSG_MAX];
+
 char const   *uri_prefix_string[] = { "",
                                       "http://www.",
                                       "https://www.",
@@ -278,15 +279,15 @@ void NFCTestShim::cmd_erase()
 
 /** \brief Writes a Text T record buffer with really long message - length checks to be done by driver only.
   * If an NFC controller, no write to the chip happens, we copy the data into a Controller buffer
-  * \param uri This method must free the passed in pointer
-  * \return void An ICETEA error code and NFC error is set asyncronously
+  * \param text_string This method must free the passed in pointer
+  * \return void An ICETEA error code and NFC error is set asynchronously
   */
 void NFCTestShim::cmd_write_long(char *text_string)
 {
     MessageBuilder builder(_ndef_poster_message);
-    strcpy(::long_string, text_string); //max_ndef - header - overheads
+    long_string = text_string; // copy the pointer and free it when the write completes
     Text text(Text::UTF8, span_from_cstr("en-US"),
-              span_from_cstr((const char *)(::long_string)));
+              span_from_cstr((const char *)(long_string)));
 
     text.append_as_record(builder, true);
     _ndef_write_buffer_used = builder.get_message().size();
@@ -295,12 +296,12 @@ void NFCTestShim::cmd_write_long(char *text_string)
 #if MBED_CONF_NFCEEPROM
     ((NFCProcessEEPROM *)this)->queue_write_call();
 #else
-    // not on a wire, so the caller will store the message in a buffer
+    // not on a wire, and we just stored the message in _ndef_write_buffer above
     set_last_nfc_error(NFC_OK);
     cmd_ready(CMDLINE_RETCODE_SUCCESS);
+    free(long_string); // free buffer allocated by the command class now
 #endif
     trace_printf("NFCTestShim::write_long() exit\r\n");
-    free(text_string);
 }
 
 /** \brief Write a URI Use case would be to prompt to install an app from the appstore using the tag

TEST_APPS/device/nfcapp/nfctestshim.h

@@ -100,6 +100,7 @@ class NFCTestShim {
     uint8_t _ndef_buffer[MBED_CONF_APP_TEST_NDEF_MSG_MAX];       // driver I/O buffer
     bool _discovery_restart;            // default true, restart discovery loop again on remote disconnect
     events::EventQueue &_queue;
+    char *long_string;
 };
 
 // forward declare single instance

TEST_APPS/icetea_plugins/nfc_test_parsers.py

@@ -110,17 +110,17 @@ def trace_parser(self, response):
                 if value is not False:
                     results['lastnfcerror'] = int(value)
                 # {{nfcmessage=([0-9a-f\s]*)}}
+                # message may be split over multiple lines, so we will start a search and wait until we get a }} pair
                 data = PluginBase.find_one(line, "{{nfcmessage=([0-9a-f\s]*).*")
                 if data is not False:
                     started_read_data = True
                 if started_read_data:  # read data until we see a }} pair
                     values = self.find_all_hex_data(line, "([0-9a-f\s]*)")
                     if values is not False:
                         if "{{nfcmessage" in line:
-                            value = values[0]
+                            value = values[0] # first (and possibly only data line)
                         else:
-                            value = values[0]
-                        #print ("==%s==" % value)
+                            value += values[0] # concatenate (2nd and possibly last data line)
                         partial_data += value
                     if PluginBase.find_one(line, ".*(}})") is not False: # search for end marker
                         started_read_data = False

TEST_APPS/testcases/nfc/nfc_clf_wrapper.py

@@ -25,9 +25,6 @@
 """
 
 
-# def command_is(string, command):
-#     return string.split(' ')[0] == command
-
 
 def debug_nfc_data(key, value):
     """
@@ -55,25 +52,27 @@ def __init__(self):
             logger.error("The NFC reader was not detected on any USB port!")
         self.clfResponse = None
 
-    def clf_response(self):
-        return self.clfResponse
-
-    def connect(self, target_options = ("106A","106B","212F")):
+    def connect(self):
         # note: only supporting type4
+        time.sleep(0.5)
         after5s = lambda: time.time() - started > 5
         started = time.time()
+
         tag = self.clf.connect( rdwr={'on-connect': lambda tag: False},
-            llcp={}, terminate = after5s)
-        self.clfResponse = tag
+            terminate = after5s)
         if tag: # None if timeout expires
             logging.info("NFCReader: connected " + str(tag))
+        else:
+            logging.info("NFCReader: warning, no tag detected ")
         return tag
 
     def mute(self):
         """turn off the reader radio"""
-        if self.clf.device:
+        if (self.clf.device is not None):
             logging.info("NFCReader: radio mute" + self.clf.device.product_name)
             self.clf.device.mute()
+        else:
+            logging.warning("NFCReader: reader not initialized!")
 
     def disconnect(self):
         logging.info("NFCReader: close frontend.")
@@ -97,5 +96,3 @@ def __getattr__(self, name):
 
     __nfc_wrapper = None
 
-    def clf_response(self):
-        return self.nfc.clf_response()

TEST_APPS/testcases/nfc/nfc_cli_helper.py

@@ -22,8 +22,8 @@
 import logging
 import icetea_lib.tools.asserts as asserts
 
-# Values > 4 k incur large time costs
-STRESS_BUFFLEN = 4096 # Default value for large buffer tests, this value can be read from the target with a command
+# Values > 1 k incur large time costs
+LARGE_BUFFLEN = 400 # Value for large buffer tests, a maximum value can be read from the target with a command
 
 class CliHelper():
     """