Skip to content

Commit e090ef2

Browse files
authored
Merge pull request #11453 from hugueskamba/hk-fix-coverity-issues
Fix Coverity issues
2 parents dc02e0b + e124009 commit e090ef2

File tree

6 files changed

+8
-5
lines changed

6 files changed

+8
-5
lines changed

drivers/source/FlashIAP.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ static inline bool is_aligned(uint32_t number, uint32_t alignment)
4646
}
4747
}
4848

49-
FlashIAP::FlashIAP()
49+
FlashIAP::FlashIAP() : _page_buf(nullptr)
5050
{
5151

5252
}

drivers/source/Ticker.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,12 @@
2424

2525
namespace mbed {
2626

27-
Ticker::Ticker() : TimerEvent(), _function(0), _lock_deepsleep(true)
27+
Ticker::Ticker() : TimerEvent(), _delay(0), _function(0), _lock_deepsleep(true)
2828
{
2929
}
3030

3131
// When low power ticker is in use, then do not disable deep sleep.
32-
Ticker::Ticker(const ticker_data_t *data) : TimerEvent(data), _function(0), _lock_deepsleep(!data->interface->runs_in_deep_sleep)
32+
Ticker::Ticker(const ticker_data_t *data) : TimerEvent(data), _delay(0), _function(0), _lock_deepsleep(!data->interface->runs_in_deep_sleep)
3333
{
3434
}
3535

platform/ATCmdParser.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ class ATCmdParser : private NonCopyable<ATCmdParser> {
9292
*/
9393
ATCmdParser(FileHandle *fh, const char *output_delimiter = "\r",
9494
int buffer_size = 256, int timeout = 8000, bool debug = false)
95-
: _fh(fh), _buffer_size(buffer_size), _oob_cb_count(0), _in_prev(0), _oobs(NULL)
95+
: _fh(fh), _buffer_size(buffer_size), _oob_cb_count(0), _in_prev(0), _aborted(false), _oobs(NULL)
9696
{
9797
_buffer = new char[buffer_size];
9898
set_timeout(timeout);

platform/source/ATCmdParser.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -397,7 +397,7 @@ void ATCmdParser::abort()
397397
bool ATCmdParser::process_oob()
398398
{
399399
int pre_count = _oob_cb_count;
400-
recv(NULL);
400+
static_cast<void>(recv(NULL));
401401
return _oob_cb_count != pre_count;
402402
}
403403

platform/source/SysTimer.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ SysTimer<US_IN_TICK, IRQ>::SysTimer() :
5757
_unacknowledged_ticks(0),
5858
_wake_time_set(false),
5959
_wake_time_passed(false),
60+
_wake_early(false),
6061
_ticking(false),
6162
_deep_sleep_locked(false)
6263
{
@@ -70,6 +71,7 @@ SysTimer<US_IN_TICK, IRQ>::SysTimer(const ticker_data_t *data) :
7071
_unacknowledged_ticks(0),
7172
_wake_time_set(false),
7273
_wake_time_passed(false),
74+
_wake_early(false),
7375
_ticking(false),
7476
_deep_sleep_locked(false)
7577
{

platform/source/mbed_retarget.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -826,6 +826,7 @@ int _lseek(FILEHANDLE fh, int offset, int whence)
826826
off_t off = lseek(fh, offset, whence);
827827
// Assuming INT_MAX = LONG_MAX, so we don't care about prototype difference
828828
if (off > INT_MAX) {
829+
// Be cautious in case off_t is 64-bit
829830
errno = EOVERFLOW;
830831
return -1;
831832
}

0 commit comments

Comments
 (0)