Skip to content

Commit eec4e13

Browse files
committed
nanostack interface: fix coding style
1 parent 29a1149 commit eec4e13

File tree

3 files changed

+55
-34
lines changed

3 files changed

+55
-34
lines changed

features/nanostack/nanostack-interface/Nanostack.cpp

Lines changed: 41 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -61,15 +61,18 @@ enum socket_mode_t {
6161
class NanostackSocket {
6262
public:
6363
static void socket_callback(void *cb);
64-
static void* operator new(std::size_t sz);
65-
static void operator delete(void* ptr);
64+
static void *operator new (std::size_t sz);
65+
static void operator delete (void *ptr);
6666

6767
NanostackSocket(int8_t protocol);
6868
~NanostackSocket(void);
6969
bool open(void);
7070
int accept(NanostackSocket *accepted_socket, ns_address_t *addr);
7171
void close(void);
72-
bool closed(void) {return SOCKET_MODE_CLOSED == mode;}
72+
bool closed(void)
73+
{
74+
return SOCKET_MODE_CLOSED == mode;
75+
}
7376
bool is_connecting(void);
7477
void set_connecting(ns_address_t *addr);
7578
bool is_connected(void);
@@ -101,21 +104,26 @@ class NanostackSocket {
101104
socket_mode_t mode;
102105
};
103106

104-
static NanostackSocket * socket_tbl[NS_INTERFACE_SOCKETS_MAX];
107+
static NanostackSocket *socket_tbl[NS_INTERFACE_SOCKETS_MAX];
105108

106109
nsapi_error_t map_mesh_error(mesh_error_t err)
107110
{
108111
switch (err) {
109-
case MESH_ERROR_NONE: return 0;
110-
case MESH_ERROR_MEMORY: return NSAPI_ERROR_NO_MEMORY;
111-
case MESH_ERROR_PARAM: return NSAPI_ERROR_UNSUPPORTED;
112-
case MESH_ERROR_STATE: return NSAPI_ERROR_DEVICE_ERROR;
113-
default: return NSAPI_ERROR_DEVICE_ERROR;
112+
case MESH_ERROR_NONE:
113+
return 0;
114+
case MESH_ERROR_MEMORY:
115+
return NSAPI_ERROR_NO_MEMORY;
116+
case MESH_ERROR_PARAM:
117+
return NSAPI_ERROR_UNSUPPORTED;
118+
case MESH_ERROR_STATE:
119+
return NSAPI_ERROR_DEVICE_ERROR;
120+
default:
121+
return NSAPI_ERROR_DEVICE_ERROR;
114122
}
115123
}
116124

117125
static void convert_mbed_addr_to_ns(ns_address_t *ns_addr,
118-
const SocketAddress *s_addr)
126+
const SocketAddress *s_addr)
119127
{
120128
ns_addr->type = ADDRESS_IPV6;
121129
ns_addr->identifier = s_addr->get_port();
@@ -142,10 +150,12 @@ static int8_t find_interface_by_address(const uint8_t target_addr[16])
142150
return -1;
143151
}
144152

145-
void* NanostackSocket::operator new(std::size_t sz) {
153+
void *NanostackSocket::operator new (std::size_t sz)
154+
{
146155
return MALLOC(sz);
147156
}
148-
void NanostackSocket::operator delete(void* ptr) {
157+
void NanostackSocket::operator delete (void *ptr)
158+
{
149159
FREE(ptr);
150160
}
151161

@@ -296,15 +306,16 @@ void NanostackSocket::signal_event()
296306
}
297307
}
298308

299-
void NanostackSocket::socket_callback(void *cb) {
309+
void NanostackSocket::socket_callback(void *cb)
310+
{
300311
nanostack_assert_locked();
301312

302313
socket_callback_t *sock_cb = (socket_callback_t *) cb;
303314
NanostackSocket *socket = socket_tbl[sock_cb->socket_id];
304315
MBED_ASSERT(socket != NULL);
305316

306317
tr_debug("socket_callback() sock=%d, event=%d, interface=%d, data len=%d",
307-
sock_cb->socket_id, sock_cb->event_type, sock_cb->interface_id, sock_cb->d_len);
318+
sock_cb->socket_id, sock_cb->event_type, sock_cb->interface_id, sock_cb->d_len);
308319

309320
switch (sock_cb->event_type) {
310321
case SOCKET_DATA:
@@ -506,7 +517,7 @@ Nanostack::call_in_callback_cb_t Nanostack::get_call_in_callback()
506517
return cb;
507518
}
508519

509-
const char * Nanostack::get_ip_address()
520+
const char *Nanostack::get_ip_address()
510521
{
511522
NanostackLockGuard lock;
512523

@@ -539,11 +550,11 @@ nsapi_error_t Nanostack::socket_open(void **handle, nsapi_protocol_t protocol)
539550
MBED_ASSERT(false);
540551
return NSAPI_ERROR_UNSUPPORTED;
541552
}
542-
*handle = (void*)NULL;
553+
*handle = (void *)NULL;
543554

544555
NanostackLockGuard lock;
545556

546-
NanostackSocket * socket = new NanostackSocket(ns_proto);
557+
NanostackSocket *socket = new NanostackSocket(ns_proto);
547558
if (socket == NULL) {
548559
tr_debug("socket_open() ret=%i", NSAPI_ERROR_NO_MEMORY);
549560
return NSAPI_ERROR_NO_MEMORY;
@@ -553,7 +564,7 @@ nsapi_error_t Nanostack::socket_open(void **handle, nsapi_protocol_t protocol)
553564
tr_debug("socket_open() ret=%i", NSAPI_ERROR_NO_MEMORY);
554565
return NSAPI_ERROR_NO_MEMORY;
555566
}
556-
*handle = (void*)socket;
567+
*handle = (void *)socket;
557568

558569
tr_debug("socket_open() socket=%p, sock_id=%d, ret=0", socket, socket->socket_id);
559570

@@ -564,7 +575,7 @@ nsapi_error_t Nanostack::socket_close(void *handle)
564575
{
565576
NanostackLockGuard lock;
566577
// Validate parameters
567-
NanostackSocket * socket = static_cast<NanostackSocket *>(handle);
578+
NanostackSocket *socket = static_cast<NanostackSocket *>(handle);
568579
if (NULL == handle) {
569580
MBED_ASSERT(false);
570581
return NSAPI_ERROR_NO_SOCKET;
@@ -580,7 +591,7 @@ nsapi_error_t Nanostack::socket_close(void *handle)
580591
nsapi_size_or_error_t Nanostack::do_sendto(void *handle, const ns_address_t *address, const void *data, nsapi_size_t size)
581592
{
582593
// Validate parameters
583-
NanostackSocket * socket = static_cast<NanostackSocket *>(handle);
594+
NanostackSocket *socket = static_cast<NanostackSocket *>(handle);
584595
if (handle == NULL) {
585596
MBED_ASSERT(false);
586597
return NSAPI_ERROR_NO_SOCKET;
@@ -604,7 +615,7 @@ nsapi_size_or_error_t Nanostack::do_sendto(void *handle, const ns_address_t *add
604615
int retcode;
605616
#if 0
606617
retcode = ::socket_sendto(socket->socket_id, address,
607-
data, size);
618+
data, size);
608619
#else
609620
// Use sendmsg purely to get the new return style
610621
// of returning data written rather than 0 on success,
@@ -616,7 +627,7 @@ nsapi_size_or_error_t Nanostack::do_sendto(void *handle, const ns_address_t *add
616627
iov.iov_base = const_cast<void *>(data);
617628
iov.iov_len = size;
618629
msg.msg_name = const_cast<ns_address_t *>(address);
619-
msg.msg_namelen = address ? sizeof *address : 0;
630+
msg.msg_namelen = address ? sizeof * address : 0;
620631
msg.msg_iov = &iov;
621632
msg.msg_iovlen = 1;
622633
msg.msg_control = NULL;
@@ -771,7 +782,7 @@ nsapi_error_t Nanostack::setsockopt(void *handle, int level, int optname, const
771782

772783
/* Check address types are IPv6, or unspecified for interface */
773784
if (imr->imr_multiaddr.version != NSAPI_IPv6 ||
774-
(imr->imr_interface.version != NSAPI_UNSPEC && imr->imr_interface.version != NSAPI_IPv6)) {
785+
(imr->imr_interface.version != NSAPI_UNSPEC && imr->imr_interface.version != NSAPI_IPv6)) {
775786
return NSAPI_ERROR_PARAMETER;
776787
}
777788

@@ -841,7 +852,7 @@ nsapi_error_t Nanostack::socket_listen(void *handle, int backlog)
841852

842853
NanostackLockGuard lock;
843854

844-
if(::socket_listen(socket->socket_id, backlog) < 0) {
855+
if (::socket_listen(socket->socket_id, backlog) < 0) {
845856
ret = NSAPI_ERROR_PARAMETER;
846857
} else {
847858
socket->set_listening();
@@ -904,7 +915,7 @@ nsapi_error_t Nanostack::socket_connect(void *handle, const SocketAddress &addr)
904915

905916
nsapi_error_t Nanostack::socket_accept(void *server, void **handle, SocketAddress *address)
906917
{
907-
NanostackSocket * socket = static_cast<NanostackSocket *>(server);
918+
NanostackSocket *socket = static_cast<NanostackSocket *>(server);
908919
NanostackSocket *accepted_sock = NULL;
909920
nsapi_error_t ret;
910921

@@ -965,7 +976,7 @@ nsapi_size_or_error_t Nanostack::socket_recv(void *handle, void *data, nsapi_siz
965976
void Nanostack::socket_attach(void *handle, void (*callback)(void *), void *id)
966977
{
967978
// Validate parameters
968-
NanostackSocket * socket = static_cast<NanostackSocket *>(handle);
979+
NanostackSocket *socket = static_cast<NanostackSocket *>(handle);
969980
if (handle == NULL) {
970981
MBED_ASSERT(false);
971982
return;
@@ -979,7 +990,8 @@ void Nanostack::socket_attach(void *handle, void (*callback)(void *), void *id)
979990
tr_debug("socket_attach(socket=%p) sock_id=%d", socket, socket->socket_id);
980991
}
981992

982-
Nanostack &Nanostack::get_instance() {
993+
Nanostack &Nanostack::get_instance()
994+
{
983995
static Nanostack nanostack;
984996
return nanostack;
985997
}
@@ -989,7 +1001,8 @@ Nanostack &Nanostack::get_instance() {
9891001
#define NANOSTACK 0x99119911
9901002
#if MBED_CONF_NSAPI_DEFAULT_STACK == NANOSTACK
9911003
#undef NANOSTACK
992-
OnboardNetworkStack &OnboardNetworkStack::get_default_instance() {
1004+
OnboardNetworkStack &OnboardNetworkStack::get_default_instance()
1005+
{
9931006
return Nanostack::get_instance();
9941007
}
9951008
#endif

features/nanostack/nanostack-interface/NanostackLockGuard.h

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,17 +27,19 @@
2727

2828
class NanostackLockGuard {
2929
public:
30-
NanostackLockGuard() {
30+
NanostackLockGuard()
31+
{
3132
eventOS_scheduler_mutex_wait();
3233
}
3334

34-
~NanostackLockGuard() {
35+
~NanostackLockGuard()
36+
{
3537
eventOS_scheduler_mutex_release();
3638
}
3739

3840
private:
39-
NanostackLockGuard(const NanostackLockGuard&);
40-
NanostackLockGuard& operator=(const NanostackLockGuard&);
41+
NanostackLockGuard(const NanostackLockGuard &);
42+
NanostackLockGuard &operator=(const NanostackLockGuard &);
4143
};
4244

4345
#endif /* NANOSTACK_LOCK_GUARD_H_ */

features/nanostack/nanostack-interface/NanostackRfPhy.h

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,18 @@ class NanostackRfPhy : public NanostackPhy {
4848
* @return Device driver ID or a negative error
4949
* code on failure
5050
*/
51-
virtual int8_t phy_register() { return rf_register();}
51+
virtual int8_t phy_register()
52+
{
53+
return rf_register();
54+
}
5255

5356
/** Unregister this physical interface
5457
*
5558
*/
56-
virtual void unregister() { rf_unregister(); }
59+
virtual void unregister()
60+
{
61+
rf_unregister();
62+
}
5763
};
5864

5965
#endif /* NANOSTACK_RF_PHY_H_ */

0 commit comments

Comments
 (0)