Skip to content

Commit fffbca6

Browse files
author
Antti Yli-Tokola
committed
Update mbed-coap to version 4.7.3
EMPTY response should not be stored to blockwise list. An Empty message only contains the 4-byte header so it does not require any blockwise operations. This will fix unneseccary message sending timeouts which leads mbed cloud client to do unnecessary reconnections which increases the network traffic.
1 parent e69aa15 commit fffbca6

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

features/frameworks/mbed-coap/CHANGELOG.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,14 @@
11
# Change Log
22

3+
## [v4.7.3](https://github.com/ARMmbed/mbed-coap/releases/tag/v4.7.3)
4+
5+
- Do not store EMPTY response to blockwise list
6+
An Empty message only contains the 4-byte header so it does not require any blockwise operations.
7+
This will fix unneseccary message sending timeouts which leads mbed cloud client to do unnecessary
8+
reconnections which increases the network traffic.
9+
10+
-[Full Changelog](https://github.com/ARMmbed/mbed-coap/compare/v4.7.2...v4.7.3)
11+
312
## [v4.7.2](https://github.com/ARMmbed/mbed-coap/releases/tag/v4.7.2)
413

514
- Fix handling of duplicate blockwise ACK's

features/frameworks/mbed-coap/module.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "mbed-coap",
3-
"version": "4.7.2",
3+
"version": "4.7.3",
44
"description": "COAP library",
55
"keywords": [
66
"coap",

features/frameworks/mbed-coap/source/sn_coap_protocol.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -564,7 +564,8 @@ int16_t sn_coap_protocol_build(struct coap_s *handle, sn_nsdl_addr_s *dst_addr_p
564564
stored_blockwise_msg_ptr->param = param;
565565
stored_blockwise_msg_ptr->msg_id = stored_blockwise_msg_ptr->coap_msg_ptr->msg_id;
566566
ns_list_add_to_end(&handle->linked_list_blockwise_sent_msgs, stored_blockwise_msg_ptr);
567-
} else if (src_coap_msg_ptr->msg_code <= COAP_MSG_CODE_REQUEST_DELETE) {
567+
} else if (src_coap_msg_ptr->msg_code <= COAP_MSG_CODE_REQUEST_DELETE &&
568+
src_coap_msg_ptr->msg_code != COAP_MSG_CODE_EMPTY) {
568569
/* Add message to linked list - response can be in blocks and we need header to build response.. */
569570
coap_blockwise_msg_s *stored_blockwise_msg_ptr;
570571

0 commit comments

Comments
 (0)