feat(unity-bootstrap-theme): changed heigth to min-heigth on div.uds-hero-lg

juanmitriatti · juanmitriatti · commit 0e0c04b55875 · 2025-02-17T15:27:39.000-03:00
UDS-1765
diff --git a/packages/unity-bootstrap-theme/src/scss/extends/_heroes.scss b/packages/unity-bootstrap-theme/src/scss/extends/_heroes.scss
@@ -282,7 +282,7 @@ div.uds-hero-md {
 }
 
 div.uds-hero-lg {
-  height: $uds-size-spacing-64;
+  min-height: $uds-size-spacing-64;
 
   .content {
     display: none;
@@ -426,7 +426,7 @@ div.uds-hero-lg {
   }
 
   div.uds-hero-lg {
-    height: 42.75rem;
+    min-height: 42.75rem;
     // TODO; remove this, it's a fallback for buttons without has-btn-row
     grid-template-rows: 1fr repeat(4, auto) $uds-size-spacing-6;
 
@@ -498,7 +498,7 @@ div.uds-hero-lg {
   }
 
   div.uds-hero-lg {
-    height: 42.75rem;
+    min-height: 42.75rem;
 
     &.uds-video-hero {
       position: relative;

Original file line number	Diff line number	Diff line change
`@@ -282,7 +282,7 @@ div.uds-hero-md {`
`282`	`282`	`}`
`283`	`283`
`284`	`284`	`div.uds-hero-lg {`
`285`		`- height: $uds-size-spacing-64;`
	`285`	`+ min-height: $uds-size-spacing-64;`
`286`	`286`
`287`	`287`	`.content {`
`288`	`288`	`display: none;`
`@@ -426,7 +426,7 @@ div.uds-hero-lg {`
`426`	`426`	`}`
`427`	`427`
`428`	`428`	`div.uds-hero-lg {`
`429`		`- height: 42.75rem;`
	`429`	`+ min-height: 42.75rem;`
`430`	`430`	`// TODO; remove this, it's a fallback for buttons without has-btn-row`
`431`	`431`	`grid-template-rows: 1fr repeat(4, auto) $uds-size-spacing-6;`
`432`	`432`
`@@ -498,7 +498,7 @@ div.uds-hero-lg {`
`498`	`498`	`}`
`499`	`499`
`500`	`500`	`div.uds-hero-lg {`
`501`		`- height: 42.75rem;`
	`501`	`+ min-height: 42.75rem;`
`502`	`502`
`503`	`503`	`&.uds-video-hero {`
`504`	`504`	`position: relative;`