Skip to content

Commit 281dbee

Browse files
Merge pull request #1501 from ASU/UDS-1979
UDS-1979: fix(unity-bootstrap-theme): added hover white to footer's social icon
2 parents 4e0201c + 201a77a commit 281dbee

File tree

3 files changed

+22
-2
lines changed

3 files changed

+22
-2
lines changed

packages/component-header-footer/src/footer/components/Social/index.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ const Social = ({ social: { logoUrl, unitLogo, mediaLinks } }) => {
6969
<FontAwesomeIcon
7070
title="Facebook Social Media Icon"
7171
icon={faFacebookSquare}
72+
className="social-icon"
7273
/>
7374
</a>
7475
)}
@@ -87,6 +88,7 @@ const Social = ({ social: { logoUrl, unitLogo, mediaLinks } }) => {
8788
<FontAwesomeIcon
8889
title="Twitter Social Media Icon"
8990
icon={faSquareXTwitter}
91+
className="social-icon"
9092
/>
9193
</a>
9294
)}
@@ -105,6 +107,7 @@ const Social = ({ social: { logoUrl, unitLogo, mediaLinks } }) => {
105107
<FontAwesomeIcon
106108
title="Instagram Social Media Icon"
107109
icon={faInstagramSquare}
110+
className="social-icon"
108111
/>
109112
</a>
110113
)}
@@ -123,6 +126,7 @@ const Social = ({ social: { logoUrl, unitLogo, mediaLinks } }) => {
123126
<FontAwesomeIcon
124127
title="YouTube Social Media Icon"
125128
icon={faYoutubeSquare}
129+
className="social-icon"
126130
/>
127131
</a>
128132
)}
@@ -141,6 +145,7 @@ const Social = ({ social: { logoUrl, unitLogo, mediaLinks } }) => {
141145
<FontAwesomeIcon
142146
title="LinkedIn Social Media Icon"
143147
icon={faLinkedin}
148+
className="social-icon"
144149
/>
145150
</a>
146151
)}

packages/component-header-footer/src/footer/index.styles.js

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,11 @@ const StyledFooter = styled.footer`
2828
font-family: Arial, Helvetica, "Nimbus Sans L", "Liberation Sans", FreeSans,
2929
sans-serif;
3030
line-height: 1.5rem;
31+
32+
a:focus, button:focus {
33+
outline: none;
34+
box-shadow: 0 0 0 2px var(--color-base-white), 0 0 0 4px var(--color-base-grey-7) !important;
35+
}
3136
}
3237
3338
.btn,
@@ -132,6 +137,12 @@ const StyledFooter = styled.footer`
132137
.nav {
133138
padding-bottom: 1.5rem;
134139
140+
.nav-link .social-icon {
141+
&:hover {
142+
color: var(--color-base-white);
143+
}
144+
}
145+
135146
@media (min-width: 768px) {
136147
padding: 2.5rem 0;
137148
justify-content: flex-end;
@@ -271,8 +282,7 @@ const StyledFooter = styled.footer`
271282
text-decoration: none;
272283
display: block;
273284
274-
&:hover,
275-
&:focus {
285+
&:hover {
276286
color: var(--color-base-gold);
277287
text-decoration: underline;
278288
}
@@ -282,6 +292,7 @@ const StyledFooter = styled.footer`
282292
padding: 0;
283293
display: block;
284294
min-height: fit-content;
295+
overflow: visible;
285296
}
286297
}
287298
}

packages/unity-bootstrap-theme/src/scss/extends/_globalfooter.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,10 @@ footer {
141141
color: $uds-color-base-gray-4;
142142
line-height: 1;
143143
padding-top: 7px; // Magic number. Reducing the padding by 1px to make the height = 48px.
144+
145+
:hover {
146+
color: $uds-color-base-white;
147+
}
144148
}
145149
}
146150
}

0 commit comments

Comments
 (0)