chore: fix various lint error

Author: scott-williams-az

packages/shared/utils/scroll-helper.js

@@ -1,16 +1,18 @@
 // @ts-check
 export function adjustShrinkingElementIfAboveViewport(element) {
-  if(element && typeof element.getBoundingClientRect === "function") {
-
-    const {bottom:inViewportHeight, top, } = element.getBoundingClientRect();
-    const {offsetTop } = element;
-    if(top < 0 && inViewportHeight > 0) {
+  if (element && typeof element.getBoundingClientRect === "function") {
+    const { bottom: inViewportHeight, top } = element.getBoundingClientRect();
+    const { offsetTop } = element;
+    if (top < 0 && inViewportHeight > 0) {
       const savedStyle = element.style;
       element.style = `${savedStyle};transition: height 0s !important; overflow:hidden; height:${inViewportHeight}px!important;max-height:${inViewportHeight}px!important`;
-      window.scrollTo({behavior:"instant", top: offsetTop });
-      setTimeout(()=>{
+      window.scrollTo({ behavior: "instant", top: offsetTop });
+      setTimeout(() => {
         element.style = savedStyle;
-        window.scrollTo({behavior:"smooth", top: element.offsetTop - inViewportHeight/2 });
+        window.scrollTo({
+          behavior: "smooth",
+          top: element.offsetTop - inViewportHeight / 2,
+        });
       }, 50);
     }
   }

packages/unity-bootstrap-theme/src/js/collapse.js

@@ -1,19 +1,25 @@
-import { adjustShrinkingElementIfAboveViewport } from "@shared";
+import { adjustShrinkingElementIfAboveViewport } from "@asu/shared";
 
 import { EventHandler } from "./bootstrap-helper";
 
 function initCollapse() {
-  function accordionClick({target}) {
+  function accordionClick({ target }) {
     const targetHref = target.getAttribute("href");
-    if (target.getAttribute("data-bs-toggle") !== "collapse" || !targetHref || !targetHref.includes("#")) {
+    if (
+      target.getAttribute("data-bs-toggle") !== "collapse" ||
+      !targetHref ||
+      !targetHref.includes("#")
+    ) {
       return; // Exit the function - not a collapse link
     }
 
     /**
      * Find the first accordion that is currently collapsing or expanding
      * Function will determine if scroll adjustment is needed
      */
-    adjustShrinkingElementIfAboveViewport(document.querySelector(".collapsing"));
+    adjustShrinkingElementIfAboveViewport(
+      document.querySelector(".collapsing")
+    );
   }
   EventHandler.on(document, "click.uds.collapse", accordionClick);
 }

packages/unity-bootstrap-theme/stories/atoms/accordion/accordion.examples.stories.js

@@ -7,11 +7,15 @@ export default {
   parameters: { controls: { disable: true } },
 };
 
-export const Default = () =>
-<Container>
-  <Column>
-    <a target="_parent" href="../../@asu/unity-react-core/index.html?path=/story/components-accordion--default">Accordion has moved to @asu/unity-react-core</a>
-
-  </Column>
-</Container>;
-
+export const Default = () => (
+  <Container>
+    <Column>
+      <a
+        target="_parent"
+        href="../../@asu/unity-react-core/index.html?path=/story/components-accordion--default"
+      >
+        Accordion has moved to @asu/unity-react-core
+      </a>
+    </Column>
+  </Container>
+);

packages/unity-bootstrap-theme/vite.config.js

@@ -79,14 +79,6 @@ const c = {
   server: {
     port: 9000,
   },
-  resolve: {
-    alias: [
-      {
-        find: "@asu/shared",
-        replacement: resolve(__dirname, "../shared"),
-      },
-    ],
-  },
 };
 
 export default defineConfig(c);

packages/unity-react-core/src/components/Accordion/Accordion.jsx

@@ -2,7 +2,7 @@
 import PropTypes from "prop-types";
 import React, { useId, useRef, useState } from "react";
 
-import { adjustShrinkingElementIfAboveViewport } from "../../../../../shared";
+import { adjustShrinkingElementIfAboveViewport } from "@asu/shared";
 import { accordionCardPropTypes } from "../../core/models/shared-prop-types";
 import { AccordionCard } from "./AccordionCard/AccordionCard";
 
@@ -52,7 +52,6 @@ const Accordion = ({ cards, openedCard }) => {
               ref={element => {
                 cardsRef.current[key] = element;
               }}
-              // eslint-disable-next-line react/no-array-index-key
               key={key + 1}
               id={key + 1}
               parentId={parentId}

packages/unity-react-core/src/components/Accordion/Accordion.stories.jsx

@@ -1,8 +1,7 @@
-/* eslint-disable no-plusplus */
 /* eslint react/jsx-props-no-spreading: "off" */
 import React from "react";
 
-import { getLoremSentences } from "../../../../../shared/constants/strings";
+import { getLoremSentences } from "@asu/shared";
 import { Accordion } from "./Accordion";
 
 export default {

packages/unity-react-core/src/components/Accordion/AccordionCard/AccordionCard.jsx

@@ -92,7 +92,6 @@ export const AccordionCard = forwardRef(
           >
             <div
               className="accordion-body"
-              // eslint-disable-next-line react/no-danger
               dangerouslySetInnerHTML={sanitizeDangerousMarkup(
                 item.content.body
               )}