Skip to content

Commit d6e057b

Browse files
Merge branch 'dev' into component-consolidation
2 parents fa6b6e0 + cd62619 commit d6e057b

File tree

64 files changed

+2027
-204
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

64 files changed

+2027
-204
lines changed

.github/pull_request_template.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
<!-- PREFLIGHT CHECK - to be deleted before submitting PR -->
2+
<!-- - CHECK: Do tests need to be added or updated? -->
3+
<!-- - CHECK: Are data layer additions or updates needed? -->
4+
15
### Description
26

37
<!-- Description of problem -->
@@ -10,4 +14,3 @@
1014
- [Unity reference site](https://asu.github.io/asu-unity-stack/)
1115
- [Unity Design Kit](https://shared-assets.adobe.com/link/fb14b288-bf63-47e0-5d30-384de5560455)
1216

13-

README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
- [How to use the private package registry:](#how-to-use-the-private-package-registry)
1010
- [TROUBLESHOOTING ERRORS](#troubleshooting-errors)
1111
- [Packages in this repository](#packages-in-this-repository)
12+
- [Cookie Consent](#cookie-consent)
1213
- [Deprecated packages](#deprecated-packages)
1314
- [Package Multi Output Targets](#package-multi-output-targets)
1415
- [Advanced Details for Unity Developers and Contributors](#advanced-details-for-unity-developers-and-contributors)
@@ -114,6 +115,10 @@ This repository contains multiple packages which are managed and published using
114115
11. [components-core](./packages/components-core/README.md)
115116
12. [unity-react-core](./packages/unity-react-core/README.md) *Now includes the component carousel package*
116117

118+
## Cookie Consent
119+
120+
The CSS for the cookie consent banner can be found in [unity-bootstrap-theme](./packages/unity-bootstrap-theme/src/css/cookie-consent.css). The JavaScript for the cookie consent banner can be found in [unity-bootstrap-theme as well in the JS location](./packages/unity-bootstrap-theme/src/js/cookie-consent.js). The Javascript can be placed in a script tag or included in a bundle. The CSS can be included in a bundle or included in a style tag.
121+
117122
## Deprecated packages
118123

119124
Previously deprecated packages were located inside the `packages-disabled` folder. We are no longer keeping these deprecated packages active in the repository. Deprecated packages can still be found in git history.

packages/app-rfi/CHANGELOG.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,15 @@
1+
# [@asu/app-rfi-v2.4.2](https://github.com/asu/asu-unity-stack/compare/@asu/app-rfi-v2.4.1...@asu/app-rfi-v2.4.2) (2025-01-30)
2+
3+
4+
### Bug Fixes
5+
6+
* **app-rfi:** prevent sending pii to data layer ([9bef080](https://github.com/asu/asu-unity-stack/commit/9bef080877a1d855c3949e409cd87f056e49ff52))
7+
8+
9+
### Reverts
10+
11+
* Revert "fix(app-rfi): ga track default disabled for pii" ([ca8207e](https://github.com/asu/asu-unity-stack/commit/ca8207e6df7d3473f95173c18b7766148dc1f32a))
12+
113
# [@asu/app-rfi-v2.4.1](https://github.com/asu/asu-unity-stack/compare/@asu/app-rfi-v2.4.0...@asu/app-rfi-v2.4.1) (2024-10-04)
214

315

packages/app-rfi/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@asu/app-rfi",
3-
"version": "2.4.1",
3+
"version": "2.4.2",
44
"description": "ASU Request For Information (RFI) form",
55
"main": "./dist/appRfi.cjs.js",
66
"browser": "./dist/appRfi.umd.js",

packages/app-rfi/src/components/steps/questions/Country.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import { gaEventPropTypes, trackGAEvent } from "../../../../../../shared";
44
import { fetchCountries } from "../../../core/utils/fetchCountries";
55
import { useRfiContext } from "../../../core/utils/rfiContext";
66
import { RfiSelect } from "../../controls";
7+
import { PII_VALUE } from "../../../core/utils/constants";
78

89
// Options
910
function getCountryOptions(resultsArrayOfObjects) {
@@ -56,7 +57,7 @@ export const Country = ({ gaData }) => {
5657
...gaData,
5758
event: "select",
5859
type: label,
59-
text: e.target.selectedOptions[0].innerText,
60+
text: PII_VALUE,
6061
})
6162
}
6263
/>

packages/app-rfi/src/components/steps/questions/EmailAddress.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import React from "react";
22

33
import { gaEventPropTypes, trackGAEvent } from "../../../../../../shared";
44
import { RfiEmailInput } from "../../controls";
5+
import { PII_VALUE } from "../../../core/utils/constants";
56

67
/**
78
* @param {{ gaData: import("../../../../../../shared/services/googleAnalytics").GAEventObject}} props
@@ -21,7 +22,7 @@ export const EmailAddress = ({ gaData }) => {
2122
trackGAEvent({
2223
...gaData,
2324
type: label,
24-
text: e.target.value,
25+
text: PII_VALUE,
2526
})
2627
}
2728
/>

packages/app-rfi/src/components/steps/questions/FirstName.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import React from "react";
22

33
import { gaEventPropTypes, trackGAEvent } from "../../../../../../shared";
44
import { RfiTextInput } from "../../controls";
5+
import { PII_VALUE } from "../../../core/utils/constants";
56

67
/**
78
* @param {{ gaData: import("../../../../../../shared/services/googleAnalytics").GAEventObject}} props
@@ -21,7 +22,7 @@ export const FirstName = ({ gaData }) => {
2122
trackGAEvent({
2223
...gaData,
2324
type: label,
24-
text: e.target.value,
25+
text: PII_VALUE,
2526
})
2627
}
2728
/>

packages/app-rfi/src/components/steps/questions/LastName.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import React from "react";
22

33
import { gaEventPropTypes, trackGAEvent } from "../../../../../../shared";
44
import { RfiTextInput } from "../../controls";
5+
import { PII_VALUE } from "../../../core/utils/constants";
56

67
/**
78
* @param {{ gaData: import("../../../../../../shared/services/googleAnalytics").GAEventObject}} props
@@ -21,7 +22,7 @@ export const LastName = ({ gaData }) => {
2122
trackGAEvent({
2223
...gaData,
2324
type: label,
24-
text: e.target.value,
25+
text: PII_VALUE,
2526
})
2627
}
2728
/>

packages/app-rfi/src/components/steps/questions/Phone.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import React from "react";
22

33
import { gaEventPropTypes, trackGAEvent } from "../../../../../../shared";
44
import { RfiPhone } from "../../controls";
5+
import { PII_VALUE } from "../../../core/utils/constants";
56

67
/**
78
* @param {{ gaData: import("../../../../../../shared/services/googleAnalytics").GAEventObject}} props
@@ -21,7 +22,7 @@ export const Phone = ({ gaData }) => {
2122
trackGAEvent({
2223
...gaData,
2324
type: label,
24-
text: e.target.value,
25+
text: PII_VALUE,
2526
})
2627
}
2728
/>

packages/app-rfi/src/components/steps/questions/ZipCode.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import React, { useEffect } from "react";
22

33
import { gaEventPropTypes, trackGAEvent } from "../../../../../../shared";
4-
import { KEY } from "../../../core/utils/constants";
4+
import { KEY, PII_VALUE } from "../../../core/utils/constants";
55
import { useRfiContext } from "../../../core/utils/rfiContext";
66
import { RfiTextInput } from "../../controls";
77

@@ -42,7 +42,7 @@ export const ZipCode = ({ gaData }) => {
4242
trackGAEvent({
4343
...gaData,
4444
type: label,
45-
text: e.target.value,
45+
text: PII_VALUE,
4646
})
4747
}
4848
/>

0 commit comments

Comments
 (0)