[PR] Fixes #36691 - use 'connectefi scsi' by default

(cherry picked from commit f216b6f)

Author: sbernhard

app/views/unattended/provisioning_templates/snippet/pxegrub2_chainload.erb

@@ -32,9 +32,10 @@ insmod fat
 insmod chain
 
 echo "VMWare hosts with QuickBoot feature enabled may not find the local ESP"
-echo "partition due to not initializing all the EFI devices. To workaround, upgrade"
-echo "to the latest grub2 (*) and uncomment "connectefi scsi" statement in the"
-echo "grub2_chainload template."
+echo "partition due to not initializing all the EFI devices. To address this,"
+echo "use an up-to-date grub2 (*) version and include the "connectefi scsi" statement"
+echo "as provided below. If you're using an older grub2 version or"
+echo "the "connectefi scsi" option isn't recognized by your grub2, you can omit it."
 echo
 echo "Virtual or physical hosts using Software RAID for the ESP partition may try"
 echo "booting on the Software RAID, which will fail. To workaround, upgrade to the"
@@ -43,7 +44,7 @@ echo "the grub2_chainload template."
 echo
 echo "(*) grub2-efi-x64-2.02-122.el8 (upstream doesn't have the patches yet)"
 echo
-#connectefi scsi
+connectefi scsi
 
 menuentry 'Chainload Grub2 EFI from ESP' --id local_chain_hd0 {
   echo "Chainloading Grub2 EFI from ESP, enabled devices for booting:"

test/unit/foreman/renderer/snapshots/ProvisioningTemplate/PXEGrub2/PXEGrub2_default_local_boot.host4dhcp.snap.txt

@@ -7,9 +7,10 @@ insmod fat
 insmod chain
 
 echo "VMWare hosts with QuickBoot feature enabled may not find the local ESP"
-echo "partition due to not initializing all the EFI devices. To workaround, upgrade"
-echo "to the latest grub2 (*) and uncomment "connectefi scsi" statement in the"
-echo "grub2_chainload template."
+echo "partition due to not initializing all the EFI devices. To address this,"
+echo "use an up-to-date grub2 (*) version and include the "connectefi scsi" statement"
+echo "as provided below. If you're using an older grub2 version or"
+echo "the "connectefi scsi" option isn't recognized by your grub2, you can omit it."
 echo
 echo "Virtual or physical hosts using Software RAID for the ESP partition may try"
 echo "booting on the Software RAID, which will fail. To workaround, upgrade to the"
@@ -18,7 +19,7 @@ echo "the grub2_chainload template."
 echo
 echo "(*) grub2-efi-x64-2.02-122.el8 (upstream doesn't have the patches yet)"
 echo
-#connectefi scsi
+connectefi scsi
 
 menuentry 'Chainload Grub2 EFI from ESP' --id local_chain_hd0 {
   echo "Chainloading Grub2 EFI from ESP, enabled devices for booting:"

test/unit/foreman/renderer/snapshots/ProvisioningTemplate/PXEGrub2/PXEGrub2_global_default.host4dhcp.snap.txt

@@ -23,9 +23,10 @@ insmod fat
 insmod chain
 
 echo "VMWare hosts with QuickBoot feature enabled may not find the local ESP"
-echo "partition due to not initializing all the EFI devices. To workaround, upgrade"
-echo "to the latest grub2 (*) and uncomment "connectefi scsi" statement in the"
-echo "grub2_chainload template."
+echo "partition due to not initializing all the EFI devices. To address this,"
+echo "use an up-to-date grub2 (*) version and include the "connectefi scsi" statement"
+echo "as provided below. If you're using an older grub2 version or"
+echo "the "connectefi scsi" option isn't recognized by your grub2, you can omit it."
 echo
 echo "Virtual or physical hosts using Software RAID for the ESP partition may try"
 echo "booting on the Software RAID, which will fail. To workaround, upgrade to the"
@@ -34,7 +35,7 @@ echo "the grub2_chainload template."
 echo
 echo "(*) grub2-efi-x64-2.02-122.el8 (upstream doesn't have the patches yet)"
 echo
-#connectefi scsi
+connectefi scsi
 
 menuentry 'Chainload Grub2 EFI from ESP' --id local_chain_hd0 {
   echo "Chainloading Grub2 EFI from ESP, enabled devices for booting:"

test/unit/foreman/renderer/snapshots/ProvisioningTemplate/snippet/pxegrub2_chainload.host4dhcp.snap.txt

@@ -3,9 +3,10 @@ insmod fat
 insmod chain
 
 echo "VMWare hosts with QuickBoot feature enabled may not find the local ESP"
-echo "partition due to not initializing all the EFI devices. To workaround, upgrade"
-echo "to the latest grub2 (*) and uncomment "connectefi scsi" statement in the"
-echo "grub2_chainload template."
+echo "partition due to not initializing all the EFI devices. To address this,"
+echo "use an up-to-date grub2 (*) version and include the "connectefi scsi" statement"
+echo "as provided below. If you're using an older grub2 version or"
+echo "the "connectefi scsi" option isn't recognized by your grub2, you can omit it."
 echo
 echo "Virtual or physical hosts using Software RAID for the ESP partition may try"
 echo "booting on the Software RAID, which will fail. To workaround, upgrade to the"
@@ -14,7 +15,7 @@ echo "the grub2_chainload template."
 echo
 echo "(*) grub2-efi-x64-2.02-122.el8 (upstream doesn't have the patches yet)"
 echo
-#connectefi scsi
+connectefi scsi
 
 menuentry 'Chainload Grub2 EFI from ESP' --id local_chain_hd0 {
   echo "Chainloading Grub2 EFI from ESP, enabled devices for booting:"