Better development process?

[space-nuko]

I think alot of people can agree that auto's latest Gradio 3.23 merge was too hasty, it broke a lot of things

• Send to img2img ([Bug]: "Send To xxx" action fail with AttributeError: 'NoneType' object has no attribute 'startswith' when using batch mode #8916)
• Image aspect ratio preview in img2img ([Bug]: the outline of the image ratio no longer appears on the image when moving the height and width sliders #8910)
• Notifications ([Bug]: Notifications broken with 3.23 merge #8933)
• Padding in extensions dropdowns
• Infinite recursion caused by Gradio DOM breaking change (fix overriding getElementById on document #8921)

Infact I had fixed all those issues in my PR #8752 but auto decided to merge his instead, I understand mine had too many things to merge but I could have reverted those commits to cut down in the amount of changes if he'd asked

Not to mention, with auto showing up once a week it's hard to tell when open PRs will get feedback when he leaves again, I completely understand if the man is busy with real life but there are a lot of other contributors that post helpful feedback on PRs, why not give them the ability to manage PR lifecycles and merging themselves?

Maybe these suggestions would help not break everyones workflow every time Gradio is updated

• More than one contributor besides auto with merge permissions
• develop branch separate from main branch where people can test out new changes before they're merged
• Versioning system that ocassionaly merges in develop to main, and increments a major/minor version

[sif]

This version broke "Send to txt2img", "Show extra networks", and many other things for me. It's also extremely slow now. I agree with having a dev branch.

[Soulreaver90]

I second a DEV branch for any major changes. The occasional bug fix should go to the main branch, anything that changes a major portion of the UI or functionality should go to DEV for testing and validation.

[space-nuko]

@AUTOMATIC1111 thoughts?

[quasiblob]

"Infact I had fixed all those issues in my PR #8752 but auto decided to merge his instead"

Not my battle, but usually this kinds of discussions are done in private, now you seem to be bringing this to public knowledge, in hopes of mob pressure "I think alot of people can agree" - who did you ask?

Anyway, I'm a simple user and I can use whatever version works the best. I noticed things got borked and git checkouted earlier version.

These are most likely good suggestions, but I doubt this kind of approach will do any good.

[space-nuko]

I mean to say a lot of those issues could have been caught earlier with more collaboration, instead of each person maintaining a separate branch with no cross-communication, I think auto didn't even open a PR for his 3.23 changes so people could test it out first and report any issues. On my PR I did find a lot of bugs from people trying out my fork that I didn't notice before, which I could investigate and fix, because there was a feedback loop going on

I guess it doesn't really matter what auto decides to merge if it's separated into its own develop branch

[catboxanon]

auto has stated before he only reads the PRs in this repo, not issues or discussions. If you want his attention you should probably join his Discord mentioned in the wiki.

[space-nuko]

Okay I only wrote it here because I wasn't aware of that, it didn't make sense to put it into an issue or PR since it doesn't really have to do with the code itself, and that's what the Create Issue dialog suggested