Enabling logs to investigate SQL protection issue (Azure#27313)

Co-authored-by: Yash <[email protected]>

Author: hiaga

src/RecoveryServices/RecoveryServices.Backup.Providers/Providers/AzureWorkloadPsBackupProvider.cs

@@ -929,6 +929,8 @@ private RestAzureNS.AzureOperationResponse<ProtectedItemResource> EnableOrModify
                         keyValueDict, item.Id);
 
                     properties.PolicyId = policy.Id;
+
+                    Logger.Instance.WriteDebug("Successfully parsed Item URI");
                 }
             }
 
@@ -937,6 +939,7 @@ private RestAzureNS.AzureOperationResponse<ProtectedItemResource> EnableOrModify
                 Properties = properties
             };
 
+            Logger.Instance.WriteDebug("checking for MUA for modify policy");
             // check for MUA
             bool isMUAProtected = false;
             if (isMUAOperation && oldPolicy != null && newPolicy != null)
@@ -947,7 +950,8 @@ private RestAzureNS.AzureOperationResponse<ProtectedItemResource> EnableOrModify
             {
                 isMUAProtected = true;
             }
-
+            
+            Logger.Instance.WriteDebug("Entering CreateOrUpdateProtectedItem");
             return ServiceClientAdapter.CreateOrUpdateProtectedItem(
                 containerUri,
                 protectedItemUri,
@@ -1144,4 +1148,4 @@ private void ValidateAzureWorkloadDisableProtectionRequest(ItemBase itemBase)
             ValidateAzureWorkloadContainerType(itemBase.ContainerType);
         }
     }
-}
+}

src/RecoveryServices/RecoveryServices.Backup.ServiceClientAdapter/BMSAPIs/ItemAPIs.cs

@@ -94,6 +94,7 @@ public RestAzureNS.AzureOperationResponse<ProtectedItemResource> CreateOrUpdateP
                 }
             }
 
+            Logger.Instance.WriteDebug("Executing CreateOrUpdateWithHttpMessagesAsync");
             return BmsAdapter.Client.ProtectedItems.CreateOrUpdateWithHttpMessagesAsync(
                  vaultName ?? BmsAdapter.GetResourceName(),
                  resourceGroupName ?? BmsAdapter.GetResourceGroupName(),

src/RecoveryServices/RecoveryServices.Backup/Cmdlets/Item/EnableAzureRmRecoveryServicesBackupProtection.cs

@@ -173,6 +173,8 @@ public override void ExecuteCmdlet()
                     string.Compare(((AzureWorkloadProtectableItem)ProtectableItem).ProtectableItemType,
                     ProtectableItemType.SQLInstance.ToString()) == 0))
                     {
+                        WriteDebug("Executing AzureWorkloadParameterSet");
+
                         string backupManagementType = ProtectableItem.BackupManagementType.ToString();
                         string workloadType = ConversionUtils.GetServiceClientWorkloadType(ProtectableItem.WorkloadType.ToString());
                         string containerName = "VMAppContainer;" + ((AzureWorkloadProtectableItem)ProtectableItem).ContainerName;
@@ -237,6 +239,8 @@ public override void ExecuteCmdlet()
                     }
                     else
                     {
+                        WriteDebug("Executing parameter set: " + ParameterSetName);
+
                         PsBackupProviderManager providerManager =
                             new PsBackupProviderManager(new Dictionary<Enum, object>()
                             {
@@ -258,10 +262,14 @@ public override void ExecuteCmdlet()
                                 { ResourceGuardParams.IsMUAOperation, isMUAOperation },
                             }, ServiceClientAdapter);
 
+                        WriteDebug("Initialized provider manager");
+
                         IPsBackupProvider psBackupProvider = (Item != null) ?
                             providerManager.GetProviderInstance(Item.WorkloadType, Item.BackupManagementType)
                             : providerManager.GetProviderInstance(Policy.WorkloadType);
-                                        
+
+                        WriteDebug("policy workload type: " + Policy.WorkloadType.ToString());
+
                         if (Policy.WorkloadType == Models.WorkloadType.AzureFiles)
                         {
                             // if item & policy are not null and both have ids
@@ -312,6 +320,8 @@ public override void ExecuteCmdlet()
 
                         var itemResponse = psBackupProvider.EnableProtection();
 
+                        WriteDebug("Enabled protection successfully, going to handle the backup job");
+
                         // Track Response and display job details
                         HandleCreatedJob(
                             itemResponse,

src/RecoveryServices/RecoveryServices/ChangeLog.md

@@ -18,6 +18,7 @@
         - Additional information about change #1
 -->
 ## Upcoming Release
+* Added logs to enable better debugging for Modify protection with MSSQL workload.
 
 ## Version 7.5.1
 * Updated Restore-AzRecoveryServicesBackupItem to support 0 as a TargetZoneNumber to restore to NoZone.