Skip to content

Commit d54dd6d

Browse files
committed
FIX: Force suppress after successfull framework subscription to prevent unwanted offers
1 parent 088b42d commit d54dd6d

File tree

8 files changed

+17
-18
lines changed

8 files changed

+17
-18
lines changed

changelog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
- ADD: Support for Mesos attributes
1414
- FIX: [API] Restart service
1515
- DEL: [API] Remove useless restart task API
16+
- FIX: Force suppress after successfull framework subscription to prevent offers
1617

1718
## v1.1.3
1819

docs/example/mesos-compose.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,8 @@ services:
9191
networks:
9292
default:
9393
external: true
94-
name: mesos-cni
95-
driver: user
94+
name: mesos-net
95+
driver: mesos-net
9696

9797
volumes:
9898
12345test:

docs/example/networkmode-user.yaml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,5 @@ services:
99

1010
networks:
1111
default:
12-
external: true
13-
name: mini
14-
12+
name: mesos-net
13+
driver: mesos-net

docs/example/test-extension.yaml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,5 +23,6 @@ services:
2323

2424
networks:
2525
default:
26-
name: mini
27-
26+
name: mesos-net
27+
driver: mesos-net
28+

docs/example/test-h2c.yaml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@ services:
33
test1:
44
image: docker.io/avhost/docker-lighttpd
55
ports:
6-
- "9999:8888/h2c"
7-
network_mode: "bridge"
6+
- "31820:8888/h2c"
87
labels:
98
traefik.enable: "true"
109
traefik.http.routers.test1.entrypoints: "web"
@@ -15,6 +14,6 @@ services:
1514

1615
networks:
1716
default:
18-
external: true
19-
name: mini
20-
17+
name: mesos-net
18+
driver: mesos-net
19+

mesos/mesos.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,7 @@ func (e *Mesos) Revive() {
9393

9494
// ForceSuppressFramework if all Tasks are running, suppress framework offers
9595
func (e *Mesos) ForceSuppressFramework() {
96+
logrus.WithField("func", "mesos.ForceSuppressFramework").Info("Framework Suppress")
9697
e.IsSuppress = false
9798
e.SuppressFramework()
9899
}

scheduler/heartbeat.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ func (e *Scheduler) Heartbeat() {
5959
}
6060

6161
// there are more instances are running as it should be
62-
if e.Redis.CountRedisKey(task.TaskName+":*", "_KILL") > task.Instances {
62+
if e.Redis.CountRedisKey(task.TaskName+":*", "__KILL") > task.Instances {
6363
logrus.WithField("func", "scheduler.CheckState").Info("Scale down Mesos Task: ", task.TaskName)
6464
e.Mesos.Revive()
6565
task.State = "__KILL"

scheduler/scheduler.go

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -107,11 +107,9 @@ func (e *Scheduler) EventLoop() {
107107
e.Framework.FrameworkInfo.Id = event.Subscribed.GetFrameworkId()
108108
e.Framework.MesosStreamID = res.Header.Get("Mesos-Stream-Id")
109109

110-
if e.Config.ThreadEnable {
111-
go e.reconcile()
112-
} else {
113-
e.reconcile()
114-
}
110+
e.reconcile()
111+
e.Mesos.ForceSuppressFramework()
112+
115113
go e.Redis.SaveFrameworkRedis(e.Framework)
116114
go e.Redis.SaveConfig(*e.Config)
117115
case mesosproto.Event_UPDATE.Number():

0 commit comments

Comments
 (0)