Possible mistake in torque calculation of facetDragDynamicEffector #464
BriekArcsec
started this conversation in
General
Replies: 1 comment
-
Another good point. We'll look into this. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
I think there might be a minus sign missing in this torque calculation:
basilisk/src/simulation/dynamics/facetDragEffector/facetDragDynamicEffector.cpp
Line 135 in 4c26e17
Since$T = r \times F = - F \times r$ , while this equation seems to calculate the torque with $T = F \times r$ . FacetSRPDynamicEffector also uses the former method of computing the resulting torque.
basilisk/src/simulation/dynamics/facetSRPDynamicEffector/facetSRPDynamicEffector.cpp
Line 163 in 4c26e17
Beta Was this translation helpful? Give feedback.
All reactions