Merge pull request #803 from AVSystem/deprecate-spring-module

deprecate `spring` module and related components in preparation for removal

Author: halotukozak

README.md

@@ -40,6 +40,6 @@
 * `commons-hocon` - Utilities for working with [HOCON](https://github.com/lightbend/config/blob/master/HOCON.md)
   * `HoconInput` - an `Input` implementation for `GenCodec` that can read Lightbend Config (`com.typesafe.config.Config`)
   * An AST (`HTree`) and a lexer/parser for HOCON (`HLexer`, `HParser`)
-* `commons-spring` - Spring framework utilities:
+* `commons-spring` (DEPRECATED) - Spring framework utilities:
   * `HoconBeanDefinitionReader` - an utility that allows you to define Spring application context using 
   [HOCON](https://github.com/lightbend/config/blob/master/HOCON.md) format

spring/src/main/scala/com/avsystem/commons/spring/AttrNames.scala

@@ -6,6 +6,7 @@ import org.springframework.beans.factory.support.AbstractBeanDefinition
 
 /** Created: 17-03-2014 Author: ghik
   */
+@deprecated(spring.DeprecatedMessage, spring.DeprecatedSince)
 object AttrNames {
   final val AbstractAttr = "%abstract"
   final val ArgTypesAttr = "%arg-types"

spring/src/main/scala/com/avsystem/commons/spring/HoconBeanDefinitionReader.scala

@@ -13,6 +13,7 @@ import org.springframework.core.io.Resource
 import java.{util => ju}
 import scala.annotation.nowarn
 
+@deprecated(spring.DeprecatedMessage, spring.DeprecatedSince)
 class HoconBeanDefinitionReader(registry: BeanDefinitionRegistry) extends AbstractBeanDefinitionReader(registry) {
 
   import com.avsystem.commons.spring.HoconBeanDefinitionReader.Keys._

spring/src/main/scala/com/avsystem/commons/spring/HoconType.scala

@@ -2,7 +2,9 @@ package com.avsystem.commons
 package spring
 
 import com.typesafe.config._
+import scala.annotation.nowarn
 
+@deprecated(spring.DeprecatedMessage, spring.DeprecatedSince)
 trait HoconType[T] {
 
   protected def requireNonNull(value: ConfigValue): ConfigValue = {
@@ -21,6 +23,7 @@ trait HoconType[T] {
   def get(value: ConfigValue): T
 }
 
+@nowarn("msg=deprecated")
 object HoconType {
 
   import com.typesafe.config.ConfigValueType._

spring/src/main/scala/com/avsystem/commons/spring/ScalaDefaultValuesInjector.scala

@@ -11,6 +11,7 @@ import scala.annotation.tailrec
 import scala.beans.BeanProperty
 import scala.reflect.{ScalaLongSignature, ScalaSignature}
 
+@deprecated(spring.DeprecatedMessage, spring.DeprecatedSince)
 class ScalaDefaultValuesInjector extends BeanDefinitionRegistryPostProcessor {
   @BeanProperty var paramNameDiscoverer: ParameterNameDiscoverer =
     new StandardReflectionParameterNameDiscoverer

spring/src/main/scala/com/avsystem/commons/spring/package.scala

@@ -0,0 +1,6 @@
+package com.avsystem.commons
+
+package object spring {
+  private[spring] final val DeprecatedMessage = "spring module is deprecated and it is going to be removed"
+  private[spring] final val DeprecatedSince = "2.27.0"
+}

spring/src/test/scala/com/avsystem/commons/spring/HoconBeanDefinitionReaderTest.scala

@@ -8,7 +8,8 @@ import org.springframework.beans.factory.support.DefaultListableBeanFactory
 import org.springframework.context.support.GenericApplicationContext
 import org.springframework.core.StandardReflectionParameterNameDiscoverer
 
-import java.{util => ju}
+import java.util as ju
+import scala.annotation.nowarn
 import scala.beans.BeanProperty
 
 class TestBean(val constrInt: Int = 1, val constrString: String = "constrDefault") {
@@ -35,6 +36,7 @@ object ConditionalTestBean {
   var initializedCount = 0
 }
 
+@nowarn("msg=deprecated")
 class HoconBeanDefinitionReaderTest extends AnyFunSuite with BeforeAndAfterEach {
   def createContext(resource: String): GenericApplicationContext = {
     val beanFactory = new DefaultListableBeanFactory

spring/src/test/scala/com/avsystem/commons/spring/XmlPlayground.scala

@@ -4,6 +4,9 @@ package spring
 import com.typesafe.config.ConfigFactory
 import org.springframework.context.support.GenericApplicationContext
 
+import scala.annotation.nowarn
+
+@nowarn("msg=deprecated")
 object XmlPlayground {
   def main(args: Array[String]): Unit = {
     val ctx = new GenericApplicationContext