Skip to content

Commit 8ba1cb4

Browse files
authored
Merge pull request #394 from tze088/error-msg
fix everything
2 parents ba48f01 + ee4497c commit 8ba1cb4

File tree

5 files changed

+15
-10
lines changed

5 files changed

+15
-10
lines changed

src/main/java/seedu/address/logic/commands/group/AddMemberCommand.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,11 +79,12 @@ public CommandResult execute(Model model) throws CommandException {
7979
Person targetPerson = lastShownPersonList.get(contactIndex.getZeroBased());
8080

8181
if (groupToAddTo.containsPerson(targetPerson)) {
82-
throw new CommandException(String.format(MESSAGE_DUPLICATE_PERSON, targetPerson.getName()));
82+
throw new CommandException(String.format(MESSAGE_DUPLICATE_PERSON,
83+
targetPerson.getName() + " (" + targetPerson.getEmail() + ")"));
8384
}
8485

8586
personsToAdd.add(targetPerson);
86-
personNames.add(targetPerson.getNameAsString());
87+
personNames.add(targetPerson.getNameAsString() + " (" + targetPerson.getEmail() + ")");
8788
}
8889

8990
for (Person toAdd : personsToAdd) {

src/main/java/seedu/address/logic/commands/group/DeleteMemberCommand.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ public CommandResult execute(Model model) throws CommandException {
7878

7979
Person targetPerson = lastShownMiniPersonList.get(contactIndex.getZeroBased());
8080
personsToRemove.add(targetPerson);
81-
personNames.add(targetPerson.getNameAsString());
81+
personNames.add(targetPerson.getNameAsString() + " (" + targetPerson.getEmail() + ")");
8282
}
8383

8484
for (Person toRemove : personsToRemove) {

src/main/java/seedu/address/logic/commands/person/EditCommand.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public class EditCommand extends Command {
5757
private final EditPersonDescriptor editPersonDescriptor;
5858

5959
/**
60-
* @param index of the person in the filtered person list to edit
60+
* @param index of the person in the filtered person list to edit
6161
* @param editPersonDescriptor details to edit the person with
6262
*/
6363
public EditCommand(Index index, EditPersonDescriptor editPersonDescriptor) {

src/test/java/seedu/address/logic/commands/group/AddMemberCommandTest.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,8 @@ public void execute_duplicateGroupMember_throwsCommandException() {
100100
AddMemberCommand cmd = new AddMemberCommand(INDEX_FIRST_GROUP, persons);
101101

102102
assertThrows(CommandException.class,
103-
String.format(MESSAGE_DUPLICATE_PERSON, ALICE.getNameAsString()), () -> cmd.execute(modelStub));
103+
String.format(MESSAGE_DUPLICATE_PERSON, ALICE.getNameAsString()
104+
+ " (" + ALICE.getEmail() + ")"), () -> cmd.execute(modelStub));
104105
}
105106

106107
@Test
@@ -112,9 +113,9 @@ public void execute_memberAddedToGroup_success() throws CommandException {
112113

113114
GroupName targetGroupName = modelStub.getFilteredGroupList().get(INDEX_FIRST_GROUP.getZeroBased()).getName();
114115
assertEquals(String.format(MESSAGE_SUCCESS,
115-
modelStub.getFilteredPersonList().get(1).getNameAsString(),
116+
modelStub.getFilteredPersonList().get(1).getNameAsString()
117+
+ " (" + modelStub.getFilteredPersonList().get(1).getEmail() + ")",
116118
targetGroupName), cmd.execute(modelStub).getFeedbackToUser());
117-
118119
assertEquals(cs2103tWithGeorge, modelStub.getFilteredGroupList().get(0));
119120

120121
}

src/test/java/seedu/address/logic/commands/group/DeleteMemberCommandTest.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,8 @@ public void execute_memberDeletedFromGroup_success() throws CommandException {
100100
Group targetGroup = modelStub.getFilteredGroupList().get(INDEX_FIRST_GROUP.getZeroBased());
101101

102102
assertEquals(String.format(MESSAGE_SUCCESS,
103-
targetGroup.getPersons().get(0).getNameAsString(),
103+
targetGroup.getPersons().get(0).getNameAsString()
104+
+ " (" + targetGroup.getPersons().get(0).getEmail() + ")",
104105
targetGroup.getName()), cmd.execute(modelStub).getFeedbackToUser());
105106

106107
assertEquals(cs2103tWithoutAlice, modelStub.getFilteredGroupList().get(0));
@@ -117,8 +118,10 @@ public void execute_multipleMembersDeletedFromGroup_success() throws CommandExce
117118

118119
Group targetGroup = modelStub.getFilteredGroupList().get(INDEX_FIRST_GROUP.getZeroBased());
119120
ObservableList<Person> personList = targetGroup.getPersons();
120-
List<String> personListAsString = List.of(personList.get(0).getNameAsString(),
121-
personList.get(1).getNameAsString());
121+
List<String> personListAsString = List.of(personList.get(0).getNameAsString()
122+
+ " (" + personList.get(0).getEmail() + ")",
123+
personList.get(1).getNameAsString()
124+
+ " (" + personList.get(1).getEmail() + ")");
122125

123126
assertEquals(String.format(MESSAGE_SUCCESS,
124127
personListAsString.stream().collect(Collectors.joining(", ")),

0 commit comments

Comments
 (0)