fix: "Save" button now immediately enabled for matching dialogs

closes #3231

Author: sleidig

src/app/core/form-dialog/dialog-buttons/dialog-buttons.component.html

@@ -1,7 +1,7 @@
 <button
   mat-raised-button
   color="accent"
-  [disabled]="!canSave"
+  [disabled]="!form.formGroup.valid"
   (click)="save()"
   angulartics2On="click"
   [angularticsCategory]="entity?.getType()"

src/app/core/form-dialog/dialog-buttons/dialog-buttons.component.ts

@@ -21,9 +21,7 @@ import { EntityAbility } from "../../permissions/ability/entity-ability";
 import { UnsavedChangesService } from "../../entity-details/form/unsaved-changes.service";
 import { EntityActionsMenuComponent } from "../../entity-details/entity-actions-menu/entity-actions-menu.component";
 import { ViewComponentContext } from "../../ui/abstract-view/view-component-context";
-import { UntilDestroy, untilDestroyed } from "@ngneat/until-destroy";
 
-@UntilDestroy()
 @Component({
   selector: "app-dialog-buttons",
   imports: [
@@ -50,7 +48,6 @@ export class DialogButtonsComponent<E extends Entity> implements OnInit {
   @Input() entity: E;
   @Input() form: EntityForm<E>;
   detailsRoute: string;
-  canSave: boolean = false;
 
   @Output() closeView = new EventEmitter<any>();
 
@@ -82,11 +79,6 @@ export class DialogButtonsComponent<E extends Entity> implements OnInit {
       }
       this.initializeDetailsRouteIfAvailable();
     }
-    this.form.formGroup.valueChanges
-      .pipe(untilDestroyed(this))
-      .subscribe(() => {
-        this.canSave = this.hasFormValue();
-      });
   }
 
   private initializeDetailsRouteIfAvailable() {
@@ -132,23 +124,4 @@ export class DialogButtonsComponent<E extends Entity> implements OnInit {
       this.close();
     }
   }
-
-  /**
-   * Checks if any control in the form has a non-empty value.
-   * Returns true if at least one form control contains a value
-   */
-  private hasFormValue(): boolean {
-    return Object.values(this.form.formGroup.controls).some((ctrl) => {
-      const val = ctrl.value;
-      if (
-        val === null ||
-        val === undefined ||
-        (Array.isArray(val) && val.length === 0) ||
-        JSON.stringify(val) === "{}" ||
-        (typeof val === "string" && val.trim().length === 0)
-      )
-        return false;
-      else return true;
-    });
-  }
 }