Skip to content

Conversation

@aam-digital-ci
Copy link
Collaborator

@aam-digital-ci aam-digital-ci commented Oct 24, 2025

This PR updates translations from POEditor.
Generated by GitHub Actions.

Summary by CodeRabbit

  • New Features

    • Enhanced translation support for public form configurations and context-aware assistant features in German and French.
  • Documentation

    • Updated German and French locale files with improved translation location metadata and reorganized translation entries for better UI component coverage and maintainability.

@github-actions
Copy link
Contributor

Deployed to https://pr-3415.aam-digital.net/

@sleidig sleidig enabled auto-merge (squash) October 24, 2025 15:30
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 24, 2025

Walkthrough

The PR updates German and French translation files, adding new translation entries for public forms, bulk actions, and context-aware assistant features while re-organizing line numbers and context locations across multiple components to reflect UI restructuring.

Changes

Cohort / File(s) Summary
Locale Translation Updates
src/assets/locale/messages.de.xlf, src/assets/locale/messages.fr.xlf
Added new translation units for bulk actions, public form configuration, and context-aware assistant features; re-numbered and relocated existing translation entries across multiple components (entity-bulk-actions, email-client, public-form, admin-dashboard, setup-assistant); removed some previous bulk-action translations from entity-list paths; extensive context-location metadata restructuring and line number adjustments

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

The changes are repetitive in nature—homogeneous translation metadata updates and entry relocations applied consistently across both locale files. While voluminous in quantity, the edits follow predictable patterns (line number shifts, location context updates, and entry additions) that can be systematically verified.

Possibly related PRs

  • #3392: Modifies the same locale XLF files with similar trans-unit renumbering and UI translation entries (public-form/age-related strings).
  • #3329: Performs extensive location/linenumber rebasing and adds new translation units across the same locale files.
  • #3370: Introduces and relocates public-form related translation units with overlapping i18n changes.

Suggested labels

released on @master, released

Suggested reviewers

  • sleidig

Poem

🐰 Translation tales in German, French, so grand,
Bulk actions, forms, and assistants planned,
Line numbers shuffled, new contexts in place,
i18n magic keeps pace!

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description is largely incomplete compared to the required template. The provided description consists of only two sentences ("This PR updates translations from POEditor. Generated by GitHub Actions.") and is missing critical template sections including: issue references (closes #ISSUE_NUMBER), the PR Checklist with all required checkboxes for CI checks and manual testing, checklist item verification, and the "Remaining TODOs" section. While this is an automated PR generated by GitHub Actions, the template should still be followed or the description should explicitly note why certain sections don't apply. Update the PR description to include: (1) any related GitHub issue numbers with "closes #ISSUE_NUMBER" format, (2) the complete PR Checklist from the template with appropriate items checked or marked as not applicable for automated PRs, and (3) clarification about the "Remaining TODOs" section. If this PR truly requires no manual checklist items due to automation, explicitly state that alongside the automated changes.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "Update POEditor translations messages" is directly related to the main changes in the changeset. The diff primarily modifies German and French translation files (messages.de.xlf and messages.fr.xlf) with location metadata updates, new translation entries, and reorganization of existing translation data from POEditor. The title clearly and concisely communicates what was updated, and a teammate scanning the commit history would understand that this PR addresses translation updates.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/update-poeditor-translations

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@argos-ci
Copy link

argos-ci bot commented Oct 24, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 1 changed Oct 24, 2025, 3:32 PM

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (10)
src/assets/locale/messages.fr.xlf (2)

328-337: Broken placeholder braces in targets — fix to avoid rendering issues

Two targets have malformed Angular placeholders (missing closing braces), risking incorrect interpolation at runtime.

-        <target> présent à <x id="INTERPOLATION" equiv-text="{{ attendanceDescription }"/> évènement(s) </target>
+        <target> présent à <x id="INTERPOLATION" equiv-text="{{ attendanceDescription }}"/> évènement(s) </target>

-        <target> (à l&apos;exception de <x id="INTERPOLATION" equiv-text="{{ logicalCount[LStatus.IGNORE] }"/> évènement(s) excusé ou sans information) </target>
+        <target> (à l&apos;exception de <x id="INTERPOLATION" equiv-text="{{ logicalCount[LStatus.IGNORE] }}"/> évènement(s) excusé ou sans information) </target>

Optionally also standardize “événement(s)” spelling across the file.

Also applies to: 339-346


2166-2172: Quick polish of high-visibility FR strings

Minor fixes improve clarity and consistency.

-        <target> Finition </target>
+        <target> Terminer </target>

-        <target>Taper</target>
+        <target>Type</target>

-        <target>Entregistrements associés</target>
+        <target>Enregistrements associés</target>

-        <target>Totalement inconnu</target>
+        <target>Total inconnu</target>

If you prefer, I can run a sweep to normalize “évènement/événement” and “Présents/Présence” usage across related units.

Also applies to: 1521-1533, 2972-2980, 5842-5850

src/assets/locale/messages.de.xlf (8)

1548-1553: Fix typos and duplication in sentence (and → und; von von).

Suggested improved, formal phrasing.

-        <target>Wähle ein existierendes Set and Optionen das von von anderen Feldern auch genutzt wird oder erstelle ein neues unabhängiges Set.</target>
+        <target>Wählen Sie ein bestehendes Set an Optionen, das auch von anderen Feldern genutzt wird, oder erstellen Sie ein neues, unabhängiges Set.</target>

1629-1633: Correct spelling: “anonymisieren”.

Minor typo in a prominent help text.

-        <target>Wert anonymiseren, aber dabei verallgemeinerte Informationen für statistische Auswertungen erhalten. Für Datumswerte wird der genaue Tag gelöscht, das Jahr aber weiter gespeichert. Datenfeldtypen, die keine Teil-Anonymisierung unterstützen (z.B. Textfelder), werden mit dieser Einstellung komplett gelöscht.</target>
+        <target>Wert anonymisieren, dabei aber verallgemeinerte Informationen für statistische Auswertungen erhalten. Für Datumswerte wird der genaue Tag gelöscht, das Jahr aber weiter gespeichert. Datenfeldtypen, die keine Teil‑Anonymisierung unterstützen (z. B. Textfelder), werden mit dieser Einstellung komplett gelöscht.</target>

770-776: Fix noun/umlaut: “Schule” (not Schuler).

Aligns with intended meaning of continuing education outside the project.

-        <target>Besucht Schuler außerhalb des Projekts</target>
+        <target>Setzt Bildung außerhalb des Projekts fort</target>

621-627: Grammar: “keine Informationen”.

Correct article for plural noun.

-        <target>kein Informationen</target>
+        <target>keine Informationen</target>

2239-2244: Fix typo and natural phrasing in confirmation.

-        <target>Wollen Sie siche die Option &quot;<x id="PH" equiv-text="value.label"/>&quot; löschen?</target>
+        <target>Möchten Sie die Option &quot;<x id="PH" equiv-text="value.label"/>&quot; wirklich löschen?</target>

276-281: Comma for infinitive clause.

Improves readability.

-        <target>Archivierte Teilnehmende ausgeblendet. Klicken um diese einzubeziehen.</target>
+        <target>Archivierte Teilnehmende ausgeblendet. Klicken, um diese einzubeziehen.</target>

2255-2261: Button label casing.

Use lowercase verb in German button label.

-        <target>Option Löschen</target>
+        <target>Option löschen</target>

1329-1335: Fix corrupted i18n placeholder tags: equiv-text values are truncated in target.

The target element has garbled equiv-text attributes for both placeholder tags. The START_TAG equiv-text is truncated to us-circle&quot;... (missing opening) and CLOSE_TAG is reduced to a single A. Tag structure matches (2 tags in both), but content is corrupted. Copy source values to target:

-        <target><x id="START_TAG_FA_ICON" ctype="x-fa_icon" equiv-text="us-circle&quot;             class=&quot;standard-icon-with-text&quot;           &gt;"/><x id="CLOSE_TAG_FA_ICON" ctype="x-fa_icon" equiv-text="A"/> Sektion hinzufügen </target>
+        <target><x id="START_TAG_FA_ICON" ctype="x-fa_icon" equiv-text="&lt;fa-icon           aria-label=&quot;add element&quot;           icon=&quot;plus-circle&quot;           class=&quot;standard-icon-with-text&quot;         &gt;"/><x id="CLOSE_TAG_FA_ICON" ctype="x-fa_icon" equiv-text="&lt;/fa-icon&gt;"/> Sektion hinzufügen</target>
🧹 Nitpick comments (1)
src/assets/locale/messages.de.xlf (1)

7340-7341: Unify “Submit Another Form” wording.

Use the same phrase across success page and config setting.

-        <target> Weiteres Formular ausfüllen </target>
+        <target>Weiteres Formular ausfüllen</target>
@@
-        <target>„Weiteres Formular senden“-Button anzeigen</target>
+        <target>„Weiteres Formular ausfüllen“-Button anzeigen</target>
@@
-        <target>Wenn diese Option aktiviert ist, wird Benutzern nach erfolgreicher Übermittlung die Option „Weiteres Formular übermitteln“ angezeigt. Dies ist hilfreich, wenn eine Benutzer:in mehrere Formulare abschicken soll.</target>
+        <target>Wenn diese Option aktiviert ist, wird Benutzenden nach erfolgreicher Übermittlung die Option „Weiteres Formular ausfüllen“ angezeigt. Das ist hilfreich, wenn eine Person mehrere Formulare einreichen soll.</target>

Also applies to: 10435-10450

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fc9fb2b and 240b5f3.

📒 Files selected for processing (2)
  • src/assets/locale/messages.de.xlf (68 hunks)
  • src/assets/locale/messages.fr.xlf (68 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: qa / test-e2e
  • GitHub Check: qa / test-unit
  • GitHub Check: build-webapp
🔇 Additional comments (2)
src/assets/locale/messages.fr.xlf (1)

1412-1415: Context link added — OK

Additional context-group for entity bulk actions looks good; no translation change.

src/assets/locale/messages.de.xlf (1)

358-369: Equiv-text braces look truncated in multiple placeholders.

While not runtime-critical, consider fixing for maintainability. Ensure closing “}}” in equiv-text examples.

Would you like a quick script to scan all targets for likely truncated Angular interpolation samples in equiv-text (e.g., “}}” mismatches)?

Also applies to: 371-377, 379-386

@sleidig sleidig merged commit 97e6a31 into master Oct 24, 2025
17 checks passed
@sleidig sleidig deleted the chore/update-poeditor-translations branch October 24, 2025 20:11
@aam-digital-ci
Copy link
Collaborator Author

🎉 This PR is included in version 3.65.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated pr released managed by CI (semantic-release)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants