remove ostruct use

Author: AaronLasseigne

CHANGELOG.md

@@ -4,6 +4,11 @@
 
  - Support for Ruby 3.4.
 
+## Fixed
+
+ - OStruct was listed as a development dependency instead of a runtime dependency.
+   The need for OStruct has been removed entirely.
+
 # [5.4.0][] (2024-11-23)
 
 ## Added

active_interaction.gemspec

@@ -42,7 +42,6 @@ Gem::Specification.new do |spec|
     'actionpack' => [],
     'activerecord' => [],
     'kramdown' => ['~> 2.1'],
-    'ostruct' => ['~> 0.6'],
     'rake' => ['~> 13.0'],
     'rspec' => ['~> 3.5'],
     'rubocop' => ['~> 1.68.0'],

lib/active_interaction/grouped_input.rb

@@ -1,11 +1,31 @@
 # frozen_string_literal: true
 
-require 'ostruct'
-
 module ActiveInteraction
   # Holds a group of inputs together for passing from {Base} to {Filter}s.
   #
   # @private
-  class GroupedInput < OpenStruct
+  class GroupedInput
+    include Comparable
+
+    attr_reader :data
+    protected :data
+
+    def initialize(**data)
+      @data = data
+    end
+
+    def [](key)
+      @data[key]
+    end
+
+    def []=(key, value)
+      @data[key] = value
+    end
+
+    def <=>(other)
+      return nil unless other.is_a?(self.class)
+
+      data <=> other.data
+    end
   end
 end

spec/active_interaction/grouped_input_spec.rb

@@ -1,15 +1,33 @@
 RSpec.describe ActiveInteraction::GroupedInput do
-  subject(:grouped_input) { described_class.new }
+  describe '.new' do
+    it 'adds all values to the object' do
+      grouped_input = described_class.new('1' => 1, '2' => 2)
 
-  it 'subclasses OpenStruct' do
-    expect(grouped_input).to be_an OpenStruct
+      expect(grouped_input['1']).to be 1
+      expect(grouped_input['2']).to be 2
+    end
   end
 
-  it 'responds to #[]' do
-    expect { grouped_input[:key] }.to_not raise_error
+  describe '#[]' do
+    it 'returns nil if the key does not exist' do
+      grouped_input = described_class.new
+
+      expect(grouped_input['1']).to be_nil
+    end
+
+    it 'returns a value if the key exists' do
+      grouped_input = described_class.new('1' => 1)
+
+      expect(grouped_input['1']).to be 1
+    end
   end
 
-  it 'responds to #[]=' do
-    expect { grouped_input[:key] = :value }.to_not raise_error
+  describe '#[]=' do
+    it 'sets the key does not exist' do
+      grouped_input = described_class.new
+
+      expect(grouped_input['1'] = 1).to be 1
+      expect(grouped_input['1']).to be 1
+    end
   end
 end