fix: update Docker login command to use password-stdin for improved security

Author: AbaSheger

.github/workflows/deploy.yml

@@ -185,14 +185,9 @@ jobs:
         echo "${{ secrets.SSH_PRIVATE_KEY }}" > ssh_key.pem
         chmod 600 ssh_key.pem
         
-        # Export variables for SSH session
-        export DOCKER_REGISTRY
-        export DOCKER_USERNAME
-        export DOCKER_PASSWORD
-        
         ssh -o StrictHostKeyChecking=no -i ssh_key.pem opc@${ORACLE_VM_IP} << ENDSSH
         cd ~/music-analytics/vm-deploy || exit 1
-        docker login \${DOCKER_REGISTRY} -u \${DOCKER_USERNAME} -p \${DOCKER_PASSWORD} || exit 1
+        echo "\${DOCKER_PASSWORD}" | docker login \${DOCKER_REGISTRY} -u \${DOCKER_USERNAME} --password-stdin || exit 1
         docker-compose pull || exit 1
         docker-compose up -d || exit 1
         docker logout \${DOCKER_REGISTRY}