chore: Address all 86 review items from Go operator rewrite PR (#275)

* chore: add agentic workflow directories to gitignore

Add .windsurf/, .planning/, .specify/, specs/, CLAUDE.md, and GEMINI.md to gitignore to exclude AI-assisted development workflow files and specifications from version control.

* docs: initialize project

Comprehensive fix pass on Go operator rewrite (PR #274) — addressing all 9 critical, ~25 major, and 50+ minor issues from 8 expert reviewers, plus repo restructuring.

* chore: remove tracked planning docs (now gitignored)

* test(01-01): add failing tests for extraArgs wiring and conflict detection

- Add tests for BuildMasterCommand with extraArgs
- Add tests for BuildWorkerCommand with extraArgs
- Add tests for detectFlagConflicts function
- Add tests for conflict warning logging
- Update existing tests to pass new logger parameter
- Tests currently fail (RED phase) - functions not yet implemented

* feat(01-01): implement extraArgs wiring with conflict detection

- Add operatorManagedFlags registry containing all operator-controlled flags
- Implement detectFlagConflicts function to identify conflicting extraArgs
- Wire extraArgs into BuildMasterCommand with conflict warning logging
- Wire extraArgs into BuildWorkerCommand with conflict warning logging
- Update BuildMasterJob and BuildWorkerJob to accept logger parameter
- Update controller to pass logger to job builders
- Update all test calls to pass logger parameter
- ExtraArgs are appended after operator-managed flags (POSIX last-wins)
- All tests now pass (GREEN phase complete)

* test(01-02): add failing tests for safe resource parsing

RED Phase - Add tests for:
- LoadConfig() returns error for invalid resource quantities
- Multiple invalid values are collected and reported
- Valid resource quantities pass validation
- Empty resource strings are treated as optional

All existing LoadConfig() call sites updated to handle error return.

* feat(01-02): implement safe resource parsing and CR precedence

GREEN Phase - Implementation:

1. Config validation (config.go):
   - LoadConfig() now returns (*OperatorConfig, error)
   - validateResourceQuantities() checks all resource env vars
   - Invalid values produce clear error messages
   - Multiple invalid values collected and reported together
   - Empty strings treated as optional (not validated)

2. Safe parsing (job.go):
   - Replace resource.MustParse() with resource.ParseQuantity()
   - Safe because values pre-validated at startup
   - buildResourceList() now uses ParseQuantity with error ignored

3. Resource precedence (job.go):
   - buildResourceRequirementsWithPrecedence() implements CR → defaults
   - hasResourcesSpecified() helper distinguishes nil vs empty
   - CR resources are complete override (not partial merge)
   - buildLocustContainer() uses new precedence function

4. Main error handling (main.go):
   - Handles LoadConfig error, logs and exits with code 1
   - Clear error messages on startup failure

5. Test updates (suite_test.go):
   - Controller test suite handles new LoadConfig error return

All tests pass. No MustParse in production code.

* feat(01-03): add Helm masterResources and workerResources fields

- Add masterResources and workerResources to values.yaml (default empty)
- Add 12 helper templates in _helpers.tpl for role-specific resources
- Add conditional env vars in deployment.yaml (via envVars helper)
- Empty resources means 'use unified resources' (backward compatible)
- Helm lint passes, default rendering excludes role-specific env vars

* test(01-03): add integration tests for extraArgs and resource precedence

- Add 7 integration tests for BuildMasterJob/BuildWorkerJob
- Test extraArgs appear in generated Job command
- Test CR resources override operator defaults
- Test empty CR resources fall back to defaults
- Test master/worker resources are independent
- All tests pass, verify full Phase 1 wiring works end-to-end

* test(01-04): add failing tests for role-specific resource precedence

Add tests for 3-level resource precedence (CR > role-specific > unified):
- TestLoadConfig_RoleSpecificResourceDefaults: Verify 12 fields default to empty
- TestLoadConfig_RoleSpecificResourceOverrides: Verify env vars are loaded
- TestLoadConfig_InvalidRoleSpecificResource: Verify validation errors
- TestBuildMasterJob_WithHelmMasterResources: Verify master-specific overrides unified
- TestBuildWorkerJob_WithHelmWorkerResources: Verify worker-specific overrides unified
- TestBuildMasterJob_CROverridesHelmRoleSpecific: Verify CR wins over role-specific
- TestBuildMasterJob_HelmRoleSpecific_PrecedenceOverUnified: Verify field-level fallback

Tests fail to compile (RED phase) - fields don't exist yet.

* feat(01-04): implement role-specific config and 3-level resource precedence

Complete the three-level resource precedence chain:
- Level 1: CR-level resources (complete override, highest precedence)
- Level 2: Role-specific operator config (from Helm masterResources/workerResources)
- Level 3: Unified operator defaults (from Helm resources)

Config changes:
- Add 12 role-specific fields to OperatorConfig (6 master, 6 worker)
- LoadConfig reads MASTER_POD_* and WORKER_POD_* env vars with empty defaults
- validateResourceQuantities validates non-empty role-specific values

Job changes:
- buildResourceRequirementsWithPrecedence implements 3-level precedence
- Field-level fallback: empty role-specific → unified (backward compatible)
- CR resources remain complete override (not partial merge)

All tests pass (GREEN phase complete).

* fix(02-01): remove MutatingWebhookConfiguration for CRD conversion

- Remove MutatingWebhookConfiguration block (lines 60-90)
- CRD conversion uses spec.conversion.webhook on CRD, not admission webhook
- Keep ValidatingWebhookConfiguration for CR validation (correct)
- Keep webhook Service for routing API server traffic
- Update comments to clarify conversion is handled by CRD spec
- controller-runtime serves /convert endpoint automatically

* fix(02-01): add emptyDir /tmp volume and fix replicaCount default

- Add tmp emptyDir volume at /tmp for controller-runtime temp files
- Webhook certs mount overlays at subdirectory /tmp/k8s-webhook-server/serving-certs
- readOnlyRootFilesystem: true now works with webhook server
- Change replicaCount default from 2 to 1 (backward compatible with Java operator)
- Update comment to recommend 2+ replicas with leader election for HA
- No volumes/mounts when webhooks disabled (clean default install)

* feat(02-02): tighten RBAC to least privilege with conditional Leases

- ConfigMaps/Secrets reduced to read-only (get, list, watch)
- Jobs reduced to immutable pattern (get, list, watch, create, delete)
- Services reduced to create/delete lifecycle (no update/patch)
- Leases conditional on leaderElection.enabled flag
- Leases verbs reduced (removed delete, kept get/list/watch/create/update/patch)
- Updated header comments to reflect read-only and immutable patterns

* feat(02-02): fix backward compatibility helpers to check leaf values

- Changed all helpers from checking parent keys to checking full path with leaf values
- Pod resources: Check .Values.locustPods.resources.requests.cpu exists (not just .Values.locustPods)
- Boolean helpers (affinity, tolerations): Use hasKey to handle false values correctly
- TTL helper: Check actual ttlSecondsAfterFinished value exists
- Metrics exporter: Check full nested path for image, port, pullPolicy, and resources
- Kafka: Check bootstrapServers and security.enabled with full paths
- Updated header comment to explain leaf-value checking precedence
- Enables true backward compat: old config paths work when new paths are absent

* feat(02-03): add optional PodDisruptionBudget and remove no-op crd.install

- Add PDB template (disabled by default per user decision)
- Add podDisruptionBudget config section to values.yaml
- Remove crd.install no-op value (Helm crds/ always installs unconditionally)
- PDB supports HA deployments with replicaCount >= 2

* fix(02-03): replace CRD symlink with actual file for helm package compatibility

- Remove symlink to ../../locust-k8s-operator-go/config/crd/bases
- Copy locust.io_locusttests.yaml directly into charts/crds/
- Fixes helm package in CI environments where symlink target may not resolve

* refactor(03-01): unify volume name constant and fix mount path trailing slash

- Changed libVolumeName from "locust-lib" to "lib" in webhook to match resources package
- Removed trailing slash from DefaultMountPath ("/lotest/src/" → "/lotest/src")
- Updated test to validate "lib" instead of "locust-lib"
- Both packages now use "lib" as the canonical lib volume name

* feat(03-02): remove generation guard and implement phase-based reconciliation

- Remove Generation > 1 NO-OP guard from reconciler
- Phase-based state machine now drives all reconciliation
- Pending phase creates resources regardless of generation number
- Add V(1) info message for generation > 1 (informational only)
- Rewrite tests to verify phase-based behavior
- Fixes operator-restart edge case where modified-but-unprocessed CRs would never get resources created

* feat(03-02): suppress Prometheus annotations when OTel is enabled

- Add IsOTelEnabled check to BuildAnnotations for master pods
- When OTel is enabled, Locust exports metrics natively via OTLP
- No sidecar container or Prometheus scrape annotations needed with OTel
- Pattern matches existing OTel suppression in service.go and job.go
- Add test TestBuildAnnotations_Master_NoPrometheusWhenOTelEnabled
- Rename existing test for clarity

* feat(03-03): detect externally deleted resources and self-heal

- Check for missing Service, master Job, and worker Job during reconcileStatus
- Reset Phase to Pending when resources are externally deleted
- Emit Warning event with descriptive message
- Pending phase triggers createResources on next reconcile (self-healing loop)
- Standard controller-runtime requeue handles exponential backoff

* test(03-03): add external deletion detection and recovery tests

- TestReconcile_ExternalDeletion_MasterService: verify Service deletion triggers recovery
- TestReconcile_ExternalDeletion_MasterJob: verify master Job deletion triggers recovery
- TestReconcile_ExternalDeletion_WorkerJob: verify worker Job deletion triggers recovery
- All tests verify Warning event emission, Phase reset to Pending, and self-healing recreation
- Full test suite passes (21/21 controller integration tests)

* fix(04-01): correct publish-image job — ko path, version, permissions, timeout

- Fix ko build path from ./cmd/main.go to ./cmd (CICD-01)
- Align ko version to @v0.7 matching ci.yaml (CICD-02)
- Remove unnecessary packages: write permission (CICD-12)
- Add timeout-minutes: 30 for job reliability (CICD-03)

* feat(04-01): enforce release ordering and replace chart-releaser fork

- Replace askcloudarchitech fork with upstream helm/chart-releaser-action@v1 (CICD-05)
- Add needs: [publish-image] to helm-chart-release for proper ordering
- Add timeout-minutes: 15 to helm-chart-release (CICD-03)
- Add timeout-minutes: 15 to docs-release (CICD-03)
- Remove stale comments about upstream PR
- Keep docs-release independent for parallel execution

* feat(04-02): parallelize CI jobs, add timeouts, fix ct.yaml timeout

- Remove needs: dependencies from lint-test-helm and docs-test jobs
- Jobs now run in parallel (build-go, lint-test-helm, docs-test)
- Add timeout-minutes: 30 to build-go and lint-test-helm jobs
- Add timeout-minutes: 15 to docs-test job
- Increase ct.yaml helm timeout from 120s to 300s for operator deployments

* feat(04-02): add artifact uploads on CI job failures

- Upload Go test artifacts (cover.out) on build-go failure
- Upload kind cluster logs on lint-test-helm failure
- Upload docs build output (site/) on docs-test failure
- All artifacts retained for 7 days

* feat(04-03): overhaul E2E workflow with security and reliability fixes

- Add permissions: read-all for least privilege (CICD-06)
- Replace manual Kind download with helm/kind-action@v1.12.0 (CICD-07)
- Add go mod tidy verification check on go.mod and go.sum (CICD-08)
- Add timeout-minutes: 30 to prevent runaway jobs (CICD-03)
- Add artifact upload on failure for debugging (CICD-11)

* chore(04-03): remove dead nested workflow files

- Remove locust-k8s-operator-go/.github/workflows/lint.yml
- Remove locust-k8s-operator-go/.github/workflows/test.yml
- Remove locust-k8s-operator-go/.github/workflows/test-e2e.yml

These workflows are dead code - GitHub Actions only reads from repo root
.github/workflows/. The nested workflows were leftover from when the Go
operator was a standalone repository. All functionality is covered by
root-level ci.yaml, go-test-e2e.yml, and release.yaml.

* fix(05-01): fix imagePullSecrets format and reframe Kafka docs

- Fix imagePullSecrets to use LocalObjectReference format (- name: gcr-secret)
- Reframe Kafka section to explain two-level config model
- Document operator-level centralized configuration approach
- Document per-test override capability
- Remove deprecated framing from Kafka documentation

* fix(05-01): fix metrics.secure comment and replace jaeger with otlphttp

- Correct metrics.secure comment to state default is false
- Replace deprecated jaeger exporter with otlphttp in OTel collector config
- Update exporter endpoint to http://jaeger-collector:4318 (OTLP HTTP)

* docs(05-02): fix status example and update copyright/roadmap

- Replace non-existent masterJob/workerJob fields with actual status fields
- Add expectedWorkers, connectedWorkers, startTime, conditions
- Update copyright year from 2025 to 2026
- Delete stale roadmap.md file
- Remove roadmap from mkdocs.yml navigation

* docs(05-02): fix README framework reference

- Change "Operator SDK" to "controller-runtime" in comparison table
- Removes ambiguity (Operator SDK could mean CLI tool or framework)
- controller-runtime is the actual framework used (verified in go.mod)

* docs(05-03): standardize namespaces, add missing image field, fix CPU limit

- helm_deploy.md: add --namespace locust-system --create-namespace to all install examples
- getting_started.md: add missing image field to v2 lib configmap example
- migration.md: fix operator CPU limit from 100m to 500m (matches values.yaml)

Fixes: DOCS-02, DOCS-04, DOCS-06

* docs(05-03): remove subdirectory references and fix working dir instructions

- Remove all locust-k8s-operator-go/ subdirectory references across docs
- Update local-development.md with note about dev vs production namespaces
- Update integration-testing.md directory tree to show repo root structure
- Update pull-request-process.md to remove subdirectory path reference
- Simplify Kind cluster name in integration-testing.md

Fixes: DOCS-05, DOCS-12

* fix(06-02): remove os.Chdir side effect and fix E2E label selectors

- Remove os.Chdir from test/utils/utils.go (global side effect causing test interference)
- Fix E2E conversion script to use correct label selectors (performance-test-pod-name)
- Replace app=locust-master/worker with performance-test-pod-name=<name>-master/worker

* feat(06-01): add typed Phase enum, ObservedGeneration, and phase transition events

- Define Phase as typed enum (type Phase string) for compile-time safety
- Add ObservedGeneration field to LocustTestStatus for controller progress tracking
- Update derivePhaseFromJob to return typed Phase
- Add phase transition event recording (TestStarted, TestCompleted, TestFailed)
- Update ObservedGeneration on all status updates in controller
- Document ConnectedWorkers as approximation from Job.Status.Active
- Remove unused RestartPolicyNever constant (code uses corev1.RestartPolicyNever)
- Remove unused LocustContainerName constant

* feat(06-04): add Helm chart metadata, schema validation, and NOTES.txt

- Add Chart.yaml metadata: kubeVersion, home, sources, maintainers
- Add fullnameOverride and nameOverride support in values and _helpers.tpl
- Add extraEnv support for custom operator environment variables
- Add terminationGracePeriodSeconds configuration
- Add configurable podSecurityContext and containerSecurityContext
- Add health_check extension to OTel Collector config
- Create values.schema.json for Helm value validation
- Create NOTES.txt with post-install instructions and examples

* feat(06-04): add health probes, Kafka gating, and deployment configurability

- Add terminationGracePeriodSeconds to deployment from values
- Use configurable podSecurityContext and containerSecurityContext
- Add extraEnv support to deployment env section
- Gate Kafka environment variables behind kafka.enabled condition
- Add ConfigMap checksum annotation to OTel Collector for auto-rollout
- Add liveness and readiness HTTP probes on port 13133 to OTel Collector
- Add health port (13133) to OTel Collector container ports

* test(06-02): add webhook update tests, boundary tests, and v2 fixtures

- Add TestValidateUpdate_Invalid for webhook update validation (secret mounts, volumes, OTel)
- Add TestValidateCreate_LongCRName boundary test for CR name length validation
- Add validateCRName function to enforce 63-char limit on generated resource names
- Create locusttest-with-scheduling.yaml E2E fixture with affinity and tolerations
- Add LoadV2Fixture/MustLoadV2Fixture functions for v2 test fixtures
- Create locusttest_v2_full.json comprehensive v2 fixture

* test(06-01): add comprehensive status transition tests and fix Phase type in tests

- Add TestUpdateStatusFromJobs_FullStateMachine covering all phase transitions
- Add TestUpdateStatusFromJobs_PhaseTransitionEvents verifying event emission
- Add TestUpdateStatusFromJobs_NoEventOnSamePhase for idempotency verification
- Add TestUpdateStatusFromJobs_ObservedGeneration verifying generation tracking
- Add TestDerivePhaseFromJob_TypeSafety verifying typed Phase return
- Add TestUpdateStatusFromJobs_WorkersConnectedCondition for worker tracking
- Fix existing tests to use typed Phase (string conversion for comparisons)
- Update CRD manifests for ObservedGeneration field

* test(06-06): remove v1 webhook unused logger and add OTel integration tests

- Remove unused logf import and blank identifier assignment in api/v1/locusttest_webhook.go
- Add comprehensive OTel integration tests in internal/resources/env_test.go
  - TestBuildEnvVars_WithOTel_Enabled: verifies OTel env vars correctly merged with Kafka and user vars
  - TestBuildEnvVars_WithOTel_Disabled: verifies no OTel vars when disabled
  - TestBuildEnvVars_WithOTel_NoObservabilityConfig: verifies no OTel vars when config absent
  - TestBuildEnvVars_OTel_HTTPProtocol: verifies HTTP protocol support
  - TestBuildEnvVars_OTel_EnvVarOrder: verifies correct precedence (Kafka, OTel, user)

Note: PDB template was already implemented in a previous phase

* feat(06-03): add gosec, errorlint, exhaustive linters and wrap reconciler errors

- Add gosec, errorlint, exhaustive linters to .golangci.yml
- Configure errorlint with all checks enabled
- Configure exhaustive with strict mode (default-signifies-exhaustive: false)
- Add error wrapping with %w to all reconciler error returns
- Add PhasePending case to switch statement (exhaustive requirement)
- Fix gofmt formatting in config.go
- Add justified nolint:gosec directives for test code with known safe inputs

* refactor(06-03): move BuildKafkaEnvVars to env.go and replace custom string helpers

- Move BuildKafkaEnvVars function from job.go to env.go for logical grouping
- Move strconv import from job.go to env.go (only used by BuildKafkaEnvVars)
- Replace custom contains()/containsHelper() with stdlib strings.Contains()
- Add strings import to controller unit test

* refactor(06-05): extract main.go helpers and update leader election ID

- Extract parseFlags helper for command-line flag parsing
- Extract configureTLS helper for TLS options
- Extract setupWebhookServer helper for webhook configuration
- Extract setupMetricsServer helper for metrics configuration
- Extract setupControllers helper for controller registration
- Extract setupHealthChecks helper for health probes
- Remove nolint:gocyclo directive (no longer needed)
- Change leader election ID to locust-k8s-operator.locust.io (CORE-27)

* chore(06-05): update project metadata, dockerfile, build files, and RBAC

- Update PROJECT file to track v2 API (CORE-21)
- Pin Dockerfile golang version to 1.24.0 (CORE-23)
- Add comprehensive .dockerignore for build optimization (CORE-18)
- Add cover.out, coverage.out, venv/ to .gitignore (CORE-20)
- Remove create/delete verbs from locusttests RBAC (CORE-28)
- Remove finalizers permission from RBAC (CORE-29)
- Update kubebuilder RBAC markers in controller
- Add map ordering comment to buildNodeSelector (CORE-15)

* chore(07-01): remove legacy Java operator code and build files

- Remove all Java source code (src/)
- Remove Gradle build system (build.gradle, gradle/, gradlew, settings.gradle)
- Remove Java tooling config (lombok.config, micronaut-cli.yml)
- Remove legacy Kubernetes manifests (kube/)
- Remove old integration scripts (scripts/)
- Remove legacy planning directories (issue-analysis/, v2/)
- Remove build artifacts (build/, .gradle/)

Archive branch archive/java-operator-v1 preserves Java code from master.
Go operator in locust-k8s-operator-go/ remains intact.

* refactor(07-02): move Go operator code from subdirectory to repository root

Move all Go operator files from locust-k8s-operator-go/ to repository root using git mv to preserve file history. The Go operator is now the primary codebase and belongs at the root level.

Files moved:
- Go module (go.mod, go.sum)
- Source code (cmd/, api/, internal/, test/)
- Build system (Makefile, Dockerfile, PROJECT)
- Config (config/, hack/, .golangci.yml, .dockerignore)
- DevContainer (.devcontainer/)

Files removed:
- locust-k8s-operator-go/README.md (root README is canonical)
- locust-k8s-operator-go/.gitignore (will merge in Plan 03)
- Build artifacts (bin/, venv/, *.out)

* chore(07-03): update CI/CD workflows, Makefile, PROJECT, and gitignore for root-level structure

- Remove working-directory from build-go job in ci.yaml
- Update go-version-file paths from locust-k8s-operator-go/go.mod to go.mod
- Remove working-directory from golangci-lint and ko build steps
- Update artifact paths to reference root-level cover.out
- Update E2E workflow path filters to trigger on root-level Go directories
- Change Makefile IMAGE_TAG_BASE to io/locust-k8s-operator (remove -go)
- Change Makefile KIND_CLUSTER to locust-k8s-operator-test-e2e
- Update buildx builder name to locust-k8s-operator-builder
- Change PROJECT projectName to locust-k8s-operator
- Replace root .gitignore with merged Go and project entries

* chore(07-03): update all config manifests and E2E tests to use locust-k8s-operator

- Change namespace from locust-k8s-operator-go-system to locust-k8s-operator-system
- Update namePrefix in config/default/kustomization.yaml
- Update all resource names, labels, and references across config/ manifests
- Update E2E test constants: namespace, serviceAccountName, metricsServiceName
- Update projectImage reference in e2e_suite_test.go
- Update clusterrole name in metrics test
- Change CSV filename reference in config/manifests/kustomization.yaml
- All config and test files now use standard locust-k8s-operator naming

* docs(07-04): add MIGRATION.md, SECURITY.md, .editorconfig, update README

- Create MIGRATION.md documenting Java-to-Go transition with archive branch reference
- Create SECURITY.md with vulnerability reporting policy
- Create .editorconfig with Go and YAML formatting standards
- Update README.md to reflect Go operator (remove Java usage instructions)
- Update .pre-commit-config.yaml to remove Java-specific hooks (gradle-check, gradle-spotless)
- Update .cz.yaml to remove build.gradle reference and set version to 2.0.0

* chore: fix struct alignment and update test CRD with observedGeneration

* chore(07-04): remove DevContainer configuration files

- Remove .devcontainer/devcontainer.json
- Remove .devcontainer/post-install.sh

* chore(06-05): optimize requeue timing, preallocate slice, and improve code clarity

- Change Requeue: true to RequeueAfter: time.Second for resource deletion detection
- Update unit tests to assert RequeueAfter > 0 instead of Requeue == true
- Preallocate formatErrors slice with capacity for better performance
- Replace if-else chain with switch statement in buildResourceRequirementsWithPrecedence
- Move github.com/go-logr/logr from indirect to direct dependency

* chore(06-05): fix line length formatting in main.go flag parsing and metrics setup

- Wrap metrics-cert-name flag description to comply with line length limits
- Add nolint:lll directive to setupMetricsServer function signature

* test(06-05): add nolint directive for intentional type assertion in status test

* chore: exclude goconst linter from test files in golangci-lint config

* chore: standardize lib volume name and improve status/flag handling

- Rename lib volume from "lib" to "locust-lib" for clarity
- Add cluster_name to E2E workflow Kind cluster creation
- Fix StartTime to only set on first creation (preserve across reconciles)
- Add Ready=false status when test fails
- Add WorkersConnected=false condition when workers missing
- Fix flag conflict detection to match exact flags (not just prefixes)
- Update all tests to reflect locust-lib volume name

* test(e2e): fix testdata directory path to use relative path

- Change testdata path from "test/e2e/testdata" to "testdata" in all E2E tests
- Update locusttest_e2e_test.go, otel_e2e_test.go, v1_compatibility_test.go, and validation_e2e_test.go

Author: AbdelrhmanHamouda

.cz.yaml

@@ -1,12 +1,11 @@
 ---
 commitizen:
   annotated_tag: true
-  bump_message: "bump(release): v$current_version \u2192 v$new_version"
+  bump_message: "bump(release): v$current_version → v$new_version"
   name: cz_conventional_commits
   tag_format: $major.$minor.$patch$prerelease
   update_changelog_on_bump: true
-  version: 1.1.1
+  version: 2.0.0
   version_files:
-  - build.gradle:version
   - charts/locust-k8s-operator/Chart.yaml:appVersion
   - charts/locust-k8s-operator/Chart.yaml:version

.dockerignore

@@ -0,0 +1,34 @@
+# More info: https://docs.docker.com/engine/reference/builder/#dockerignore-file
+
+# Test files
+test/
+*_test.go
+
+# Documentation
+docs/
+*.md
+LICENSE
+
+# Git
+.git/
+.gitignore
+
+# IDE
+.idea/
+.vscode/
+
+# CI
+.github/
+.golangci.yml
+
+# Build artifacts
+bin/
+cover.out
+coverage.out
+
+# Planning
+.planning/
+
+# Python
+venv/
+__pycache__/

.editorconfig

@@ -0,0 +1,29 @@
+root = true
+
+[*]
+end_of_line = lf
+insert_final_newline = true
+charset = utf-8
+trim_trailing_whitespace = true
+
+[*.go]
+indent_style = tab
+indent_size = 4
+
+[*.{yaml,yml}]
+indent_style = space
+indent_size = 2
+
+[*.{md,markdown}]
+trim_trailing_whitespace = false
+
+[Makefile]
+indent_style = tab
+
+[Dockerfile]
+indent_style = space
+indent_size = 4
+
+[*.sh]
+indent_style = space
+indent_size = 2

.github/ct.yaml

@@ -1,3 +1,3 @@
 debug: true
 validate-maintainers: false
-helm-extra-args: --timeout 120s
+helm-extra-args: --timeout 300s

.github/workflows/ci.yaml

@@ -20,9 +20,7 @@ jobs:
   build-go:
     name: 🏗️ Build Go Operator
     runs-on: ubuntu-latest
-    defaults:
-      run:
-        working-directory: locust-k8s-operator-go
+    timeout-minutes: 30
     steps:
       - name: 📂 Checkout repo
         uses: actions/checkout@v4
@@ -33,7 +31,7 @@ jobs:
       - name: 🔧 Setup Go
         uses: actions/setup-go@v5
         with:
-          go-version-file: locust-k8s-operator-go/go.mod
+          go-version-file: go.mod
 
       - name: 📥 Download dependencies
         run: go mod download
@@ -42,7 +40,6 @@ jobs:
         uses: golangci/golangci-lint-action@v8
         with:
           version: v2.1.0
-          working-directory: locust-k8s-operator-go
 
       - name: 🛠️ Build
         run: make build
@@ -54,19 +51,27 @@ jobs:
         if: always()
         uses: codecov/codecov-action@v5
         with:
-          files: locust-k8s-operator-go/cover.out
+          files: cover.out
           flags: go-unit-tests
           name: go-coverage
           fail_ci_if_error: false
 
+      - name: 📦 Upload Go test artifacts on failure
+        if: failure()
+        uses: actions/upload-artifact@v4
+        with:
+          name: go-test-artifacts
+          path: |
+            cover.out
+          retention-days: 7
+
   # ============================================
   # Helm Chart Lint & Test
   # ============================================
   lint-test-helm:
     name: 🌊 Lint & Test chart
     runs-on: ubuntu-latest
-    needs:
-      - build-go
+    timeout-minutes: 30
     steps:
       - name: 📂 Checkout
         uses: actions/checkout@v4
@@ -108,19 +113,18 @@ jobs:
         if: steps.list-changed.outputs.changed == 'true'
         uses: actions/setup-go@v5
         with:
-          go-version-file: locust-k8s-operator-go/go.mod
+          go-version-file: go.mod
 
       - name: 🛠️ Install ko
         if: steps.list-changed.outputs.changed == 'true'
         uses: ko-build/setup-ko@v0.7
 
       - name: 🐳 Build operator image with ko
         if: steps.list-changed.outputs.changed == 'true'
-        working-directory: locust-k8s-operator-go
         env:
           KO_DOCKER_REPO: lotest/locust-k8s-operator
         run: |
-          CHART_VERSION=$(grep '^appVersion:' ../charts/locust-k8s-operator/Chart.yaml | awk '{print $2}' | tr -d '"')
+          CHART_VERSION=$(grep '^appVersion:' charts/locust-k8s-operator/Chart.yaml | awk '{print $2}' | tr -d '"')
           ko build ./cmd --local --bare --tags=${CHART_VERSION}
 
       - name: 📦 Load image into kind cluster
@@ -132,11 +136,23 @@ jobs:
       - name: 🚀 Run chart-testing (install)
         run: ct install --target-branch ${{ github.event.repository.default_branch }} --config .github/ct.yaml --helm-extra-set-args "--set=image.pullPolicy=Never"
 
+      - name: 📦 Collect kind cluster logs on failure
+        if: failure() && steps.list-changed.outputs.changed == 'true'
+        run: kind export logs kind-logs --name chart-testing
+
+      - name: 📦 Upload Helm test artifacts on failure
+        if: failure() && steps.list-changed.outputs.changed == 'true'
+        uses: actions/upload-artifact@v4
+        with:
+          name: helm-test-artifacts
+          path: |
+            kind-logs/
+          retention-days: 7
+
   docs-test:
     name: 📚 Test documentation
     runs-on: ubuntu-latest
-    needs:
-      - lint-test-helm
+    timeout-minutes: 15
     steps:
       - name: 📂 Checkout
         uses: actions/checkout@v4
@@ -161,3 +177,12 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: |
           python -m mkdocs build
+
+      - name: 📦 Upload docs build artifacts on failure
+        if: failure()
+        uses: actions/upload-artifact@v4
+        with:
+          name: docs-build-artifacts
+          path: |
+            site/
+          retention-days: 7

.github/workflows/go-test-e2e.yml

@@ -4,38 +4,58 @@ on:
   push:
     branches: [main, master]
     paths:
-      - 'locust-k8s-operator-go/**'
+      - 'cmd/**'
+      - 'api/**'
+      - 'internal/**'
+      - 'test/**'
+      - 'go.mod'
+      - 'go.sum'
+      - 'Makefile'
   pull_request:
     paths:
-      - 'locust-k8s-operator-go/**'
+      - 'cmd/**'
+      - 'api/**'
+      - 'internal/**'
+      - 'test/**'
+      - 'go.mod'
+      - 'go.sum'
+      - 'Makefile'
 
-defaults:
-  run:
-    working-directory: locust-k8s-operator-go
+permissions: read-all
 
 jobs:
   test-e2e:
     name: 🎯 Run E2E Tests
     runs-on: ubuntu-latest
+    timeout-minutes: 30
     steps:
       - name: 📥 Clone the code
         uses: actions/checkout@v4
 
       - name: 🔧 Setup Go
         uses: actions/setup-go@v5
         with:
-          go-version-file: locust-k8s-operator-go/go.mod
+          go-version-file: go.mod
 
-      - name: ☸️ Install the latest version of kind
-        run: |
-          curl -Lo ./kind https://kind.sigs.k8s.io/dl/latest/kind-linux-amd64
-          chmod +x ./kind
-          sudo mv ./kind /usr/local/bin/kind
-
-      - name: ✔️ Verify kind installation
-        run: kind version
+      - name: ☸️ Create Kind cluster
+        uses: helm/kind-action@v1.12.0
+        with:
+          cluster_name: locust-k8s-operator-test-e2e
+          wait: 120s
 
-      - name: 🎯 Running Test e2e
+      - name: 🔍 Verify go mod tidy
         run: |
           go mod tidy
-          make test-e2e
+          git diff --exit-code -- go.mod go.sum
+
+      - name: 🎯 Run E2E tests
+        run: make test-e2e
+
+      - name: 📦 Upload E2E test artifacts on failure
+        if: failure()
+        uses: actions/upload-artifact@v4
+        with:
+          name: e2e-test-artifacts
+          path: |
+            cover.out
+          retention-days: 7

.github/workflows/release.yaml

@@ -14,9 +14,9 @@ jobs:
   publish-image:
     name: 🐳 Publish image
     runs-on: ubuntu-latest
+    timeout-minutes: 30
     permissions:
       contents: read
-      packages: write
     env:
       DOCKER_IMAGE: lotest/locust-k8s-operator
     steps:
@@ -26,10 +26,10 @@ jobs:
       - name: 🔧 Setup Go
         uses: actions/setup-go@v5
         with:
-          go-version-file: locust-k8s-operator-go/go.mod
+          go-version-file: go.mod
 
       - name: 🔧 Setup ko
-        uses: ko-build/setup-ko@v0.6
+        uses: ko-build/setup-ko@v0.7
 
       - name: 🔐 Login to Docker Hub
         uses: docker/login-action@v3
@@ -38,18 +38,19 @@ jobs:
           password: ${{ secrets.DOCKERHUB_TOKEN }}
 
       - name: 📦 Build and push with ko
-        working-directory: locust-k8s-operator-go
         env:
           KO_DOCKER_REPO: ${{ env.DOCKER_IMAGE }}
         run: |
-          ko build ./cmd/main.go \
+          ko build ./cmd \
             --platform=linux/amd64,linux/arm64 \
             --bare \
             --tags=${{ github.ref_name }},latest,${{ github.sha }}
 
   helm-chart-release:
     name: 🌊 Publish Helm chart
     runs-on: ubuntu-latest
+    timeout-minutes: 15
+    needs: [publish-image]
     permissions:
       contents: write
     steps:
@@ -76,9 +77,7 @@ jobs:
           helm package charts/locust-k8s-operator --app-version=${VERSION} --version=${VERSION} --destination=.cr-release-packages
 
       - name: 🎉 Run chart-releaser
-        # switch back to helm/chart-releaser-action when https://github.com/helm/chart-releaser-action/pull/109 is merged
-        # Waiting for a new release to include changes coming from https://github.com/helm/chart-releaser-action/commit/38cfeacdbbd62d13ec773fcdee1435ff5846c554
-        uses: askcloudarchitech/chart-releaser-action@skip-packaging-option
+        uses: helm/chart-releaser-action@v1
         with:
           skip_packaging: true
         env:
@@ -87,6 +86,7 @@ jobs:
   docs-release:
     name: 📚 Publish documentation
     runs-on: ubuntu-latest
+    timeout-minutes: 15
     permissions:
       contents: write
     steps: