Refactor access configuration loading and error handling in EventBridge writer for improved readability and maintainability

Author: oto-macenauer-absa

src/event_gate_lambda.py

@@ -68,9 +68,7 @@
     name_parts = CONFIG["access_config"].split("/")
     BUCKET_NAME = name_parts[2]
     BUCKET_OBJECT_KEY = "/".join(name_parts[3:])
-    ACCESS = json.loads(
-        aws_s3.Bucket(BUCKET_NAME).Object(BUCKET_OBJECT_KEY).get()["Body"].read().decode("utf-8")
-    )
+    ACCESS = json.loads(aws_s3.Bucket(BUCKET_NAME).Object(BUCKET_OBJECT_KEY).get()["Body"].read().decode("utf-8"))
 else:
     with open(CONFIG["access_config"], "r", encoding="utf-8") as file:
         ACCESS = json.load(file)

src/writer_eventbridge.py

@@ -67,8 +67,11 @@ def write(topic_name: str, message: Dict[str, Any]) -> Tuple[bool, Optional[str]
         logger.error(err_msg)
         return False, err_msg
     except Exception as err:  # pragma: no cover - unexpected failure path
-        err_msg = f"The EventBridge writer failed with unknown error: {err}" \
-            if not isinstance(err, (BotoCoreError, ClientError)) else str(err)
+        err_msg = (
+            f"The EventBridge writer failed with unknown error: {err}"
+            if not isinstance(err, (BotoCoreError, ClientError))
+            else str(err)
+        )
         logger.error(err_msg)
         return False, err_msg