Skip to content

Commit 5491e5c

Browse files
benedekilsulak
andauthored
#291: Project improvements after 0.3.0 release (#300)
* set credentials persistence to `false` in GitHub checkout actions * fixed release notes presence check GitHub workflow (using new action for it) * added supported Atum Agent control functions list to documentation * added new grouping of issues into release notes draft * added badges to `README.md` * CODEOWNERS update * ignoring `AgentServerCompatibilityTests` * conditional load of some modules based on Java version * run tests on all Scala versions --------- Co-authored-by: Ladislav Sulak <laco.sulak@gmail.com>
1 parent dd8eb26 commit 5491e5c

File tree

14 files changed

+214
-139
lines changed

14 files changed

+214
-139
lines changed

.github/CODEOWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
* @benedeki @lsulak @TebaleloS @Zejnilovic @dk1844 @salamonpavel
1+
* @benedeki @lsulak @Zejnilovic @dk1844 @salamonpavel @ABLL526

.github/workflows/build.yml

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,19 +30,20 @@ jobs:
3030
- name: Checkout code
3131
uses: actions/checkout@v4
3232
with:
33-
fetch-depth: 0
33+
fetch-depth: 1
34+
persist-credentials: false
3435
- uses: coursier/cache-action@v5
3536

3637
- name: Setup Scala
3738
uses: olafurpg/setup-scala@v14
3839
with:
3940
java-version: "adopt@1.8"
4041

41-
- name: Build and run unit tests
42-
run: sbt "project model" test doc "project reader" test doc "project agent_spark3" test doc
42+
- name: Build and run tests
43+
run: sbt testAll
4344

44-
- name: Build and run integration tests
45-
run: sbt "project model" testIT "project reader" testIT "project agent_spark3" testIT
45+
- name: Generate documenation
46+
run: sbt doc
4647

4748
test-database-and-server:
4849
name: Test Database and Server
@@ -64,7 +65,8 @@ jobs:
6465
- name: Checkout code
6566
uses: actions/checkout@v4
6667
with:
67-
fetch-depth: 0
68+
fetch-depth: 1
69+
persist-credentials: false
6870
- uses: coursier/cache-action@v5
6971

7072
- name: Setup Scala
@@ -73,10 +75,14 @@ jobs:
7375
java-version: "adopt@1.11.0-11"
7476

7577
- name: Build and run unit tests
76-
run: sbt "project database" test doc "project server" test doc
78+
run: sbt "project database" test "project server" test
7779

7880
- name: Prepare testing database
7981
run: sbt flywayMigrate
8082

8183
- name: Build and run integration tests
8284
run: sbt "project database" testIT "project server" testIT
85+
86+
- name: Generate documentation
87+
run: sbt "project database" doc "project server" doc
88+

.github/workflows/format_check.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,9 @@ jobs:
2727
runs-on: ubuntu-latest
2828
steps:
2929
- name: Checkout code
30-
uses: actions/checkout@v2
30+
uses: actions/checkout@v4
3131
with:
32+
persist-credentials: false
3233
fetch-depth: 0
3334
ref: ${{ github.event.pull_request.head.ref }}
3435

.github/workflows/jacoco_report.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ jobs:
5050
steps:
5151
- name: Checkout code
5252
uses: actions/checkout@v4
53+
with:
54+
persist-credentials: false
5355
- name: Setup Scala
5456
uses: olafurpg/setup-scala@v14
5557
with:

.github/workflows/license_check.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,9 @@ jobs:
2727
runs-on: ubuntu-latest
2828
steps:
2929
- name: Checkout code
30-
uses: actions/checkout@v2
30+
uses: actions/checkout@v4
31+
with:
32+
persist-credentials: false
3133
- name: Setup Scala
3234
uses: olafurpg/setup-scala@v10
3335
with:

.github/workflows/pr_release_note_comment_check.yml

Lines changed: 0 additions & 94 deletions
This file was deleted.
Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,44 @@
1+
#
2+
# Copyright 2021 ABSA Group Limited
3+
#
4+
# Licensed under the Apache License, Version 2.0 (the "License");
5+
# you may not use this file except in compliance with the License.
6+
# You may obtain a copy of the License at
7+
#
8+
# http://www.apache.org/licenses/LICENSE-2.0
9+
#
10+
# Unless required by applicable law or agreed to in writing, software
11+
# distributed under the License is distributed on an "AS IS" BASIS,
12+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
# See the License for the specific language governing permissions and
14+
# limitations under the License.
15+
#
16+
17+
name: Release Notes Presence Check
18+
19+
on:
20+
pull_request:
21+
types: [opened, synchronize, reopened, edited, labeled, unlabeled]
22+
branches: [ master ]
23+
24+
env:
25+
SKIP_LABEL: 'no RN'
26+
RLS_NOTES_TAG_REGEX: 'Release Notes:'
27+
28+
jobs:
29+
release-notes-presence-check:
30+
name: Release Notes Presence Check
31+
runs-on: ubuntu-latest
32+
33+
steps:
34+
- uses: actions/setup-python@v5.1.1
35+
with:
36+
python-version: '3.11'
37+
38+
- name: Check presence of release notes in PR description
39+
uses: AbsaOSS/release-notes-presence-check@v0.1.0
40+
env:
41+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
42+
with:
43+
github-repository: ${{ github.repository }}
44+
pr-number: ${{ github.event.number }}

.github/workflows/release_draft.yml

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ jobs:
2828
steps:
2929
- uses: actions/checkout@v4
3030
with:
31+
persist-credentials: false
3132
fetch-depth: 0
3233
# the following step is disabled because it doesn't order the version tags correctly
3334
# - name: Validate format of received tag
@@ -104,6 +105,7 @@ jobs:
104105
steps:
105106
- uses: actions/checkout@v4
106107
with:
108+
persist-credentials: false
107109
fetch-depth: 0
108110
ref: refs/tags/${{ github.event.inputs.tagName }}
109111

@@ -119,10 +121,17 @@ jobs:
119121
with:
120122
tag-name: ${{ github.event.inputs.tagName }}
121123
chapters: '[
124+
{"title": "No entry 🚫", "label": "duplicate"},
125+
{"title": "No entry 🚫", "label": "invalid"},
126+
{"title": "No entry 🚫", "label": "wontfix"},
127+
{"title": "No entry 🚫", "label": "no RN"},
122128
{"title": "Breaking Changes 💥", "label": "breaking-change"},
123129
{"title": "New Features 🎉", "label": "enhancement"},
124130
{"title": "New Features 🎉", "label": "feature"},
125-
{"title": "Bugfixes 🛠", "label": "bug"}
131+
{"title": "Bugfixes 🛠", "label": "bug"},
132+
{"title": "Infrastructure ⚙️", "label": "infrastructure"},
133+
{"title": "Silent-live 🤫", "label": "silent-live"},
134+
{"title": "Documentation 📜", "label": "documentation"}
126135
]'
127136
duplicity-scope: 'service'
128137
duplicity-icon: '🔁'

.github/workflows/release_publish.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ jobs:
2727
- name: Checkout code
2828
uses: actions/checkout@v4
2929
with:
30+
persist-credentials: false
3031
fetch-depth: 0
3132
- uses: coursier/cache-action@v5
3233

@@ -51,6 +52,7 @@ jobs:
5152
- name: Checkout code
5253
uses: actions/checkout@v4
5354
with:
55+
persist-credentials: false
5456
fetch-depth: 0
5557
- uses: coursier/cache-action@v5
5658

.github/workflows/test_filenames_check.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,9 @@ jobs:
2727
runs-on: ubuntu-latest
2828
steps:
2929
- name: Checkout code
30-
uses: actions/checkout@v2
30+
uses: actions/checkout@v4
31+
with:
32+
persist-credentials: false
3133

3234
- name: Filename Inspector
3335
id: scan-test-files

0 commit comments

Comments
 (0)