Skip to content

Commit 5934ab9

Browse files
committed
feat: make use_ttl configurable via INFOBLOX_USE_TTL environment variable
1 parent 4e325b8 commit 5934ab9

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ To run the provider, you must provide the following Environment Variables:
2929
| INFOBLOX_MAX_RESULTS | 1500 | false |
3030
| INFOBLOX_CREATE_PTR | false | false |
3131
| INFOBLOX_DEFAULT_TTL | 300 | false |
32+
| INFOBLOX_USE_TTL | true | false |
3233
| INFOBLOX_EXTENSIBLE_ATTRIBUTES_JSON | {} | false |
3334

3435
### INFOBLOX_CREATE_PTR

internal/infoblox/infoblox.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ type StartupConfig struct {
7373
MaxResults int `env:"INFOBLOX_MAX_RESULTS" envDefault:"1500"`
7474
CreatePTR bool `env:"INFOBLOX_CREATE_PTR" envDefault:"false"`
7575
DefaultTTL int `env:"INFOBLOX_DEFAULT_TTL" envDefault:"300"`
76+
UseTTL bool `env:"INFOBLOX_USE_TTL" envDefault:"true"`
7677
ExtAttrsJSON string `env:"INFOBLOX_EXTENSIBLE_ATTRIBUTES_JSON" envDefault:"{}"`
7778
FQDNRegEx string
7879
NameRegEx string
@@ -724,7 +725,6 @@ func (p *Provider) recordSet(ep *endpoint.Endpoint, getObject bool) (recordSet i
724725
return
725726
}
726727
startTime = time.Now()
727-
ptrToBoolTrue := true
728728
switch ep.RecordType {
729729
case endpoint.RecordTypeA:
730730
var res []ibclient.RecordA
@@ -734,7 +734,7 @@ func (p *Provider) recordSet(ep *endpoint.Endpoint, getObject bool) (recordSet i
734734
obj.Ipv4Addr = &ep.Targets[0]
735735
obj.Ea = extAttrs
736736
obj.Ttl = &ttl
737-
obj.UseTtl = &ptrToBoolTrue
737+
obj.UseTtl = &p.config.UseTTL
738738
if getObject {
739739
queryParams := ibclient.NewQueryParams(false, map[string]string{"name": *obj.Name, "ipv4addr": *obj.Ipv4Addr})
740740
err = p.client.GetObject(obj, "", queryParams, &res)
@@ -763,7 +763,7 @@ func (p *Provider) recordSet(ep *endpoint.Endpoint, getObject bool) (recordSet i
763763
obj.Ipv4Addr = &ep.Targets[0]
764764
obj.Ea = extAttrs
765765
obj.Ttl = &ttl
766-
obj.UseTtl = &ptrToBoolTrue
766+
obj.UseTtl = &p.config.UseTTL
767767
if getObject {
768768
queryParams := ibclient.NewQueryParams(false, map[string]string{"ptrdname": *obj.PtrdName, "ipv4addr": *obj.Ipv4Addr})
769769
err = p.client.GetObject(obj, "", queryParams, &res)
@@ -791,7 +791,7 @@ func (p *Provider) recordSet(ep *endpoint.Endpoint, getObject bool) (recordSet i
791791
obj.Canonical = &ep.Targets[0]
792792
obj.Ea = extAttrs
793793
obj.Ttl = &ttl
794-
obj.UseTtl = &ptrToBoolTrue
794+
obj.UseTtl = &p.config.UseTTL
795795
if getObject {
796796
queryParams := ibclient.NewQueryParams(false, map[string]string{"name": *obj.Name})
797797
err = p.client.GetObject(obj, "", queryParams, &res)
@@ -847,7 +847,7 @@ func (p *Provider) recordSet(ep *endpoint.Endpoint, getObject bool) (recordSet i
847847
obj.Name = &ep.DNSName
848848
obj.Ea = extAttrs
849849
obj.Ttl = &ttl
850-
obj.UseTtl = &ptrToBoolTrue
850+
obj.UseTtl = &p.config.UseTTL
851851
// TODO: Zone?
852852
if getObject {
853853
queryParams := ibclient.NewQueryParams(false, map[string]string{"name": *obj.Name})

0 commit comments

Comments
 (0)