Skip to content

Commit b6ef2df

Browse files
authored
#145: Add "Tech debt" issue template (#146)
* removing custom "Add to project" workflow, issues are now added to projects using the GH's build in workflow * robustness to an integration test
1 parent 5479d61 commit b6ef2df

File tree

3 files changed

+27
-16
lines changed

3 files changed

+27
-16
lines changed
Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
---
2+
name: Technical debt
3+
about: Technical debt identified or created in the project
4+
labels: 'tech debt'
5+
type: 'Feature'
6+
---
7+
8+
## Description
9+
What is the risk essence.
10+
11+
## Risk location
12+
Where is the source of the risk - class name(s), approach or solution.
13+
14+
## Risk assessment
15+
16+
### Condition of it manifesting
17+
What are the conditions under which this technical debt would manifest.
18+
19+
### Possible impact <!-- optional -->
20+
What is/would be the impact of the technical debt, if not addressed.
21+
22+
## Possible solution <!-- optional -->
23+
Ideas and suggestions how to address the technical debt.

.github/workflows/assign_issue_to_project.yml

Lines changed: 0 additions & 15 deletions
This file was deleted.

slick/src/test/scala/za/co/absa/db/fadb/slick/SlickSingleResultFunctionWithStatusIntegrationTests.scala

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,10 @@
1616

1717
package za.co.absa.db.fadb.slick
1818

19+
import org.scalatest.concurrent.PatienceConfiguration.Timeout
1920
import org.scalatest.concurrent.ScalaFutures
2021
import org.scalatest.funsuite.AnyFunSuite
22+
import org.scalatest.time.{Seconds, Span}
2123
import slick.jdbc.{GetResult, SQLActionBuilder}
2224
import za.co.absa.db.fadb.DBSchema
2325
import za.co.absa.db.fadb.slick.FaDbPostgresProfile.api._
@@ -44,7 +46,8 @@ class SlickSingleResultFunctionWithStatusIntegrationTests extends AnyFunSuite wi
4446

4547
test("Creating actor with status handling") {
4648
val requestBody = CreateActorRequestBody("Separated", "TestUser")
47-
val result = createActor(requestBody).futureValue
49+
val timeout = Timeout(Span(3.0D, Seconds))
50+
val result = createActor(requestBody).futureValue(timeout)
4851
assert(result.isRight)
4952
}
5053
}

0 commit comments

Comments
 (0)