Skip to content

Commit 940fc2b

Browse files
committed
- Black tool applied.
- Several pylint fixes.
1 parent 0d5fafe commit 940fc2b

File tree

5 files changed

+20
-6
lines changed

5 files changed

+20
-6
lines changed

release_notes_generator/action_inputs.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@
4242
SKIP_RELEASE_NOTES_LABELS,
4343
RELEASE_NOTES_TITLE,
4444
RELEASE_NOTE_TITLE_DEFAULT,
45-
SUPPORTED_ROW_FORMAT_KEYS, FROM_TAG_NAME,
45+
SUPPORTED_ROW_FORMAT_KEYS,
46+
FROM_TAG_NAME,
4647
)
4748
from release_notes_generator.utils.enums import DuplicityScopeEnum
4849
from release_notes_generator.utils.gh_action import get_action_input
@@ -314,9 +315,8 @@ def _detect_row_format_invalid_keywords(row_format: str, row_type: str = "Issue"
314315
cleaned_row_format = row_format
315316
for invalid_keyword in invalid_keywords:
316317
logger.error(
317-
"Invalid `{}` detected in `{}` row format keyword(s) found: {}. Will be removed from string.".format(
318+
"Invalid `%s` detected in `%s` row format keyword(s) found: %s. Will be removed from string.",
318319
invalid_keyword, row_type, ", ".join(invalid_keywords)
319-
)
320320
)
321321
if clean:
322322
cleaned_row_format = cleaned_row_format.replace(f"{{{invalid_keyword}}}", "")

release_notes_generator/builder.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
logger = logging.getLogger(__name__)
3030

3131

32-
# TODO - reduce to function only after implementing the features. Will be supported more build ways?
3332
# pylint: disable=too-few-public-methods
3433
class ReleaseNotesBuilder:
3534
"""

release_notes_generator/generator.py

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,12 @@ def generate(self) -> Optional[str]:
128128
return release_notes_builder.build()
129129

130130
def get_latest_release(self, repo: Repository) -> Optional[GitRelease]:
131+
"""
132+
Get the latest release of the repository.
133+
134+
@param repo: The repository to get the latest release from.
135+
@return: The latest release of the repository, or None if no releases are found.
136+
"""
131137
if ActionInputs.is_from_tag_name_defined():
132138
logger.info("Getting latest release by from-tag name %s", ActionInputs.get_tag_name())
133139
rls = self._safe_call(repo.get_release)(ActionInputs.get_from_tag_name())
@@ -144,6 +150,11 @@ def get_latest_release(self, repo: Repository) -> Optional[GitRelease]:
144150
logger.info("Latest release not found for %s. 1st release for repository!", repo.full_name)
145151

146152
if rls is not None:
147-
logger.debug("Latest release with tag:'%s' created_at: %s, published_at: %s", rls.tag_name, rls.created_at, rls.published_at)
153+
logger.debug(
154+
"Latest release with tag:'%s' created_at: %s, published_at: %s",
155+
rls.tag_name,
156+
rls.created_at,
157+
rls.published_at,
158+
)
148159

149160
return rls

release_notes_generator/record/record_factory.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ def create_record_for_issue(r: Repository, i: Issue) -> None:
6868
@return: None
6969
"""
7070
# check for skip labels presence and skip when detected
71-
issue_labels = [label.name for label in issue.labels]
71+
issue_labels = [label.name for label in i.labels]
7272
skip_record = any(item in issue_labels for item in ActionInputs.get_skip_release_notes_labels())
7373
records[i.number] = Record(r, i, skip=skip_record)
7474

release_notes_generator/utils/pull_reuqest_utils.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@
1414
# limitations under the License.
1515
#
1616

17+
"""
18+
This module contains the main script for the Release Notes Generator GH Action.
19+
"""
20+
1721
import re
1822

1923
from github.PullRequest import PullRequest

0 commit comments

Comments
 (0)