Skip to content

Commit 97eb642

Browse files
committed
Review notes fixes.
1 parent bcebd0c commit 97eb642

File tree

2 files changed

+5
-13
lines changed

2 files changed

+5
-13
lines changed

release_notes_generator/model/issue_record.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -273,17 +273,18 @@ def _get_rls_notes_code_rabbit(
273273
continue
274274

275275
if inside_section:
276-
# Check if this is a bold group heading
277-
if line[0] in line_marks and "**" in stripped:
276+
# Check if this is a bold group heading, e.g.
277+
first_char = stripped[0]
278+
if first_char in line_marks and "**" in stripped:
278279
# Group heading – check if it should be skipped
279280
group_name = stripped.split("**")[1]
280281
skipping_group = any(group.lower() == group_name.lower() for group in ignore_groups)
281282
continue
282283

283-
if skipping_group and line.startswith(" - "):
284+
if skipping_group and any(line.startswith(f" {ch} ") for ch in line_marks):
284285
continue
285286

286-
if stripped[0] in line_marks and line.startswith(" - "):
287+
if first_char in line_marks and any(line.startswith(f" {ch} ") for ch in line_marks):
287288
release_notes_lines.append(line.rstrip())
288289
else:
289290
break

release_notes_generator/model/pull_request_record.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -164,15 +164,6 @@ def get_commit(self, sha: str = "0") -> Optional[Commit]:
164164
return self._commits[sha]
165165
return None
166166

167-
# def register_issue(self, issue: Issue) -> None:
168-
# """
169-
# Registers an Issue associated with the Pull Request.
170-
# Parameters:
171-
# issue (Issue): The issue to register.
172-
# Returns: None
173-
# """
174-
# self._issues[issue.number] = issue
175-
176167
def register_commit(self, commit: Commit) -> None:
177168
"""
178169
Registers a Commit associated with the Pull Request.

0 commit comments

Comments
 (0)