Skip to content

Commit 08fcdae

Browse files
Upgrade testcontainers (#192)
* Upgrade testcontainers * Remove commented config
1 parent 3c67020 commit 08fcdae

File tree

4 files changed

+11
-16
lines changed

4 files changed

+11
-16
lines changed

driver/src/test/scala/za/co/absa/hyperdrive/driver/drivers/KafkaSchemaRegistryWrapper.scala

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,9 @@ import java.util.Properties
2020
import org.apache.kafka.clients.consumer.KafkaConsumer
2121
import org.apache.kafka.clients.producer.KafkaProducer
2222
import org.apache.logging.log4j.LogManager
23-
import org.testcontainers.containers.{GenericContainer, KafkaContainer, Network}
2423
import org.testcontainers.containers.wait.strategy.Wait
24+
import org.testcontainers.containers.{GenericContainer, KafkaContainer, Network}
25+
import org.testcontainers.utility.DockerImageName
2526

2627
case class SchemaRegistryContainer(dockerImageName: String) extends GenericContainer[SchemaRegistryContainer](dockerImageName)
2728

@@ -37,7 +38,8 @@ class KafkaSchemaRegistryWrapper {
3738
logger.info(s"Created network with id ${commonNetwork.getId}")
3839

3940
private def startKafka(network: Network): KafkaContainer = {
40-
val kafka = new KafkaContainer(confluentPlatformVersion).withNetwork(network)
41+
val kafka = new KafkaContainer(DockerImageName.parse(s"confluentinc/cp-kafka:$confluentPlatformVersion"))
42+
.withNetwork(network)
4143
kafka.start()
4244
kafka
4345
}

hyperdrive-release/pom.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,10 @@
5151
<pattern>org.apache.commons.beanutils</pattern>
5252
<shadedPattern>org.apache.shaded.commons.beanutils</shadedPattern>
5353
</relocation>
54+
<relocation>
55+
<pattern>com.fasterxml.jackson</pattern>
56+
<shadedPattern>com.fasterxml.shaded.jackson</shadedPattern>
57+
</relocation>
5458
</relocations>
5559
<transformers>
5660
<transformer implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">

ingestor-default/src/test/scala/za/co/absa/hyperdrive/ingestor/implementation/utils/TestKafkaUtilDockerTest.scala

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,14 @@ import org.apache.kafka.common.TopicPartition
2727
import org.apache.kafka.common.serialization.{StringDeserializer, StringSerializer}
2828
import org.scalatest.{AppendedClues, BeforeAndAfter, FlatSpec, Matchers}
2929
import org.testcontainers.containers.KafkaContainer
30+
import org.testcontainers.utility.DockerImageName
3031

3132
import scala.collection.JavaConverters._
3233
import scala.collection.mutable
3334
class TestKafkaUtilDockerTest extends FlatSpec with Matchers with BeforeAndAfter with AppendedClues {
3435

3536
private val confluentPlatformVersion = "5.3.4" // should be same as kafka.avro.serializer.version property in pom file
36-
private val kafka = new KafkaContainer(confluentPlatformVersion)
37+
private val kafka = new KafkaContainer(DockerImageName.parse(s"confluentinc/cp-kafka:$confluentPlatformVersion"))
3738
private val kafkaSufficientTimeout = Duration.ofSeconds(5L)
3839
private val kafkaInsufficientTimeout = Duration.ofMillis(1L)
3940
private val topic = "test-topic"

parent-conf/pom.xml

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939

4040
<properties>
4141
<!--Enforced versions-->
42-
<fasterxml.jackson.databind.version>2.6.7.1</fasterxml.jackson.databind.version> <!--Same as Spark uses-->
4342
<avro.version>1.8.2</avro.version> <!--Same as Abris uses-->
4443

4544
<!--Maven-->
@@ -65,7 +64,7 @@
6564
<kafka.spark.version>0-10</kafka.spark.version>
6665
<spark.sql.kafka.version>2.4.3</spark.sql.kafka.version>
6766
<spark.sql.mongo.version>2.4.2</spark.sql.mongo.version>
68-
<testcontainers.kafka.version>1.12.4</testcontainers.kafka.version>
67+
<testcontainers.kafka.version>1.15.1</testcontainers.kafka.version>
6968
<kafka.avro.serializer.version>5.3.4</kafka.avro.serializer.version> <!--Same as Abris uses-->
7069

7170
<!--Spark-->
@@ -96,11 +95,6 @@
9695

9796
<dependencies>
9897
<!--Enforced dependency versions-->
99-
<!--Jackson Databind-->
100-
<dependency>
101-
<groupId>com.fasterxml.jackson.core</groupId>
102-
<artifactId>jackson-databind</artifactId>
103-
</dependency>
10498
<!--Avro-->
10599
<dependency>
106100
<groupId>org.apache.avro</groupId>
@@ -162,12 +156,6 @@
162156

163157
<dependencies>
164158
<!--Enforced dependency versions-->
165-
<!--Jackson Databind-->
166-
<dependency>
167-
<groupId>com.fasterxml.jackson.core</groupId>
168-
<artifactId>jackson-databind</artifactId>
169-
<version>${fasterxml.jackson.databind.version}</version>
170-
</dependency>
171159
<!--Avro-->
172160
<dependency>
173161
<groupId>org.apache.avro</groupId>

0 commit comments

Comments
 (0)