Arimaa: Setup is always complete 0, never 1

Author: Perlkonig

src/games/arimaa.ts

@@ -645,14 +645,14 @@ export class ArimaaGame extends GameBase {
                     if (this.currplayer === 2) {
                         const [e1, e2] = [...cloned.board.entries()].filter(e => e[1][0] === "E").map(e => e[0][0]);
                         if (e1 === e2) {
-                            warnings.push(i18next.t("apgames:validation.arimaa.WARN_FILE"));
+                            warnings.push(i18next.t("apgames:validation.arimaa.WARN_FILE") || "WARN");
                         }
                     }
                     // unbalanced (gold and silver)
                     const majors = [...cloned.board.entries()].filter(e => e[1][1] === this.currplayer && ["E", "M", "H"].includes(e[1][0])).map(e => ArimaaGame.algebraic2coords(e[0])[0]);
                     const oneSide = majors.filter(n => n < 5).length;
                     if (oneSide === 0 || oneSide === 4) {
-                        warnings.push(i18next.t("apgames:validation.arimaa.WARN_BALANCE"));
+                        warnings.push(i18next.t("apgames:validation.arimaa.WARN_BALANCE") || "WARN");
                     }
                     // hiding (gold and silver)
                     const frontRow = this.currplayer === 1 ? 6 : 1;
@@ -664,7 +664,7 @@ export class ArimaaGame extends GameBase {
                         const back = cloned.board.get(backCell)![0];
                         if (ArimaaGame.strength(front) < ArimaaGame.strength(back)) {
                             if (front !== "R" && back !== "C") {
-                                warnings.push(i18next.t("apgames:validation.arimaa.WARN_HIDE"));
+                                warnings.push(i18next.t("apgames:validation.arimaa.WARN_HIDE") || "WARN");
                                 break;
                             }
                         }
@@ -673,7 +673,8 @@ export class ArimaaGame extends GameBase {
                         complete = 0;
                         message = [i18next.t("apgames:validation.arimaa.WARNINGS"), ...warnings].join(" ");
                     } else {
-                        complete = 1;
+                        // complete is never 1 for setup
+                        complete = 0;
                         message = i18next.t("apgames:validation._general.VALID_MOVE")
                     }
                 }

test/games/arimaa.test.ts

@@ -72,18 +72,18 @@ describe("Arimaa", () => {
         g.move("Ee2,Md2,Hb2,Hg2,Ra2,Ra1,Rb1,Rc1,Rf1,Rg1,Rh1,Rh2,Cf2,Cc2,Dd1,De1");
         // no warnings
         let result = g.validateMove("me7,ed7,hb7,hg7,ra7,ra8,rb8,rc8,rf8,rg8,rh8,rh7,cf7,de8,cd8,dc7");
-        expect(result.complete).to.equal(1);
+        expect(result.message).to.be.undefined;
         // same file
         result = g.validateMove("ee7,md7,hb7,hg7,ra7,ra8,rb8,rc8,rf8,rg8,rh8,rh7,cf7,de8,cd8,dc7");
-        expect(result.complete).to.equal(0);
+        expect(result.message).to.equal(" WARN");
         // unbalanced
         result = g.validateMove("ea7,mb7,hc7,hd7,ce7,df7,dg7,ch7,ra8,rb8,rc8,rd8,re8,rf8,rg8,rh8");
-        expect(result.complete).to.equal(0);
+        expect(result.message).to.equal(" WARN");
         // hiding
         result = g.validateMove("ed7,me7,hb7,hg7,ra7,ra8,rb8,rc8,rg8,rh8,rh7,cf8,rf7,cd8,de8,dc7");
-        expect(result.complete).to.equal(1);
+        expect(result.message).to.be.undefined;
         result = g.validateMove("ed7,hb7,hg7,ra7,ra8,rb8,rc8,rf8,rg8,rh8,rh7,cf7,ce7,dc7,dd8,me8");
-        expect(result.complete).to.equal(0);
+        expect(result.message).to.equal(" WARN");
     });
 });