mpl:

  1. Remove unused argument
  2. Improve comments
  3. Adpt function name
  4. TO DOs clean up

Signed-off-by: Arthur Koucher <[email protected]>

Author: AcKoucher

src/mpl/src/SimulatedAnnealingCore.cpp

@@ -291,7 +291,7 @@ void SimulatedAnnealingCore<T>::calWirelength()
     T& target = macros_[net.terminals.second];
 
     if (target.isClusterOfUnconstrainedIOPins()) {
-      addClosestAvailableRegionDistToWL(source, target, net.weight);
+      addClosestAvailableRegionDistToWL(source, net.weight);
       continue;
     }
 
@@ -317,7 +317,6 @@ void SimulatedAnnealingCore<T>::calWirelength()
 template <class T>
 void SimulatedAnnealingCore<T>::addClosestAvailableRegionDistToWL(
     const T& macro,
-    const T& io,
     const float net_weight)
 {
   if (isOutsideTheOutline(macro)) {

src/mpl/src/SimulatedAnnealingCore.h

@@ -135,7 +135,6 @@ class SimulatedAnnealingCore
   void calOutlinePenalty();
   void calWirelength();
   void addClosestAvailableRegionDistToWL(const T& macro,
-                                         const T& io,
                                          float net_weight);
   bool isOutsideTheOutline(const T& macro) const;
   float computeDistance(const Point& a, const Point& b) const;

src/mpl/src/clusterEngine.h

@@ -114,7 +114,6 @@ struct PhysicalHierarchy
   PhysicalHierarchyMaps maps;
 
   std::vector<Rect> available_regions_for_pins;
-  std::set<Boundary> unblocked_boundaries;  // TODO: remove
 
   float halo_width{0.0f};
   float halo_height{0.0f};

src/mpl/src/graphics.cpp

@@ -519,7 +519,7 @@ void Graphics::drawObjects(gui::Painter& painter)
     }
   }
 
-  drawBlockedBoundariesIndication(painter);
+  drawBlockedRegionsIndication(painter);
 
   painter.setBrush(gui::Painter::transparent);
   if (only_final_result_) {
@@ -565,7 +565,7 @@ void Graphics::drawGuides(gui::Painter& painter)
   }
 }
 
-void Graphics::drawBlockedBoundariesIndication(gui::Painter& painter)
+void Graphics::drawBlockedRegionsIndication(gui::Painter& painter)
 {
   painter.setPen(gui::Painter::red, true);
   painter.setBrush(gui::Painter::transparent);

src/mpl/src/graphics.h

@@ -101,7 +101,7 @@ class Graphics : public gui::Renderer, public MplObserver
   void setXMarksSize();
   void resetPenalties();
   void drawCluster(Cluster* cluster, gui::Painter& painter);
-  void drawBlockedBoundariesIndication(gui::Painter& painter);
+  void drawBlockedRegionsIndication(gui::Painter& painter);
   void drawAllBlockages(gui::Painter& painter);
   void drawOffsetRect(const Rect& rect,
                       const std::string& center_text,

src/mpl/src/hier_rtlmp.cpp

@@ -896,9 +896,10 @@ void HierRTLMP::createPinAccessBlockages()
 
     if (blocked_regions_for_pins.empty()) {
       // If there are no constraints at all, we give freedom to SA so it
-      // doesn't have to deal with pin access blockages in all boundaries.
-      // This will help SA not relying on extreme utilizations to
-      // converge for designs such as sky130hd/uW.
+      // doesn't have to deal with pin access blockages across the entire
+      // extension of all edges of the die area. This should help SA not
+      // relying on extreme utilizations to converge for designs such as
+      // sky130hd/uW.
       return;
     }