Implement support for viewing rules.

Signed-off-by: Thomas Mansencal <[email protected]>

Author: KelSolaar

opencolorio_config_aces/config/generation/common.py

@@ -409,8 +409,7 @@ def generate_config(
 
     if data.file_rules:
         file_rules = ocio.FileRules()
-        rule_index = 0
-        for file_rule in reversed(data.file_rules):
+        for i, file_rule in enumerate(data.file_rules):
             name = file_rule["name"]
             colorspace = file_rule["colorspace"]
             regex = file_rule.get("regex")
@@ -431,8 +430,7 @@ def generate_config(
                     regex,
                     colorspace,
                 )
-                file_rules.insertRule(rule_index, name, colorspace, regex)
-                rule_index += 1
+                file_rules.insertRule(i, name, colorspace, regex)
             else:
                 LOGGER.debug(
                     'Adding "%s" file rule with "%s" pattern and "%s" '
@@ -442,15 +440,20 @@ def generate_config(
                     extension,
                     colorspace,
                 )
-                file_rules.insertRule(rule_index, name, colorspace, pattern, extension)
-                rule_index += 1
+                file_rules.insertRule(i, name, colorspace, pattern, extension)
         config.setFileRules(file_rules)
 
     if data.viewing_rules:
         viewing_rules = ocio.ViewingRules()
-        for _i, _viewing_rule in enumerate(reversed(data.viewing_rules)):
-            LOGGER.warning("Inserting a viewing rule is not supported yet!")
-            # viewing_rules.insertRule()
+        for i, viewing_rule in enumerate(data.viewing_rules):
+            name = viewing_rule["name"]
+            encodings = viewing_rule["encodings"]
+            LOGGER.debug(
+                'Adding "%s" viewing rule with "%s" encodings.', name, encodings
+            )
+            viewing_rules.insertRule(i, name)
+            for encoding in encodings:
+                viewing_rules.addEncoding(i, encoding)
         config.setViewingRules(viewing_rules)
 
     if data.default_view_transform is not None:

opencolorio_config_aces/config/reference/generate/config.py

@@ -916,6 +916,7 @@ def generate_config_aces(
                 "builtin_transform_style",
                 "linked_display_colorspace_style",
                 "interface",
+                "viewing_rule",
                 "encoding",
                 "categories",
                 "aliases",
@@ -1121,6 +1122,7 @@ def generate_config_aces(
                 "display": display_name,
                 "view": view_transform_name,
                 "view_transform": view_transform_name,
+                "rule": transform_data["viewing_rule"],
             }
             if shared_view not in shared_views:
                 LOGGER.info(
@@ -1239,12 +1241,42 @@ def ordering(element: str) -> int:
             "transform_type": "BuiltinTransform",
             "style": "UTILITY - ACES-AP0_to_CIE-XYZ-D65_BFD",
         },
+        "rule": "Any Scene-linear or Log",
     }
+
+    video_view_transform = {
+        "name": "Video (colorimetric)",
+        "from_reference": {
+            "transform_type": "MatrixTransform",
+            "matrix": [
+                1.0000000000,
+                0.0000000000,
+                0.0000000000,
+                0.0000000000,
+                0.0000000000,
+                1.0000000000,
+                0.0000000000,
+                0.0000000000,
+                0.0000000000,
+                0.0000000000,
+                1.0000000000,
+                0.0000000000,
+                0.0000000000,
+                0.0000000000,
+                0.0000000000,
+                1.0000000000,
+            ],
+        },
+        "reference_space": ocio.REFERENCE_SPACE_DISPLAY,
+        "rule": "Any Video",
+    }
+
     for display_name in display_names:
         untonemapped_shared_view = {
             "display": display_name,
             "view": untonemapped_view_transform["name"],
             "view_transform": untonemapped_view_transform["name"],
+            "rule": untonemapped_view_transform["rule"],
         }
         LOGGER.info(
             'Adding "%s" shared view to "%s" display.',
@@ -1255,6 +1287,21 @@ def ordering(element: str) -> int:
         if untonemapped_shared_view not in shared_views:
             shared_views.append(untonemapped_shared_view)
 
+        video_shared_view = {
+            "display": display_name,
+            "view": video_view_transform["name"],
+            "view_transform": video_view_transform["name"],
+            "rule": video_view_transform["rule"],
+        }
+        LOGGER.info(
+            'Adding "%s" shared view to "%s" display.',
+            video_shared_view["view"],
+            display_name,
+        )
+
+        if video_shared_view not in shared_views:
+            shared_views.append(video_shared_view)
+
         raw_view = {
             "display": display_name,
             "view": "Raw",
@@ -1291,17 +1338,25 @@ def ordering(element: str) -> int:
         },
         colorspaces=colorspaces + displays,
         looks=looks,
-        view_transforms=[*view_transforms, untonemapped_view_transform],
+        view_transforms=[
+            *view_transforms,
+            untonemapped_view_transform,
+            video_view_transform,
+        ],
         shared_views=shared_views,
         views=shared_views + views,
         active_displays=display_names,
-        active_views=[*active_views, "Un-tone-mapped", "Raw"],
+        active_views=[*active_views, "Un-tone-mapped", "Video (colorimetric)", "Raw"],
         file_rules=[
             {
                 "name": "Default",
                 "colorspace": scene_reference_colorspace["name"],
             }
         ],
+        viewing_rules=[
+            {"name": "Any Scene-linear or Log", "encodings": ["log", "scene-linear"]},
+            {"name": "Any Video", "encodings": ["sdr-video", "hdr-video"]},
+        ],
         default_view_transform=untonemapped_view_transform["name"],
         profile_version=build_configuration.ocio,
     )