Skip to content

Commit 8b84503

Browse files
authored
PR: Varnishing (#30)
* Improve "README.rst" file. Closes #26, references #27. Signed-off-by: Thomas Mansencal <[email protected]> * Update various docstrings. Signed-off-by: Thomas Mansencal <[email protected]> * Update "README.rst" file according to code review comments. Signed-off-by: Thomas Mansencal <[email protected]> * Update various docstrings according to code review comments. Signed-off-by: Thomas Mansencal <[email protected]>
1 parent 6523f56 commit 8b84503

File tree

3 files changed

+154
-95
lines changed

3 files changed

+154
-95
lines changed

README.rst

Lines changed: 92 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,87 @@ The following features are available:
2929

3030
- Automatic *OCIO* **Reference** configuration generation for *aces-dev*
3131
*CTL* reference implementation.
32-
- Configurable generator producing the *OCIO* **Studio** configuration.
32+
33+
- Discovery of *aces-dev* *CTL* transforms.
34+
- Generation of the *CTL* transforms graph.
35+
36+
- Configurable generator producing the *OCIO* **CG** and **Studio**
37+
configurations.
38+
- Included *CLF* transforms along with generator and discovery support.
39+
40+
Components Status
41+
^^^^^^^^^^^^^^^^^
42+
43+
+-------------------------------+----------------+----------------------------------------------------------------------------------+
44+
| Component | Status | Notes |
45+
+-------------------------------+----------------+----------------------------------------------------------------------------------+
46+
| *aces-dev* Discovery | Complete | Minor updates might be required when *aces-dev* is updated. |
47+
+-------------------------------+----------------+----------------------------------------------------------------------------------+
48+
| Common Config Generator | Quasi-Complete | Support for *NamedTransform* must be implemented. |
49+
+-------------------------------+----------------+----------------------------------------------------------------------------------+
50+
| *Reference* Config Generation | Complete | |
51+
+-------------------------------+----------------+----------------------------------------------------------------------------------+
52+
| *CG* Config Generation | In-Progress | Relies on *NamedTransform* support and shipped *CLF* transforms completion. |
53+
+-------------------------------+----------------+----------------------------------------------------------------------------------+
54+
| Custom Config Generation | In-Progress | We are designing the components so that one can generate a custom *ACES* config. |
55+
+-------------------------------+----------------+----------------------------------------------------------------------------------+
56+
| *Studio* Config Generation | In-Progress | |
57+
+-------------------------------+----------------+----------------------------------------------------------------------------------+
58+
| *CLF* Transforms Discovery | Complete | Minor updates will be required if classification changes. |
59+
+-------------------------------+----------------+----------------------------------------------------------------------------------+
60+
| *CLF* Transforms Generation | In-Progress | |
61+
+-------------------------------+----------------+----------------------------------------------------------------------------------+
62+
| Public API Surfacing | In-Progress | What is part of the Public API is not well defined currently. |
63+
+-------------------------------+----------------+----------------------------------------------------------------------------------+
64+
| Unit Tests | In-Progress | |
65+
+-------------------------------+----------------+----------------------------------------------------------------------------------+
66+
| API Documentation | In-Progress | |
67+
+-------------------------------+----------------+----------------------------------------------------------------------------------+
68+
| Continuous Integration | Complete | |
69+
+-------------------------------+----------------+----------------------------------------------------------------------------------+
70+
| CLI | In-Progress | |
71+
+-------------------------------+----------------+----------------------------------------------------------------------------------+
72+
| Containerisation | Complete | Minor updates will be required as the CLI evolves. |
73+
+-------------------------------+----------------+----------------------------------------------------------------------------------+
3374

3475
Installation
3576
------------
3677

78+
Cloning the Repository
79+
^^^^^^^^^^^^^^^^^^^^^^
80+
81+
The *OpenColorIO Configuration for ACES* repository uses `Git submodules <https://git-scm.com/book/en/v2/Git-Tools-Submodules>`__
82+
thus cloning the repository requires initializing them::
83+
84+
git clone --recursive https://github.com/AcademySoftwareFoundation/OpenColorIO-Config-ACES.git
85+
86+
If you have already cloned the repository and forgot the `--recursive`
87+
argument, it is possible to initialize the submodules as follows::
88+
89+
git submodule update --init --recursive
90+
91+
Poetry
92+
^^^^^^
93+
94+
The *OpenColorIO Configuration for ACES* repository adopts `Poetry <https://poetry.eustace.io>`__
95+
to help managing its dependencies, this is the recommended way to get started
96+
with development.
97+
98+
Assuming `python>=3.7 <https://www.python.org/download/releases/>`__ is
99+
available on your system along with `OpenColorIO <https://opencolorio.org/>`__,
100+
the development dependencies are installed with `Poetry <https://poetry.eustace.io>`__
101+
as follows::
102+
103+
git clone --recursive https://github.com/AcademySoftwareFoundation/OpenColorIO-Config-ACES.git
104+
cd OpenColorIO-Config-ACES
105+
poetry install --extras "optional"
106+
107+
The *aces-dev* *CTL* reference graph can be plotted but it requires `Graphviz <https://graphviz.org/>`__
108+
to be installed on the system and having installed the optional `pygraphviz <https://pypi.org/project/pygraphviz/>`__:
109+
python package::
110+
111+
poetry install --extras "optional graphviz"
112+
37113
Docker
38114
^^^^^^
39115

@@ -55,7 +131,6 @@ Then, to run *bash* in the container::
55131

56132
docker run -it -v ${PWD}:/home/aswf/OpenColorIO-Config-ACES aswf/opencolorio-config-aces:latest /bin/bash
57133

58-
59134
Pypi
60135
^^^^
61136

@@ -66,13 +141,15 @@ Primary Dependencies
66141
********************
67142

68143
- `python>=3.7 <https://www.python.org/download/releases/>`__
69-
- `networkx <https://pypi.org/project/networkx/>`__
70144
- `OpenColorIO <https://opencolorio.org/>`__
71145

72-
Plotting Dependencies
146+
Optional Dependencies
73147
*********************
74148

149+
- `colour <https://www.colour-science.org/>`__
75150
- `graphviz <https://www.graphviz.org/>`__
151+
- `jsonpickle <https://jsonpickle.github.io/>`__
152+
- `networkx <https://pypi.org/project/networkx/>`__
76153
- `pygraphviz <https://pypi.org/project/pygraphviz/>`__
77154

78155
Development Dependencies
@@ -112,14 +189,22 @@ Listing the tasks is done as follows::
112189

113190
invoke --list
114191

115-
Assuming the dependencies are satisfied, the task to build the reference
192+
Assuming the dependencies are satisfied, the task to build the **Reference**
116193
configuration is::
117194

118-
invoke build-reference-config
195+
invoke build-config-reference
119196

120197
Alternatively, with the docker container built::
121198

122-
invoke docker-run-build-reference-config
199+
invoke docker-run-build-config-reference
200+
201+
Likewise, for the **CG** configuration::
202+
203+
invoke build-config-cg
204+
205+
Or::
206+
207+
invoke docker-run-build-config-cg
123208

124209
API
125210
^^^

0 commit comments

Comments
 (0)