Skip to content

Commit 2941cc5

Browse files
committed
Clarify ACES OT 2.0 edge-case test comments around hue-angle table access bug
Signed-off-by: Kevin Wheatley <[email protected]>
1 parent f774cbe commit 2941cc5

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

tests/cpu/ops/fixedfunction/FixedFunctionOpCPU_tests.cpp

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -592,12 +592,15 @@ OCIO_ADD_TEST(FixedFunctionOpCPU, aces_ot_20_edge_cases)
592592
constexpr int num_channels = 4;
593593
std::array<float, test_cases * num_channels> input_32f = {
594594
0.0f, 0.0f, 0.0f, 1.0f,
595-
0.742242277f, 0.0931933373f, 0.321542144f, 1.0f // Bug #2220: related to hue angle calculation not wrapping
595+
0.742242277f, 0.0931933373f, 0.321542144f, 1.0f // Bug #2220: related to hue angle calculation
596+
// triggering an out of bounds access in the tables
597+
// at exactly 360 degrees
596598
};
597599
constexpr std::array<float, test_cases * num_channels> expected_32f = {
598600
0.0f, 0.0f, 0.0f, 1.0f,
599-
0.74736571311951f, -0.0019352473318577f, 0.19451357424259f, 1.0f, // Note: exact output value is not significant to
600-
// the test as the bug is in the internal logic
601+
0.74736571311951f, -0.0019352473318577f, 0.19451357424259f, 1.0f, // Note: exact output value is not
602+
// significant to the test as the bug
603+
// was in the internal table access logic
601604
};
602605

603606
OCIO::FixedFunctionOpData::Params params = {

0 commit comments

Comments
 (0)