Skip to content

Commit 7360206

Browse files
hodoulpSarcasm
andauthored
CMake: remove duplicate find_package(pybind11 ...) (#1521) (#1523)
This duplicate seems to come from the PR #1371. This PR spanned April 15 - August 24 (2021). Meanwhile, PR #1410 (June 13 - June 21), changed the CMake logic around `find_package(pybind11 ...)`. It looks like former PR mishandled the merge of the latter. Signed-off-by: Guillaume Papin <[email protected]> Co-authored-by: Guillaume Papin <[email protected]>
1 parent 934b808 commit 7360206

File tree

1 file changed

+0
-13
lines changed

1 file changed

+0
-13
lines changed

share/cmake/modules/FindExtPackages.cmake

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -74,19 +74,6 @@ if(OCIO_BUILD_OPENFX)
7474
find_package(openfx 1.4 REQUIRED)
7575
endif()
7676

77-
if(OCIO_BUILD_PYTHON)
78-
79-
# NOTE: Depending of the compiler version pybind11 2.4.3 does not compile
80-
# with C++17 so, if you change the pybind11 version update the code to
81-
# compile pybind11 and dependencies with C++17 or higher i.e. remove the
82-
# cap of C++ version in FindPybind11.cmake and
83-
# src/bindings/python/CMakeLists.txt.
84-
85-
# pybind11
86-
# https://github.com/pybind/pybind11
87-
find_package(pybind11 2.6.1 REQUIRED)
88-
endif()
89-
9077
if (OCIO_PYTHON_VERSION AND NOT OCIO_BUILD_PYTHON)
9178
message (WARNING "OCIO_PYTHON_VERSION=${OCIO_PYTHON_VERSION} but OCIO_BUILD_PYTHON is off.")
9279
endif ()

0 commit comments

Comments
 (0)