Skip to content

Commit de4bc52

Browse files
authored
[cicd] Fix cuegui and cuesubmit dockerfiles (#1618)
Changes on requirements.txt were not compatible with the centos7 image being used on cuegui and cuesubmit release pipelines. The long term goal is to upgrade those images and drop centos7 compatibility.
1 parent e8c211d commit de4bc52

File tree

3 files changed

+50
-46
lines changed

3 files changed

+50
-46
lines changed

cuegui/Dockerfile

Lines changed: 28 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -8,26 +8,26 @@ RUN sed -i s/^#.*baseurl=http/baseurl=http/g /etc/yum.repos.d/CentOS-*.repo
88
RUN sed -i s/^mirrorlist=http/#mirrorlist=http/g /etc/yum.repos.d/CentOS-*.repo
99

1010
RUN yum -y install \
11-
epel-release \
12-
fontconfig \
13-
freetype \
14-
gcc \
15-
libXi \
16-
libXrender \
17-
libxkbcommon-x11.x86_64 \
18-
mesa-libGL \
19-
python-devel \
20-
which \
21-
Xvfb \
22-
xcb-util-image.x86_64 \
23-
xcb-util-keysyms.x86_64 \
24-
xcb-util-renderutil.x86_64 \
25-
xcb-util-wm.x86_64
11+
epel-release \
12+
fontconfig \
13+
freetype \
14+
gcc \
15+
libXi \
16+
libXrender \
17+
libxkbcommon-x11.x86_64 \
18+
mesa-libGL \
19+
python-devel \
20+
which \
21+
Xvfb \
22+
xcb-util-image.x86_64 \
23+
xcb-util-keysyms.x86_64 \
24+
xcb-util-renderutil.x86_64 \
25+
xcb-util-wm.x86_64
2626

2727
RUN yum -y install \
28-
python36 \
29-
python36-devel \
30-
python36-pip
28+
python36 \
29+
python36-devel \
30+
python36-pip
3131

3232
RUN python3.6 -m pip install --upgrade pip
3333
RUN python3.6 -m pip install --upgrade setuptools
@@ -45,16 +45,17 @@ COPY pycue/README.md ./pycue/
4545
COPY pycue/setup.py ./pycue/
4646
COPY pycue/FileSequence ./pycue/FileSequence
4747
COPY pycue/opencue ./pycue/opencue
48+
COPY ci/fix_compiled_proto.py .
4849

4950
RUN python3.6 -m grpc_tools.protoc \
50-
-I=./proto \
51-
--python_out=./pycue/opencue/compiled_proto \
52-
--grpc_python_out=./pycue/opencue/compiled_proto \
53-
./proto/*.proto
51+
-I=./proto \
52+
--python_out=./pycue/opencue/compiled_proto \
53+
--grpc_python_out=./pycue/opencue/compiled_proto \
54+
./proto/*.proto
5455

5556
# Fix imports to work in both Python 2 and 3. See
5657
# <https://github.com/protocolbuffers/protobuf/issues/1491> for more info.
57-
RUN python3 ci/fix_compiled_proto.py pycue/opencue/compiled_proto
58+
RUN python3 ./fix_compiled_proto.py pycue/opencue/compiled_proto
5859

5960
COPY cuegui/README.md ./cuegui/
6061
COPY cuegui/setup.py ./cuegui/
@@ -71,7 +72,7 @@ RUN cd cuegui && xvfb-run -d python3.6 setup.py test
7172
RUN cp LICENSE requirements.txt requirements_gui.txt VERSION cuegui/
7273

7374
RUN versioned_name="cuegui-$(cat ./VERSION)-all" \
74-
&& mv cuegui "${versioned_name}" \
75-
&& tar -cvzf "${versioned_name}.tar.gz" ${versioned_name}/* \
76-
&& mkdir -p /opt/opencue \
77-
&& cp "${versioned_name}.tar.gz" /opt/opencue/
75+
&& mv cuegui "${versioned_name}" \
76+
&& tar -cvzf "${versioned_name}.tar.gz" ${versioned_name}/* \
77+
&& mkdir -p /opt/opencue \
78+
&& cp "${versioned_name}.tar.gz" /opt/opencue/

cuesubmit/Dockerfile

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,15 @@ RUN sed -i s/^#.*baseurl=http/baseurl=http/g /etc/yum.repos.d/CentOS-*.repo
88
RUN sed -i s/^mirrorlist=http/#mirrorlist=http/g /etc/yum.repos.d/CentOS-*.repo
99

1010
RUN yum -y install \
11-
epel-release \
12-
gcc \
13-
mesa-libGL \
14-
python-devel
11+
epel-release \
12+
gcc \
13+
mesa-libGL \
14+
python-devel
1515

1616
RUN yum -y install \
17-
python36 \
18-
python36-devel \
19-
python36-pip
17+
python36 \
18+
python36-devel \
19+
python36-pip
2020

2121
RUN python3.6 -m pip install --upgrade pip
2222
RUN python3.6 -m pip install --upgrade setuptools
@@ -32,16 +32,17 @@ COPY pycue/README.md ./pycue/
3232
COPY pycue/setup.py ./pycue/
3333
COPY pycue/opencue ./pycue/opencue
3434
COPY pycue/FileSequence ./pycue/FileSequence
35+
COPY ci/fix_compiled_proto.py .
3536

3637
RUN python3.6 -m grpc_tools.protoc \
37-
-I=./proto \
38-
--python_out=./pycue/opencue/compiled_proto \
39-
--grpc_python_out=./pycue/opencue/compiled_proto \
40-
./proto/*.proto
38+
-I=./proto \
39+
--python_out=./pycue/opencue/compiled_proto \
40+
--grpc_python_out=./pycue/opencue/compiled_proto \
41+
./proto/*.proto
4142

4243
# Fix imports to work in both Python 2 and 3. See
4344
# <https://github.com/protocolbuffers/protobuf/issues/1491> for more info.
44-
RUN python3 ci/fix_compiled_proto.py pycue/opencue/compiled_proto
45+
RUN python3 ./fix_compiled_proto.py pycue/opencue/compiled_proto
4546

4647
COPY pyoutline/README.md ./pyoutline/
4748
COPY pyoutline/setup.py ./pyoutline/
@@ -65,7 +66,7 @@ RUN cd cuesubmit && python3.6 setup.py test
6566
RUN cp LICENSE requirements.txt requirements_gui.txt VERSION cuesubmit/
6667

6768
RUN versioned_name="cuesubmit-$(cat ./VERSION)-all" \
68-
&& mv cuesubmit "${versioned_name}" \
69-
&& tar -cvzf "${versioned_name}.tar.gz" ${versioned_name}/* \
70-
&& mkdir -p /opt/opencue \
71-
&& cp "${versioned_name}.tar.gz" /opt/opencue/
69+
&& mv cuesubmit "${versioned_name}" \
70+
&& tar -cvzf "${versioned_name}.tar.gz" ${versioned_name}/* \
71+
&& mkdir -p /opt/opencue \
72+
&& cp "${versioned_name}.tar.gz" /opt/opencue/

requirements.txt

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,12 @@ pylint==2.15.10;python_version>="3.7"
1414
pynput==1.7.6
1515
PyYAML==5.1
1616
six==1.16.0
17-
pytest==8.3.3
17+
pytest==7.0.1;python_version<"3.7"
18+
pytest==8.3.3;python_version>="3.7"
1819

1920
# Optional requirements
2021
# Sentry support for rqd
2122
sentry-sdk==2.11.0
22-
23-
docker==7.1.0
23+
# Docker support for rqd
24+
docker==5.0.3;python_version<"3.7"
25+
docker==7.1.0;python_version>="3.7"

0 commit comments

Comments
 (0)