Speedup to detect the existence of files on Windows

wingfiring · wingfiring · commit 459508d00ace · 2025-12-10T03:03:33.000-05:00
Signed-off-by: Jackson Sun &lt;jackson.sun@autodesk.com&gt;
diff --git a/src/libutil/filesystem.cpp b/src/libutil/filesystem.cpp
@@ -330,8 +330,15 @@ Filesystem::path_is_absolute(string_view path, bool dot_is_absolute)
 bool
 Filesystem::exists(string_view path) noexcept
 {
+#ifdef _WIN32
+    // filesystem::exists is slow on Windows for network paths, so use the
+    // WinAPI directly
+    return INVALID_FILE_ATTRIBUTES != GetFileAttributesW(Strutil::utf8_to_utf16wstring(path).c_str());
+#else
     error_code ec;
     return filesystem::exists(u8path(path), ec);
+#endif
+
 }
 
 

Original file line number	Diff line number	Diff line change
`@@ -330,8 +330,15 @@ Filesystem::path_is_absolute(string_view path, bool dot_is_absolute)`
`330`	`330`	`bool`
`331`	`331`	`Filesystem::exists(string_view path) noexcept`
`332`	`332`	`{`
	`333`	`+#ifdef _WIN32`
	`334`	`+ // filesystem::exists is slow on Windows for network paths, so use the`
	`335`	`+ // WinAPI directly`
	`336`	`+ return INVALID_FILE_ATTRIBUTES != GetFileAttributesW(Strutil::utf8_to_utf16wstring(path).c_str());`
	`337`	`+#else`
`333`	`338`	`error_code ec;`
`334`	`339`	`return filesystem::exists(u8path(path), ec);`
	`340`	`+#endif`
	`341`	`+`
`335`	`342`	`}`
`336`	`343`
`337`	`344`