Skip to content

Commit 96d40b6

Browse files
committed
build: fix recently broken rpath to restore python wheel building
Also, make the wheel workflow work on pushes or PRs when the branch name containt the substrings "python" or "wheel", even if none of the special files are touched. This means that if you suspect your work might cause a wheel to break even though you're not modifying the python bindings directly, you can ensure that the wheel workflow will run on CI simply by naming your branch to contain one of those words. Signed-off-by: Larry Gritz <[email protected]>
1 parent 1fdc5d0 commit 96d40b6

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

.github/workflows/wheel.yml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,21 +14,26 @@ permissions:
1414
on:
1515
push:
1616
# Workflow run on tags for v3 only, or pre-tagged pushes of release, or
17-
# dev-3.* branches.
17+
# dev-3.* branches. Also if the branch name itself contains the substrings
18+
# 'wheel' or 'python'.
1819
tags:
1920
- v3.*
2021
branches:
2122
- release
2223
- dev-3.*
24+
- "*wheel*"
25+
- "*python*"
2326
pull_request:
24-
# Workflow run on pull_request only when related files change.
27+
# Workflow run on pull_request only when related files change, or when the
28+
# branch name itself contains the substrings 'wheel' or 'python'.
2529
paths:
2630
- .github/workflows/wheel.yml
2731
- pyproject.toml
2832
- src/python/*.py
2933
- src/python/*.h
3034
- src/python/*.cpp
3135
- src/cmake/pythonutils.cmake
36+
- src/cmake/compiler.cmake
3237
schedule:
3338
# Nightly build
3439
- cron: "0 8 * * *"

src/cmake/compiler.cmake

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -691,6 +691,7 @@ else ()
691691
set(BASEPOINT $ORIGIN)
692692
endif()
693693
set (CMAKE_INSTALL_RPATH ${BASEPOINT}
694+
${BASEPOINT}/${CMAKE_INSTALL_LIBDIR}
694695
${BASEPOINT}/../${CMAKE_INSTALL_LIBDIR})
695696
endif ()
696697
# add the automatically determined parts of the RPATH that

0 commit comments

Comments
 (0)