Skip to content

Commit bfa48c8

Browse files
authored
fix(wheels): Ensure python-based builds use maj.min.patch SO versioning (#4634)
Always use patch-specific SO versioning for scikit-build-core-based builds, even when OpenImageIO_SUPPORTED_RELEASE=ON. Fixes #4621 Ensures that Python-based builds only bundle a single copy each of libOpenImageIO and libOpenImageIO_Util shared libraries. ## Tests Previously, `$ uv sync -v --reinstall -Ccmake.define.OpenImageIO_SUPPORTED_RELEASE=1` would bundle both .so.3.0 and .so.3.0.3 copies of libraries when installing to a local virtual environment. With this fix, only .so.3.0.3 copies of libraries are installed. Signed-off-by: Zach Lewis <[email protected]>
1 parent a440e4b commit bfa48c8

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/cmake/compiler.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -617,7 +617,7 @@ set (EXTRA_DSO_LINK_ARGS "" CACHE STRING "Extra command line definitions when bu
617617
###########################################################################
618618
# Set the versioning for shared libraries.
619619
#
620-
if (${PROJECT_NAME}_SUPPORTED_RELEASE)
620+
if (${PROJECT_NAME}_SUPPORTED_RELEASE AND NOT SKBUILD)
621621
# Supported releases guarantee ABI back-compatibility within the release
622622
# family, so SO versioning is major.minor.
623623
set (SOVERSION ${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}

0 commit comments

Comments
 (0)