CY2024 on windows fails due to missing libdeflate library.

[richardssam]

Hi, I'm trying to build CY2024 on windows, but openexr fails to build with an error message:

"C:\OpenRV\_build\cmake\dependencies\RV_DEPS_OPENEXR.vcxproj" (default target) (1) ->
(CustomBuild target) ->
  C:\msys64\mingw64\include\winnt.h(144,1): error C1189: #error:  No supported target architecture. [C:\OpenRV\_build\RV_DEPS_OPENEXR\build\src\lib\OpenEXRCore\OpenEXRCore.vcxproj] [C:\OpenRV\_build\
cmake\dependencies\RV_DEPS_OPENEXR.vcxproj]

Where you can see its looking for mingw64. I think the problem possibly relates to the newer OpenEXR (3.2.4) now needing libdeflate rather than zlib which is still being built by openrv.

The red flag was in a rate.stamp.depend file which had a reference to rate.stamp.depend:C:/msys64/mingw64/lib/cmake/libdeflate/libdeflate-config-version.cmake

which I dont think it should be referencing, this is then pulling in include files from mingw64 which is giving the above error.

My workaround is to use CY2023 values for CY2024 for openexr only, but I think we just need libdeflate.

[richardssam]

Its definitely a mystery why the CI build works though :(

[richardssam]

Openexr will build it if you ask for it. I think what may be happening is that libdeflate exists on windows in the msys environment, but it hasnt been built with Visual studio, so this will force it to be built the same way as everything else.
I'm not clear if we need to do it elsewhere though.

--- a/cmake/dependencies/openexr.cmake
+++ b/cmake/dependencies/openexr.cmake
@@ -170,6 +170,7 @@ LIST(APPEND _configure_options "-DBUILD_TESTING=OFF")
IF(RV_TARGET_WINDOWS)
GET_TARGET_PROPERTY(_zlib_implibpath ZLIB::ZLIB IMPORTED_IMPLIB)
LIST(APPEND _configure_options "-DZLIB_INCLUDE_DIR=${RV_DEPS_ZLIB_INCLUDE_DIR}")

• LIST(APPEND _configure_options "-DOPENEXR_FORCE_INTERNAL_DEFLATE=ON")
  LIST(APPEND _configure_options "-DZLIB_LIBRARY=${_zlib_implibpath}")
  ENDIF()