Any reason channel_select.toggleChannel does not issue an event.reject()?

[wheffner]

We have a custom OCIO implementation and we cannot bind to those same events handled by toggleChannel and receive callbacks.

toggleChannel()

[bernie-laberge]

Hello @wheffner,

I believe that reason why keyboard shortcuts, like key-down--r for example, are not usually associated with an event.reject() in a RV package is that usuall keyboard shortcuts are associated with one specific package = 1 action.

So you could create a PR to add the event.reject() for all the events leading to toggleChannel() (like key-down--r) for example.
I don't see any problem with it.
But this means that two actions will be performed when key-down--r is triggerred by the user if you have an additional package linked to it.
Actually I think 3 actions will be performed if you do so, because RV has a standard channel selection tool that also intercepts the same keyboard shortcut as channel select.

I wonder if this recent commit from @markreidvfx is not doing exactly what you used to do in your custom package to handle the case where OCIO is enabled:
68dc493

[markreidvfx]

Does the same behaviour happen when OCIO is disabled and the channel_select plugin is loaded?

The OCIO updates is intended to eliminate the need for that plugin. If I recall the channel_select plugin was originally a workaround for limitations in the OCIO implementation, which are now addressed by the update.

Is your custom ocio implement custom c++ code or just the user facing menus?

[wheffner]

Hi Mark, We are running on code before the branch for VFX2023. As a consequence, we do not have your fix 68dc493 <68dc493> . We default to using OCIO at the studio. Meanwhile, we have worked around the issue by creating handlers for the corresponding key-up events. I will have to "bite the bullet" and try building a VFX2023 version from main after your commit and see if I can get our plugins to work. Thanks! Wendy Wendy Heffner, Ph.D. Senior Software Engineer Pixar Animation Studios ***@***.***

…

On Mon, Sep 8, 2025 at 6:04 PM Mark Reid ***@***.***> wrote: Does the same behaviour happen when OCIO is disabled and the channel_select plugin is loaded? The OCIO updates is intended to eliminate the need for that plugin. It appears that the plugin was originally a workaround for limitations in OCIO, which are now addressed by the update. Is your custom ocio implement custom c++ code or just the user facing menus? — Reply to this email directly, view it on GitHub <#900 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAQN2YPORZTI53I7HUVJ3UD3RYRRDAVCNFSM6AAAAACF6DYY3GVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTIMZUGU3DQNA> . You are receiving this because you were mentioned.Message ID: <AcademySoftwareFoundation/OpenRV/repo-discussions/900/comments/14345684@ github.com>

[wheffner]

Hi Mark, Sorry, I hit send before I answered your last question. Our custom OCIO implementation replaces the Python code of the RV default OCIO plugin. We are just using the default channel_select plugin as is. Thanks again, Wendy Wendy Heffner, Ph.D. Senior Software Engineer Pixar Animation Studios ***@***.*** On Tue, Sep 9, 2025 at 4:41 PM Wendy Heffner ***@***.***> wrote:

…

Hi Mark, We are running on code before the branch for VFX2023. As a consequence, we do not have your fix 68dc493 <68dc493> . We default to using OCIO at the studio. Meanwhile, we have worked around the issue by creating handlers for the corresponding key-up events. I will have to "bite the bullet" and try building a VFX2023 version from main after your commit and see if I can get our plugins to work. Thanks! Wendy Wendy Heffner, Ph.D. Senior Software Engineer Pixar Animation Studios ***@***.*** On Mon, Sep 8, 2025 at 6:04 PM Mark Reid ***@***.***> wrote: > Does the same behaviour happen when OCIO is disabled and the > channel_select plugin is loaded? > > The OCIO updates is intended to eliminate the need for that plugin. It > appears that the plugin was originally a workaround for limitations in > OCIO, which are now addressed by the update. > > Is your custom ocio implement custom c++ code or just the user facing > menus? > > — > Reply to this email directly, view it on GitHub > <#900 (reply in thread)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAQN2YPORZTI53I7HUVJ3UD3RYRRDAVCNFSM6AAAAACF6DYY3GVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTIMZUGU3DQNA> > . > You are receiving this because you were mentioned.Message ID: > <AcademySoftwareFoundation/OpenRV/repo-discussions/900/comments/14345684@ > github.com> >