fix: batch shading compiler directives were wrong (#2015)

I spotted two places where we used a *nonexistant* OSL_GCCVERSION
macro. This is never defined.

In platform.h, I think it's a simple typo and should be
OSL_GNUC_VERSION, which is the macro we actually use to hold the GCC
version, or 0 if it's not being compiled by GCC.

In wide_opcolor.cpp, it's odder and seems like also a cut-and-paste
error. At the very least it should be OSL_CLANG_VERSION since it's
part of a clause that also tests that clang < 14.0. But upon staring
at it, I can't help but wonder if this spot should *also* have a
clause `OSL_GNUC_VERSION ||` to make this simd loop macro work properly
for GCC, as it did in the other one in platform.h?

And should the one in platform.h include clang, or no?

Signed-off-by: Larry Gritz <[email protected]>

Author: lgritz

src/include/OSL/platform.h

@@ -290,7 +290,7 @@
 
 #define OSL_OMP_SIMD_LOOP(...) OSL_OMP_PRAGMA(omp simd __VA_ARGS__)
 
-#if (OSL_GCCVERSION || OSL_INTEL_CLASSIC_COMPILER_VERSION || OSL_INTEL_LLVM_COMPILER_VERSION)
+#if (OSL_GNUC_VERSION || OSL_INTEL_CLASSIC_COMPILER_VERSION || OSL_INTEL_LLVM_COMPILER_VERSION)
 #   define OSL_OMP_COMPLEX_SIMD_LOOP(...) OSL_OMP_SIMD_LOOP(__VA_ARGS__)
 #else
     // Ignore requests to vectorize complex/nested SIMD loops for certain

src/liboslexec/wide/wide_opcolor.cpp

@@ -296,7 +296,7 @@ __OSL_MASKED_OP2(prepend_color_from, Wv, Ws)(void* bsg_, void* c_, void* from_,
 namespace {
 
 // Note: Clang 14 seems to no longer allow vectorizing these loops
-#if ((OSL_GCCVERSION && OSL_CLANG_VERSION < 140000) \
+#if ((OSL_CLANG_VERSION && OSL_CLANG_VERSION < 140000) \
      || OSL_INTEL_CLASSIC_COMPILER_VERSION || OSL_INTEL_LLVM_COMPILER_VERSION)
 #    define WIDE_TRANSFORMC_OMP_SIMD_LOOP(...) OSL_OMP_SIMD_LOOP(__VA_ARGS__)
 #else