Skip to content

Commit 3317350

Browse files
authored
fix: Link error on Windows due to shared symbols (#1918)
After reduction of shared dependencies in #1890, there is an unresolved OSLCompiler constructor symbol when linking liboslexec. Avoid including the oslcomp_pvt.h header that causes this. Signed-off-by: Brecht Van Lommel <[email protected]>
1 parent 016a468 commit 3317350

File tree

5 files changed

+2
-5
lines changed

5 files changed

+2
-5
lines changed

src/liboslcomp/symtab.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55
#include <string>
66
#include <vector>
77

8-
#include "oslcomp_pvt.h"
8+
#include "osl_pvt.h"
9+
#include "symtab.h"
910

1011
#include <OpenImageIO/strutil.h>
1112
namespace Strutil = OIIO::Strutil;

src/liboslexec/batched_llvm_instance.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
#include <llvm/IR/Constant.h>
2828
#include <llvm/IR/DerivedTypes.h>
2929

30-
#include "../liboslcomp/oslcomp_pvt.h"
3130
#include "batched_backendllvm.h"
3231
#include "oslexec_pvt.h"
3332

src/liboslexec/llvm_instance.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
#include <OpenImageIO/sysutil.h>
1919
#include <OpenImageIO/timer.h>
2020

21-
#include "../liboslcomp/oslcomp_pvt.h"
2221
#include "oslexec_pvt.h"
2322
#include "backendllvm.h"
2423

src/liboslexec/master.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
#include <OpenImageIO/strutil.h>
1212
#include <OpenImageIO/thread.h>
1313

14-
#include "../liboslcomp/oslcomp_pvt.h"
1514
#include "oslexec_pvt.h"
1615

1716

src/liboslexec/runtimeoptimize.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
#include <OpenImageIO/thread.h>
1111
#include <OpenImageIO/timer.h>
1212

13-
#include "../liboslcomp/oslcomp_pvt.h"
1413
#include "batched_analysis.h"
1514
#include "oslexec_pvt.h"
1615
#include "runtimeoptimize.h"

0 commit comments

Comments
 (0)