fix: anisotropic_vdf closure should not set IOR (#1870)

fpsunflower · lgritz · commit 90dee2a80b67 · 2024-09-24T16:54:24.000-07:00
The MaterialX team noticed this issue here: AcademySoftwareFoundation/MaterialX#2016 Basically, if you add a medium through the anisotropic_vdf closure, it should not force the ior back to 1.0 as this IOR might have been changed by one of the microfacet closures. The IOR already defaults to 1.0 so cases that do not involve a microfacet closure are not affected. Signed-off-by: Chris Kulla <ckulla@gmail.com>
diff --git a/src/testrender/shading.cpp b/src/testrender/shading.cpp
@@ -1542,8 +1542,6 @@ process_medium_closure(const OSL::ShaderGlobals& sg, ShadingResult& result,
         result.sigma_t               = cw * params.extinction;
         result.sigma_s               = params.albedo * result.sigma_t;
         result.medium_g              = params.anisotropy;
-        result.refraction_ior        = 1.0f;
-        result.priority = 0;  // TODO: should this closure have a priority?
         break;
     }
     case MX_MEDIUM_VDF_ID: {

Original file line number	Diff line number	Diff line change
`@@ -1542,8 +1542,6 @@ process_medium_closure(const OSL::ShaderGlobals& sg, ShadingResult& result,`
`1542`	`1542`	`result.sigma_t = cw * params.extinction;`
`1543`	`1543`	`result.sigma_s = params.albedo * result.sigma_t;`
`1544`	`1544`	`result.medium_g = params.anisotropy;`
`1545`		`- result.refraction_ior = 1.0f;`
`1546`		`- result.priority = 0; // TODO: should this closure have a priority?`
`1547`	`1545`	`break;`
`1548`	`1546`	`}`
`1549`	`1547`	`case MX_MEDIUM_VDF_ID: {`