ci: Fix change deprecated sonarqube action, improve run conditions

Swap out deprecated sonar related action for the new one.

Also make some tweaks to the analysis workflow run conditions.

Signed-off-by: Larry Gritz <[email protected]>

Author: lgritz

.github/workflows/analysis.yml

@@ -14,10 +14,24 @@ on:
     branches:
       - main
       - '*analysis*'
-    paths-ignore:
-      - '**.md'
-      - '**.rst'
-      - '**.tex'
+      - '*sonar*'
+    paths:
+      - '**'
+      - '!**.md'
+      - '!**.rst'
+      - '!**/ci.yml'
+      - '!**/docs.yml'
+      - '!**/scorecard.yml'
+      - '!**/wheel.yml'
+      - '!**.properties'
+      - '!docs/**'
+  # Run analysis on PRs only if the branch name indicates that the purpose of
+  # the PR is related to the Sonar analysis. We don't run on every PR because
+  # the analysis run is very expensive and just isn't usually necessary.
+  pull_request:
+    branches:
+      - '*analysis*'
+      - '*sonar*'
   # Allow manual kicking off of the workflow from github.com
   workflow_dispatch:
 

.github/workflows/build-steps.yml

@@ -163,7 +163,7 @@ jobs:
             fi
       - name:  Install sonar-scanner and build-wrapper
         if: inputs.sonar == '1'
-        uses: sonarsource/sonarcloud-github-c-cpp@e4882e1621ad2fb48dddfa48287411bed34789b1 # v2.0.2
+        uses: sonarsource/sonarqube-scan-action@fd88b7d7ccbaefd23d8f36f73b59db7a3d246602 # v6.0.0
       - name: Build
         if: inputs.skip_build != '1'
         shell: bash