Skip to content

Commit c59d74f

Browse files
lgritzbrechtvl
andcommitted
build: Bump Cuda minimum to 9.0 (#1737)
Based on Brecht's tests, we realize that OSL doesn't work at all with Cuda 8.0 (which didn't support the C++14 that we use), so we're raising the minimum to 9.0. And there are some flaky tests with 9 and 10, so we're making the recommended minimum be 11.0. It's not our policy to change the minimum versions of dependencies on release branches, but I think we should backport this to the release branch. I believe what this change is doing is not removing actual support for old versions, but rather, correctly documenting what has been working (or not) for quite some time. --------- Signed-off-by: Larry Gritz <[email protected]> Co-authored-by: Brecht Van Lommel <[email protected]>
1 parent facfe0b commit c59d74f

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

INSTALL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ NEW or CHANGED dependencies since the last major release are **bold**.
4545
on the OSL side to be compatible.
4646

4747
* (optional) For GPU rendering on NVIDIA GPUs:
48-
* [Cuda](https://developer.nvidia.com/cuda-downloads) 8.0 or higher.
48+
* [Cuda](https://developer.nvidia.com/cuda-downloads) 9.0 or higher.
4949
* [OptiX](https://developer.nvidia.com/rtx/ray-tracing/optix) 5.1 or higher
5050
(though 7.0+ is highly recommended).
5151

src/cmake/externalpackages.cmake

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,8 +192,11 @@ if (USE_CUDA OR USE_OPTIX)
192192
endif ()
193193

194194
checked_find_package (CUDA REQUIRED
195-
VERSION_MIN 8.0
196-
PRINT CUDA_INCLUDES)
195+
VERSION_MIN 9.0
196+
RECOMMEND_MIN 11.0
197+
RECOMMEND_MIN_REASON
198+
"We don't actively test CUDA older than 11"
199+
PRINT CUDA_INCLUDES)
197200
set (CUDA_INCLUDES ${CUDA_TOOLKIT_ROOT_DIR}/include)
198201
include_directories (BEFORE "${CUDA_INCLUDES}")
199202

0 commit comments

Comments
 (0)