build: Fix compilation with ld.lld by AngryLoki · Pull Request #2094 · AcademySoftwareFoundation/OpenShadingLanguage

AngryLoki · 2026-03-19T13:50:50Z

Description

When using Clang 18<->22 with ld.lld, build fails with:

clang++ -Wl,--version-script=.../hidesymbols.map -o lib/liboslcomp.so.1.13.7 ...
ld.lld: error: version script assignment of 'global' to symbol 'test_shade' failed: symbol not defined

The issue is that test_shade does not belong to liboslcomp, instead it belongs to libtestshade, and ld.lld actually checks that and fails. The minimal fix is to remove test_shade from hidesymbols.map, the slightly better way is to create a separate symbols map for libtestshade.

See also: https://bugs.gentoo.org/929091

Tests

Not required.

Checklist:

I have read the contribution guidelines.
I have updated the documentation, if applicable.
I have ensured that the change is tested somewhere in the testsuite (adding new test cases if necessary).
My code follows the prevailing code style of this project. If I haven't
already run clang-format v17 before submitting, I definitely will look at
the CI test that runs clang-format and fix anything that it highlights as
being nonconforming.

linux-foundation-easycla · 2026-03-19T13:50:57Z

The committers listed above are authorized under a signed CLA.

✅ login: AngryLoki / name: Sv. Lockal (58abd4d)

lgritz · 2026-03-19T16:10:14Z

src/testshade/CMakeLists.txt

+        set_property (TARGET libtestshade
+                      APPEND PROPERTY LINK_FLAGS
+                      -Wl,--version-script=${CMAKE_CURRENT_SOURCE_DIR}/testshade_symbols.map)
+    endif ()


I was expecting this to fail on Windows, but it didn't. What's going on? Is cmake smart enough to know that that these linker flags only apply to some platforms and don't put them on the link line elsewher?

The only place where VISIBILITY_MAP_COMMAND is defined is:

OpenShadingLanguage/src/cmake/compiler.cmake

Lines 135 to 142 in a2a7fb4

if (${CMAKE_CXX_VISIBILITY_PRESET} STREQUAL "hidden" AND VISIBILITY_MAP_FILE AND

(CMAKE_COMPILER_IS_GNUCC OR CMAKE_COMPILER_IS_CLANG) AND

(CMAKE_SYSTEM_NAME MATCHES "Linux|kFreeBSD" OR CMAKE_SYSTEM_NAME STREQUAL "GNU"))

# Linux/FreeBSD/Hurd: also hide all the symbols of dependent libraries

# to prevent clashes if an app using this project is linked against

# other versions of our dependencies.

set (VISIBILITY_MAP_COMMAND "-Wl,--version-script=${VISIBILITY_MAP_FILE}")

endif ()

Which is Linux/FreeBSD/Hurd, not even Cygwin/mingw.

Ah, I see! So the if (VISIBILITY_MAP_COMMAND) is already implicitly guarding by platform. Great.

lgritz · 2026-03-19T16:14:23Z

You will need a DCO sign-off. The easiest way to do that is:

git commit --amend -s
git push origin ld-lld --force

We're experiencing a couple spuriously failing CI jobs which are not related to your changes (you can tell because they fail while setting up dependencies, not while building OSL itself). We won't let that hold up merging this PR if everything else is ok.

When using Clang 18<->22 with ld.lld, build fails with: ``` clang++ -Wl,--version-script=.../hidesymbols.map -o lib/liboslcomp.so.1.13.7 ... ld.lld: error: version script assignment of 'global' to symbol 'test_shade' failed: symbol not defined ``` The issue is that test_shade does not belong to liboslcomp, instead it belongs to libtestshade, and ld.lld actually checks that and fails. The minimal fix is to remove test_shade from hidesymbols.map, the slightly better way is to create a separate symbols map for libtestshade. See also: https://bugs.gentoo.org/929091 Signed-off-by: Sv. Lockal <lockalsash@gmail.com>

AngryLoki · 2026-03-19T18:26:36Z

git commit --amend -s

Done

lgritz

LGTM, thanks for the fix

When using Clang 18<->22 with ld.lld, build fails with: ``` clang++ -Wl,--version-script=.../hidesymbols.map -o lib/liboslcomp.so.1.13.7 ... ld.lld: error: version script assignment of 'global' to symbol 'test_shade' failed: symbol not defined ``` The issue is that test_shade does not belong to liboslcomp, instead it belongs to libtestshade, and ld.lld actually checks that and fails. The minimal fix is to remove test_shade from hidesymbols.map, the slightly better way is to create a separate symbols map for libtestshade. See also: https://bugs.gentoo.org/929091 Signed-off-by: Sv. Lockal <lockalsash@gmail.com>

Release 1.15.3.0 (1 Apr 2026) -- compared to 1.15.2.0 --------------------------------------------------------- - *bsdl*: Incorporate diffuse MaterialX BSDFs into BSDL library [AcademySoftwareFoundation#2092](AcademySoftwareFoundation#2092) (by Alejandro Conty) - *build*: Fix compilation with ld.lld [AcademySoftwareFoundation#2094](AcademySoftwareFoundation#2094) (by Sv. Lockal) (1.15.3.0, 1.14.10.0) - *ci*: Add Windows 2025 with MSVS 2026 job variant to CI [AcademySoftwareFoundation#2093](AcademySoftwareFoundation#2093) (1.15.3.0, 1.14.10.0) - *ci*: For security, replace some workflow substitutions with safer env substitutions [AcademySoftwareFoundation#2088](AcademySoftwareFoundation#2088) (1.15.3.0, 1.14.10.0) - *ci*: Some minor LLVM dependency improvements [AcademySoftwareFoundation#2090](AcademySoftwareFoundation#2090) - *ci*: Various fixes for unexpected CI runner breakages: fmt/OIIO main build [AcademySoftwareFoundation#2095](AcademySoftwareFoundation#2095), Mac compiler path [AcademySoftwareFoundation#2096](AcademySoftwareFoundation#2096), Intel compiler certificate update [AcademySoftwareFoundation#2101](AcademySoftwareFoundation#2101), OIIO dependency hash lockdown [AcademySoftwareFoundation#2102](AcademySoftwareFoundation#2102) (1.15.3.0, 1.14.10.0) Signed-off-by: Larry Gritz <lg@larrygritz.com>

lgritz reviewed Mar 19, 2026

View reviewed changes

AngryLoki force-pushed the ld-lld branch from 700f22d to 58abd4d Compare March 19, 2026 18:26

lgritz approved these changes Mar 19, 2026

View reviewed changes

lgritz merged commit d282e12 into AcademySoftwareFoundation:main Mar 19, 2026
24 of 27 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: Fix compilation with ld.lld#2094

build: Fix compilation with ld.lld#2094
lgritz merged 1 commit intoAcademySoftwareFoundation:mainfrom
AngryLoki:ld-lld

AngryLoki commented Mar 19, 2026

Uh oh!

linux-foundation-easycla bot commented Mar 19, 2026 •

edited

Loading

Uh oh!

lgritz Mar 19, 2026

Uh oh!

AngryLoki Mar 19, 2026

Uh oh!

lgritz Mar 19, 2026

Uh oh!

lgritz commented Mar 19, 2026

Uh oh!

AngryLoki commented Mar 19, 2026

Uh oh!

lgritz left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	if (${CMAKE_CXX_VISIBILITY_PRESET} STREQUAL "hidden" AND VISIBILITY_MAP_FILE AND
	(CMAKE_COMPILER_IS_GNUCC OR CMAKE_COMPILER_IS_CLANG) AND
	(CMAKE_SYSTEM_NAME MATCHES "Linux\|kFreeBSD" OR CMAKE_SYSTEM_NAME STREQUAL "GNU"))
	# Linux/FreeBSD/Hurd: also hide all the symbols of dependent libraries
	# to prevent clashes if an app using this project is linked against
	# other versions of our dependencies.
	set (VISIBILITY_MAP_COMMAND "-Wl,--version-script=${VISIBILITY_MAP_FILE}")
	endif ()

Conversation

AngryLoki commented Mar 19, 2026

Description

Tests

Checklist:

Uh oh!

linux-foundation-easycla bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lgritz Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

AngryLoki Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

lgritz Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

lgritz commented Mar 19, 2026

Uh oh!

AngryLoki commented Mar 19, 2026

Uh oh!

lgritz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

linux-foundation-easycla bot commented Mar 19, 2026 •

edited

Loading