Make fabs() private

Signed-off-by: Darby Johnston <[email protected]>

Author: darbyjohnston

src/opentime/rationalTime.h

@@ -20,25 +20,6 @@ enum OPENTIME_EXPORT IsDropFrameRate : int
     ForceYes      = 1,
 };
 
-/// @brief Returns the absolute value.
-///
-/// \todo This function is used instead of "std::fabs()" so we can mark it as
-/// constexpr. We can remove this and replace it with the std version when we
-/// upgrade to C++ 23.
-///
-/// \todo Remove this function from the public API.
-constexpr double
-fabs(double val) noexcept
-{
-    union
-    {
-        double   f;
-        uint64_t i;
-    } bits = { val };
-    bits.i &= std::numeric_limits<uint64_t>::max() / 2;
-    return bits.f;
-}
-
 /// @brief This class represents a measure of time defined by a value and rate.
 class OPENTIME_EXPORT RationalTime
 {
@@ -423,6 +404,24 @@ class OPENTIME_EXPORT RationalTime
     friend class TimeRange;
 
     double _value, _rate;
+
+    /// @brief Returns the absolute value.
+    ///
+    /// \todo This function is used instead of "std::fabs()" so we can mark it as
+    /// constexpr. We can remove this and replace it with the std version when we
+    /// upgrade to C++ 23. There are two copies of this function, in both
+    /// RationalTime and TimeRange.
+    static constexpr double
+    fabs(double val) noexcept
+    {
+        union
+        {
+            double   f;
+            uint64_t i;
+        } bits = { val };
+        bits.i &= std::numeric_limits<uint64_t>::max() / 2;
+        return bits.f;
+    }
 };
 
 }} // namespace opentime::OPENTIME_VERSION

src/opentime/timeRange.h

@@ -441,6 +441,24 @@ class OPENTIME_EXPORT TimeRange
     {
         return rhs - lhs >= epsilon;
     }
+
+    /// @brief Returns the absolute value.
+    ///
+    /// \todo This function is used instead of "std::fabs()" so we can mark it as
+    /// constexpr. We can remove this and replace it with the std version when we
+    /// upgrade to C++ 23. There are two copies of this function, in both
+    /// RationalTime and TimeRange.
+    static constexpr double
+    fabs(double val) noexcept
+    {
+        union
+        {
+            double   f;
+            uint64_t i;
+        } bits = { val };
+        bits.i &= std::numeric_limits<uint64_t>::max() / 2;
+        return bits.f;
+    }
 };
 
 }} // namespace opentime::OPENTIME_VERSION