Check for negative duration

Signed-off-by: Darby Johnston <[email protected]>

Author: darbyjohnston

src/opentime/timeRange.h

@@ -61,7 +61,7 @@ class TimeRange
     /// duration is invalid.
     bool is_invalid_range() const noexcept
     {
-        return _start_time.is_invalid_time() || _duration.is_invalid_time();
+        return _start_time.is_invalid_time() || _duration.is_invalid_time() || _duration.value() < 0.0;
     }
 
     /// @brief Returns true if the time range is valid.
@@ -70,7 +70,7 @@ class TimeRange
     /// duration are valid.
     bool is_valid_range() const noexcept
     {
-        return _start_time.is_valid_time() && _duration.is_valid_time();
+        return _start_time.is_valid_time() && _duration.is_valid_time() && _duration.value() >= 0.0;
     }
 
     constexpr RationalTime start_time() const noexcept { return _start_time; }

tests/test_opentime.cpp

@@ -162,6 +162,9 @@ main(int argc, char** argv)
         otime::TimeRange r2(0.0, 24.0, 24.0);
         assertTrue(r2.is_valid_range());
         assertFalse(r2.is_invalid_range());
+        otime::TimeRange r3(0.0, -24.0, 24.0);
+        assertFalse(r3.is_valid_range());
+        assertTrue(r3.is_invalid_range());
     });
 
     tests.run(argc, argv);

tests/test_opentime.py

@@ -889,6 +889,9 @@ def test_valid(self):
         tr2 = otio.opentime.TimeRange(0, 48, 24)
         self.assertTrue(tr2.is_valid_range())
         self.assertFalse(tr2.is_invalid_range())
+        tr3 = otio.opentime.TimeRange(0, -48, 24)
+        self.assertFalse(tr3.is_valid_range())
+        self.assertTrue(tr3.is_invalid_range())
 
     def test_duration_validation(self):
         tr = otio.opentime.TimeRange()